Page MenuHomeFreeBSD

Further refine the ExpDataSN checks for SCSI Response PDUs.
ClosedPublic

Authored by jhb on Oct 25 2021, 11:37 PM.
Tags
None
Referenced Files
F108568678: D32650.diff
Sun, Jan 26, 11:04 AM
Unknown Object (File)
Fri, Jan 24, 3:02 AM
Unknown Object (File)
Wed, Jan 22, 5:20 PM
Unknown Object (File)
Fri, Jan 17, 9:39 AM
Unknown Object (File)
Thu, Jan 16, 10:48 AM
Unknown Object (File)
Thu, Jan 16, 9:55 AM
Unknown Object (File)
Thu, Jan 16, 8:07 AM
Unknown Object (File)
Sun, Jan 12, 3:42 PM
Subscribers

Details

Summary

According to 11.4.8 in RFC 7143, ExpDataSN MUST be 0 if the response
code is not Command Completed, but we were requiring it to always be
the count of DataIn PDUs regardless of the response code.

In addition, at least one target (OCI Oracle iSCSI block device)
returns an ExpDataSN of 0 when returning a valid completion with an
error status (Check Condition) in response to a SCSI Inquiry. As a
workaround for this target, only warn without resetting the connection
for a 0 ExpDataSN for responses with a non-zero error status.

PR: 259152
Reported by: dch
Fixes: 4f0f5bf99591 iscsi: Validate DataSN values in Data-In PDUs in the initiator.
Sponsored by: Chelsio Communications

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42354
Build 39242: arc lint + arc unit