Paths

Table of Contentst

Differential D32320

Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU.
AbandonedPublic
Actions

Authored by ray on Oct 5 2021, 3:04 PM.

Tags

None

Referenced Files

	F168750403: D32320.id96275.diff
	Sat, Aug 29, 11:20 PM

	Unknown Object (File)
	Sat, Aug 29, 1:39 PM

	Unknown Object (File)
	Sat, Aug 29, 5:26 AM

	Unknown Object (File)
	Thu, Aug 27, 6:56 AM

	Unknown Object (File)
	Thu, Aug 27, 5:20 AM

	Unknown Object (File)
	Tue, Aug 25, 6:16 AM

	Unknown Object (File)
	Tue, Aug 25, 4:59 AM

	Unknown Object (File)
	Tue, Aug 11, 4:13 PM

View All 94 Files

Subscribers

Details

Reviewers

manu
mhorne
andrew
ali_mashtizadeh.com

Group Reviewers

Summary

Allocate event for DMC-620 and CMN-600 controllers PMU.
Add events supported by DMC-620 and CMN-600 controllers PMU.

Sponsored By: ARM
Sponsored By: Ampere Computing

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41968
Build 38856: arc lint + arc unit

Event Timeline

ray created this revision.Oct 5 2021, 3:04 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 5 2021, 3:04 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

ray requested review of this revision.Oct 5 2021, 3:04 PM

Harbormaster completed remote builds in B41968: Diff 96275.Oct 5 2021, 3:04 PM

ray edited the summary of this revision. (Show Details)Oct 5 2021, 3:06 PM

ray added reviewers: pmc, mhorne.

allanjude added a subscriber: allanjude.Oct 5 2021, 3:25 PM

Is there a review for a dmc620 driver still to come?

lib/libpmc/libpmc.c
1370	Missing `break`?
sys/arm64/include/cmn600_reg.h
30–31
sys/dev/hwpmc/pmc_events.h
2065–2067	Is there a possibility that future revisions of this hw will add more events to any of these lists? Should these ranges be spaced out further to accommodate this?
sys/dev/hwpmc/pmu_dmc620_reg.h
77–81	This struct should go in `sys/dev/hwpmc/hwpmc_dmc620.h`.

allanjude edited the summary of this revision. (Show Details)Oct 20 2021, 11:39 PM

tsoome mentioned this in D35609: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU..Jun 26 2022, 8:38 PM

Completed in D35609.

Many thanks, guys!

Herald added a reviewer: andrew. · View Herald TranscriptMar 23 2026, 12:28 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: ali_mashtizadeh.com. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

lib/

libpmc/

180 lines

sys/

arm64/

include/

793 lines

24 lines

dev/

hwpmc/

54 lines

44 lines

241 lines

pmu_dmc620_reg.h

94 lines

Diff 96275

lib/libpmc/libpmc.c

Loading...

sys/arm64/include/cmn600_reg.h

Loading...

sys/arm64/include/pmc_mdep.h

Loading...

sys/dev/hwpmc/hwpmc_cmn600.h

Loading...

sys/dev/hwpmc/hwpmc_dmc620.h

Loading...

sys/dev/hwpmc/pmc_events.h

Loading...

sys/dev/hwpmc/pmu_dmc620_reg.h

Loading...