Page MenuHomeFreeBSD
Differential D31649

pf tests: test ALTQ CBQ on top of if_vlan
ClosedPublic
Actions

Authored by kp on Aug 23 2021, 7:34 PM.
Tags
None
Referenced Files
F161028956: D31649.id94109.diff
Mon, Jun 29, 11:32 PM
Unknown Object (File)
Fri, Jun 26, 7:50 PM
Unknown Object (File)
Tue, Jun 23, 11:13 PM
Unknown Object (File)
Tue, Jun 23, 1:16 AM
Unknown Object (File)
Mon, Jun 22, 11:01 PM
Unknown Object (File)
Mon, Jun 22, 2:57 PM
Unknown Object (File)
Sat, Jun 20, 7:52 PM
Unknown Object (File)
Wed, Jun 17, 2:45 AM
View All Files
Subscribers
donner
farrokhi
imp
melifaro

Details

Reviewers
donner
Group Reviewers
network
pfsense
Commits
rG97f6c6688934: pf tests: test ALTQ CBQ on top of if_vlan
rGf610aafaed3c: pf tests: test ALTQ CBQ on top of if_vlan
rGe62175df4ec2: pf tests: test ALTQ CBQ on top of if_vlan
Summary

The main purpose of this test is to verify that we can use ALTQ on top
of if_vlan, but while we're here we also exercise the CBQ code. There's
already a basis test for HFSC, so it makes sense to test another
algorithm while we test if_vlan.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41185
Build 38074: arc lint + arc unit

Event Timeline

kp created this revision.Aug 23 2021, 7:34 PM
Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptAug 23 2021, 7:34 PM
kp requested review of this revision.Aug 23 2021, 7:34 PM
Harbormaster completed remote builds in B41173: Diff 94067.Aug 23 2021, 7:34 PM
donner added a subscriber: donner.Aug 24 2021, 8:28 AM
donner added inline comments.
tests/sys/netpfil/pf/altq.sh
134

How do you ensure, that the packets send before are still not delivered, so the queue is empty now? Looks like an scheduling dependency race condition.

How about:

  • prefill the queue (like now)
  • the secondary ping tries to send multiple packets within a short interval
  • check, if all packets of the secondary ping are received back
kp updated this revision to Diff 94109.Aug 24 2021, 2:21 PM

Make the test slightly more robust by sending 5 packets, all of which we expect
to get dropped and allowing one to make it through.

Harbormaster completed remote builds in B41185: Diff 94109.Aug 24 2021, 2:21 PM
donner accepted this revision as: donner.Aug 24 2021, 2:42 PM
This revision is now accepted and ready to land.Aug 24 2021, 2:42 PM
Closed by commit rGe62175df4ec2: pf tests: test ALTQ CBQ on top of if_vlan (authored by kp). · Explain WhyAug 25 2021, 8:05 AM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGe62175df4ec2: pf tests: test ALTQ CBQ on top of if_vlan.
kp added a commit: rGf610aafaed3c: pf tests: test ALTQ CBQ on top of if_vlan.Sep 1 2021, 1:28 PM
kp added a commit: rG97f6c6688934: pf tests: test ALTQ CBQ on top of if_vlan.

Revision Contents
Changeset List

PathSize
tests/
sys/
common/
7 lines
netpfil/
pf/
60 lines

Diff 94109

View Options

tests/sys/common/vnet.subr

Loading...
View Options

tests/sys/netpfil/pf/altq.sh

Loading...