if_vlan: add the ALTQ support to if_vlan.
ClosedPublic
Actions

Authored by kp on Aug 23 2021, 3:52 PM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

Summary

Inspired by the iflib implementation, allow ALTQ to be used with if_vlan
interfaces.

Obtained from: pfsense
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41171
Build 38060: arc lint + arc unit

kp created this revision.Aug 23 2021, 3:52 PM

kp requested review of this revision.Aug 23 2021, 3:52 PM

donner added inline comments.

sys/net/if_vlan.c
1290	May I ask for an one line description for each of the functions?
1322	Is this the same functionality as vlan_altq_start()?

kp added inline comments.Aug 24 2021, 8:12 AM

sys/net/if_vlan.c
1290	These are the standard 'if_start()' functions, common to a lot of network drivers. To the extent that it's documented in the ifnet(9) man page. In essence there are two ways of telling a driver to transmit a packet, if_start(), where the packet is taken from the driver's ifq and the newer if_transmit() where the packet is handed directly to the function. ALTQ uses the driver's ifq during packet scheduling, so it only works when drivers implement if_start().
1322	I'm assuming this was meant to point at vlan_altq_transmit(). In that case: "Yes, sort of.". I believe this is an optimisation. In case ALTQ is not enabled we fall back to vlan_transmit(), and don't queue up the packet at all.