Page MenuHomeFreeBSD
Differential D31646

powerpc64*: workaround for broken binaries generated with llvm12
AbandonedPublic
Actions

Authored by alfredo on Aug 23 2021, 2:05 PM.
Tags
Referenced Files
F175779922: D31646.id.diff
Tue, Oct 13, 7:30 AM
F175742505: D31646.diff
Mon, Oct 12, 11:20 PM
Unknown Object (File)
Mon, Oct 12, 5:05 PM
Unknown Object (File)
Sat, Oct 10, 5:21 PM
Unknown Object (File)
Sat, Oct 10, 5:16 PM
Unknown Object (File)
Sat, Sep 26, 8:51 AM
Unknown Object (File)
Sun, Sep 20, 1:59 AM
Unknown Object (File)
Wed, Sep 16, 9:20 AM
View All Files
Subscribers
bdrewery
emaste
imp
luporl
pkubaj

Details

Reviewers
jhibbits
bdragon
dim
luporl
Summary

powerpc64 and powerpc64 binaries are crashing with segmentation fault when -fstack-protector-strong is used with any optimization level. The binaries seem correct if one of -fstack-protector or -O[0|1|2|3] is ommited.

This patch add a temporary workaround while root cause is being investigated.

MFC after: 1 day

Test Plan

buildworld + chroot
run binaries like clang, ld.lld, llvm-objdump, ls, cp, echo

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41167
Build 38056: arc lint + arc unit

Event Timeline

alfredo created this revision.Aug 23 2021, 2:05 PM
Herald added subscribers: luporl, emaste, imp, bdrewery. · View Herald TranscriptAug 23 2021, 2:05 PM
alfredo requested review of this revision.Aug 23 2021, 2:05 PM
alfredo edited reviewers, added: luporl; removed: leandro.lupori_gmail.com.
Harbormaster completed remote builds in B41167: Diff 94054.Aug 23 2021, 2:06 PM
emaste added a comment.Aug 23 2021, 2:12 PM

is there a PR to reference here?

alfredo updated this revision to Diff 94055.Aug 23 2021, 2:45 PM

Move logic to BROKEN_OPTIONS as suggested by @jhibbits

Harbormaster completed remote builds in B41168: Diff 94055.Aug 23 2021, 2:45 PM
alfredo added a comment.Aug 23 2021, 3:01 PM
In D31646#713717, @emaste wrote:

is there a PR to reference here?

A PR against LLVM? Not yet. I reduced it to a test program available at https://people.freebsd.org/~alfredo/tmp/llvm12_crash/. I should file a PR later today.
On FreeBSD side there a report from a user on freebsd-ppc mailing list: https://lists.freebsd.org/archives/freebsd-ppc/2021-August/000035.html

emaste added a comment.Aug 23 2021, 3:25 PM

Move logic to BROKEN_OPTIONS as suggested by @jhibbits

This will work for src itself, but I think it won't work with ports that use /usr/share/mk?

alfredo added a subscriber: pkubaj.Aug 23 2021, 8:28 PM
In D31646#713731, @emaste wrote:

Move logic to BROKEN_OPTIONS as suggested by @jhibbits

This will work for src itself, but I think it won't work with ports that use /usr/share/mk?

I talked to @pkubaj on IRC, he should take care of ports side after this patch is commited

alfredo abandoned this revision.Aug 26 2021, 7:35 PM

Abandoned in favor of D31698

Revision Contents
Changeset List

PathSize
share/
mk/
5 lines

Diff 94054

View Options

share/mk/bsd.sys.mk

Loading...