Page MenuHomeFreeBSD

powerpc64*: fix for broken binaries generated by llvm12
ClosedPublic

Authored by alfredo on Aug 26 2021, 7:34 PM.

Details

Summary

Selectively reverts LLVM commit 2518433f861fcb877d0a7bdd9aec1aec1f77505a that was pointed as the source of regression on LLVM12.
This affects powerpc64*, making binaries crash with segmentation fault due to bad code generation around "__stack_chk_guard"

Root cause and/or proper fix is under investigation: https://bugs.llvm.org/show_bug.cgi?id=51590

MFC after: 2 days

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

alfredo retitled this revision from powerpc64*: fixfor broken binaries generated by llvm12 to powerpc64*: fix for broken binaries generated by llvm12.Aug 26 2021, 7:42 PM
alfredo edited the summary of this revision. (Show Details)

I wouldn't say "reverts LLVM commit 2518433f861fcb877d0a7bdd9aec1aec1f77505a", but something like "amends LLVM commit 2518433f861fcb877d0a7bdd9aec1aec1f77505a", as we're adding code here. But otherwise, LGTM!

We need to make sure this lands upstream though, and if it's quick enough it might make it into 13.0.0...

This revision is now accepted and ready to land.Aug 26 2021, 7:48 PM

This is not suitable for the upstream. The root cause behind dso_local needs to be found and fixed.

This is not suitable for the upstream. The root cause behind dso_local needs to be found and fixed.

@fbsd-phab_maskray.me, agreed. Thanks for looking at it. We can continue discussion on upstream https://bugs.llvm.org/show_bug.cgi?id=51590 and https://reviews.llvm.org/D109090.