Differential D31470

nd6: Mark several global callouts MPSAFE
ClosedPublic
Actions

Authored by markj on Aug 9 2021, 12:43 AM.

Details

Reviewers

Group Reviewers

network

Commits

rG663428ea17e3: nd6: Mark several callouts as MPSAFE
rG8ee0826f7513: in6: Enter the net epoch in in6_tmpaddrtimer()

Summary

The ND6 code was written pre-SMP, and the use of Giant here is vestigal.
Nothing in the ND6 code depends on it.

Also enter the net epoch in in6_tmpaddrtimer(). It needs to do so to
iterate over the ifnet list safely. This callout runs very
infrequently, so it's not likely to be a problem, but it probably
should also be synchronizing with in6_tmpifadd().

I did not (yet) mark the DAD callout as MPSAFE, it requires further
fixes (but also does not depend on Giant).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40933
Build 37822: arc lint + arc unit

Event Timeline

markj created this revision.Aug 9 2021, 12:43 AM

Herald added subscribers: melifaro, bz, ae, imp. · View Herald TranscriptAug 9 2021, 12:43 AM

markj requested review of this revision.Aug 9 2021, 12:43 AM

Harbormaster completed remote builds in B40933: Diff 93425.Aug 9 2021, 12:43 AM

markj added a reviewer: network.Aug 9 2021, 12:45 AM

markj added a subscriber: mav.

I always wished the argument was a bool or a '''#define''' with a name rather than 1 but that's unrelated to here.
Looks okay to me.

This revision is now accepted and ready to land.Aug 9 2021, 10:18 AM

Closed by commit rG8ee0826f7513: in6: Enter the net epoch in in6_tmpaddrtimer() (authored by markj). · Explain WhyAug 9 2021, 5:49 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG8ee0826f7513: in6: Enter the net epoch in in6_tmpaddrtimer().

markj added a commit: rG663428ea17e3: nd6: Mark several callouts as MPSAFE.

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

in6_ifattach.c

8 lines

nd6.c

4 lines

Diff 93425

View Options

sys/netinet6/in6_ifattach.c