Page MenuHomeFreeBSD

nd6: Mark several global callouts MPSAFE
ClosedPublic

Authored by markj on Aug 9 2021, 12:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 5, 3:48 AM
Unknown Object (File)
Dec 19 2025, 8:51 AM
Unknown Object (File)
Dec 14 2025, 4:34 PM
Unknown Object (File)
Dec 11 2025, 4:28 AM
Unknown Object (File)
Nov 30 2025, 4:01 PM
Unknown Object (File)
Nov 23 2025, 9:20 PM
Unknown Object (File)
Nov 19 2025, 1:41 AM
Unknown Object (File)
Nov 17 2025, 6:44 AM

Details

Summary

The ND6 code was written pre-SMP, and the use of Giant here is vestigal.
Nothing in the ND6 code depends on it.

Also enter the net epoch in in6_tmpaddrtimer(). It needs to do so to
iterate over the ifnet list safely. This callout runs very
infrequently, so it's not likely to be a problem, but it probably
should also be synchronizing with in6_tmpifadd().

I did not (yet) mark the DAD callout as MPSAFE, it requires further
fixes (but also does not depend on Giant).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40933
Build 37822: arc lint + arc unit

Event Timeline

markj requested review of this revision.Aug 9 2021, 12:43 AM

I always wished the argument was a bool or a '''#define''' with a name rather than 1 but that's unrelated to here.
Looks okay to me.

This revision is now accepted and ready to land.Aug 9 2021, 10:18 AM