Differential D31274

Switch to an ifunc in the kernel for crc32c
ClosedPublic
Actions

Authored by andrew on Jul 22 2021, 12:48 PM.

Tags

None

Referenced Files

	F161364398: D31274.id.diff
	Fri, Jul 3, 4:28 AM

	F161363365: D31274.id92626.diff
	Fri, Jul 3, 4:18 AM

	F161318092: D31274.id92679.diff
	Thu, Jul 2, 6:24 PM

	Unknown Object (File)
	Sun, Jun 28, 11:31 AM

	Unknown Object (File)
	May 16 2026, 8:32 PM

	Unknown Object (File)
	May 16 2026, 8:32 PM

	Unknown Object (File)
	May 16 2026, 8:30 PM

	Unknown Object (File)
	May 15 2026, 6:18 PM

View All 100 Files

Subscribers

Details

Reviewers

cem
kib
markj
arichardson

Commits

rG4bc8d0dcdb37: Switch to an ifunc in the kernel for crc32c
rGa93941b439fc: Switch to an ifunc in the kernel for crc32c

Summary

There is no need to read the same variable to check if the CPU supports
crc32c instructions.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40621
Build 37510: arc lint + arc unit

Event Timeline

andrew created this revision.Jul 22 2021, 12:48 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 22 2021, 12:48 PM

andrew requested review of this revision.Jul 22 2021, 12:48 PM

Harbormaster completed remote builds in B40621: Diff 92626.Jul 22 2021, 12:48 PM

kib accepted this revision.Jul 22 2021, 1:23 PM

This revision is now accepted and ready to land.Jul 22 2021, 1:23 PM

Looks good to me. This reminds me that we could use the x86 ifunc to work around https://gitlab.com/qemu-project/qemu/-/issues/427 when detecting QEMU.

markj accepted this revision.Jul 22 2021, 5:20 PM

Closed by commit rGa93941b439fc: Switch to an ifunc in the kernel for crc32c (authored by andrew). · Explain WhyJul 23 2021, 1:28 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGa93941b439fc: Switch to an ifunc in the kernel for crc32c.

andrew added a commit: rG4bc8d0dcdb37: Switch to an ifunc in the kernel for crc32c.Aug 30 2021, 12:44 PM

Revision Contents
Changeset List

Path

Size

sys/

libkern/

56 lines

Diff 92626

sys/libkern/gsb_crc32.c

Loading...