arm64: Use the right PTE when downgrading perms in pmap_promote_l2()
ClosedPublic
Actions

Authored by markj on Jun 4 2021, 6:20 PM.

Details

Reviewers

alc
kib
manu

Group Reviewers

arm64

Commits

rGa48f51b3d396: arm64: Use the right PTE when downgrading perms in pmap_promote_l2()

Summary

When promoting a run of small mappings to a superpage, we have to
downgrade clean, writable mappings to read-only, to handle the
possibility that the MMU will concurrently mark one of the mappings as
dirty.

The code which performed this operation for the first PTE in the run
used the wrong PTE pointer. As a result, the comparison would always
fail, aborting the promotion. This only occurs when promoting writable,
clean mappings.

Fixes: ca2cae0b4dd
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Jun 4 2021, 6:20 PM

Herald added a reviewer: manu. · View Herald TranscriptJun 4 2021, 6:20 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

markj requested review of this revision.Jun 4 2021, 6:20 PM

Harbormaster completed remote builds in B39710: Diff 90426.Jun 4 2021, 6:20 PM

markj added a reviewer: arm64.Jun 4 2021, 6:23 PM

kib accepted this revision.Jun 4 2021, 7:07 PM

This revision is now accepted and ready to land.Jun 4 2021, 7:07 PM

BTW, I did some buildkernel tests on a graviton instance and found no change in the number of promotions during a buildkernel. I can't think of any non-synthetic workloads that are likely to be affected in light of the fact that arm64 implements pmap_enter(psind=1), so faults on a shared mapping skip the promotion step, assuming that some entity triggered the initial promotion through writes.

alc accepted this revision.Jun 5 2021, 6:45 PM

As an aside, I would probably replicate the amd64 comments that we do not need to perform a TLB invalidation in this case.