virtio_blk: Fix issuing T_GET_ID before DRIVER_OK status
ClosedPublic
Actions

Authored by khng on Apr 30 2021, 4:15 PM.

Details

Reviewers

grehan
philip
lwhsu

Group Reviewers

bhyve

Commits

rG6fd5a4a6f3ac: virtio_blk: Fix issuing T_GET_ID before DRIVER_OK status
rG4e1e1d667fc8: virtio_blk: Fix issuing T_GET_ID before DRIVER_OK status

Summary

DRIVER_OK status is set after device_attach() succeeds. For now postpone
disk_create to attach_completed() method.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38936
Build 35825: arc lint + arc unit

Event Timeline

khng created this revision.Apr 30 2021, 4:15 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 30 2021, 4:15 PM

khng requested review of this revision.Apr 30 2021, 4:15 PM

Harbormaster completed remote builds in B38936: Diff 88424.Apr 30 2021, 4:15 PM

khng added a reviewer: bhyve.May 3 2021, 11:02 AM

grehan accepted this revision.May 3 2021, 11:04 AM

This revision is now accepted and ready to land.May 3 2021, 11:04 AM

khng added a reviewer: philip.May 3 2021, 11:06 AM

lwhsu added a subscriber: lwhsu.May 4 2021, 3:23 PM

lwhsu accepted this revision.May 4 2021, 6:18 PM

Closed by commit rG4e1e1d667fc8: virtio_blk: Fix issuing T_GET_ID before DRIVER_OK status (authored by khng). · Explain WhyMay 5 2021, 3:22 PM

This revision was automatically updated to reflect the committed changes.

khng added a commit: rG4e1e1d667fc8: virtio_blk: Fix issuing T_GET_ID before DRIVER_OK status.

khng added a commit: rG6fd5a4a6f3ac: virtio_blk: Fix issuing T_GET_ID before DRIVER_OK status.Jun 28 2021, 3:17 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

block/

virtio_blk.c

20 lines

Diff 88424

View Options

sys/dev/virtio/block/virtio_blk.c

virtio_blk: Fix issuing T_GET_ID before DRIVER_OK statusClosedPublicActions