virtio_blk: Fix initialisation of dump request structure
AcceptedPublic
Actions

Authored by sarah.walker2_arm.com on Mon, Mar 30, 9:21 AM.

Details

Reviewers

andrew
asomers

Summary

Commit c8c37141 ("virtio_blk: Use bus_dma for command/ack buffer allocations")
failed to update initialisation of the dedicated dump request structure. This
caused a panic on attempting to dump core to a virtio_blk device.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71812
Build 68695: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Mon, Mar 30, 9:21 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Mar 30, 9:21 AM

sarah.walker2_arm.com requested review of this revision.Mon, Mar 30, 9:21 AM

Harbormaster completed remote builds in B71812: Diff 174521.Mon, Mar 30, 9:21 AM

sarah.walker2_arm.com added reviewers: andrew, asomers.Mon, Mar 30, 9:22 AM

Works for me. Thanks for the fast fix.

This revision is now accepted and ready to land.Mon, Mar 30, 1:02 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

virtio/

block/

virtio_blk.c

94 lines

Diff 174521

View Options

sys/dev/virtio/block/virtio_blk.c

virtio_blk: Fix initialisation of dump request structureAcceptedPublicActions