Page MenuHomeFreeBSD
Differential D29692

Create VM_MEMATTR_DEVICE on all architectures
ClosedPublic
Actions

Authored by andrew on Apr 10 2021, 12:47 PM.
Tags
None
Referenced Files
F175832019: D29692.diff
Tue, Oct 13, 5:48 PM
Unknown Object (File)
Thu, Oct 8, 4:49 AM
Unknown Object (File)
Sep 12 2026, 2:38 PM
Unknown Object (File)
Sep 10 2026, 5:20 AM
Unknown Object (File)
Sep 10 2026, 5:14 AM
Unknown Object (File)
Sep 8 2026, 12:44 PM
Unknown Object (File)
Sep 6 2026, 1:57 PM
Unknown Object (File)
Sep 6 2026, 11:14 AM
View All Files
Subscribers
imp
jhibbits

Details

Reviewers
kib
jhb
Commits
rGade8b810b02f: Create VM_MEMATTR_DEVICE on all architectures
rG5d2d599d3f34: Create VM_MEMATTR_DEVICE on all architectures
Summary

This is intended to be used with memory mapped IO, e.g. from
bus_space_map with no flags, or pmap_mapdev.

Use this new memory type in the map request configured by
resource_init_map_request, and in pciconf.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Apr 10 2021, 12:47 PM
Herald added subscribers: jhibbits, imp. · View Herald TranscriptApr 10 2021, 12:47 PM
andrew requested review of this revision.Apr 10 2021, 12:47 PM
Harbormaster completed remote builds in B38484: Diff 87202.Apr 10 2021, 12:47 PM
kib added inline comments.Apr 11 2021, 7:48 AM
sys/amd64/include/vm.h
46

Why only for kernel?

Also, the recent change to pci_user.c can be simplified after your introduction of VM_MEMATTR_DEVICE, look at line 1129.

andrew added inline comments.Apr 11 2021, 8:41 AM
sys/amd64/include/vm.h
46

It would break the switch statement in usr.bin/vm/vmstat.c if we don't limit to just the kernel as it will have the same value twice.

kib added inline comments.Apr 11 2021, 10:12 AM
sys/amd64/include/vm.h
46

Then perhaps define MD name VM_MEMATTR_DEVMAP, present on all arches. It would be _UNCACHEABLE on x86, DEVICE on arm. pci_user.c would use _DEVMAP

andrew added inline comments.Apr 11 2021, 11:42 AM
sys/amd64/include/vm.h
46

We could also replace the switch statement with if else, e.g. D29703

andrew updated this revision to Diff 87250.Apr 11 2021, 1:47 PM
  • Remove _KERNEL checks
  • Only use VM_MEMATTR_DEVICE in pciconf
Harbormaster completed remote builds in B38498: Diff 87250.Apr 11 2021, 1:47 PM
andrew edited the summary of this revision. (Show Details)Apr 11 2021, 1:48 PM
kib accepted this revision.Apr 12 2021, 2:01 AM
This revision is now accepted and ready to land.Apr 12 2021, 2:01 AM
Closed by commit rG5d2d599d3f34: Create VM_MEMATTR_DEVICE on all architectures (authored by andrew). · Explain WhyApr 12 2021, 8:41 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG5d2d599d3f34: Create VM_MEMATTR_DEVICE on all architectures.
andrew added a commit: rGade8b810b02f: Create VM_MEMATTR_DEVICE on all architectures.Jun 13 2021, 7:16 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
1 line
i386/
include/
1 line
kern/
2 lines
mips/
include/
1 line
powerpc/
include/
2 lines
usr.sbin/
pciconf/
4 lines

Diff 87297

View Options

sys/amd64/include/vm.h

Loading...
View Options

sys/i386/include/vm.h

Loading...
View Options

sys/kern/subr_bus.c

Loading...
View Options

sys/mips/include/vm.h

Loading...
View Options

sys/powerpc/include/vm.h

Loading...
View Options

usr.sbin/pciconf/pciconf.c

Loading...