Differential D29538

bhyve: Move the gdb_active check to gdb_cpu_suspend().
ClosedPublic
Actions

Authored by jhb on Apr 1 2021, 4:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 9, 1:16 AM

	Unknown Object (File)
	Thu, May 8, 3:29 PM

	Unknown Object (File)
	Fri, Apr 25, 6:50 AM

	Unknown Object (File)
	Tue, Apr 22, 2:42 AM

	Unknown Object (File)
	Sun, Apr 20, 11:15 PM

	Unknown Object (File)
	Sun, Apr 20, 11:08 PM

	Unknown Object (File)
	Sun, Apr 20, 10:55 PM

	Unknown Object (File)
	Sun, Apr 20, 10:55 PM

Subscribers

Details

Reviewers

elenamihailescu22_gmail.com
darius.mihaim_gmail.com

Group Reviewers

Commits

rG77e736186d8f: bhyve: Move the gdb_active check to gdb_cpu_suspend().
rGeacc27affeff: bhyve: Move the gdb_active check to gdb_cpu_suspend().

Summary

The check needs to be in the public routine (gdb_cpu_suspend()), not
in the internal routine called from various places
(_gdb_cpu_suspend()). All the other callers of _gdb_cpu_suspend()
already check gdb_active, and this breaks the use of snapshots when
the debug server is not enabled since gdb_cpu_suspend() tries to lock
an uninitialized mutex.

Reported by: Darius Mihai, Elena Mihailescu
Fixes: 621b5090487de9fed1b503769702a9a2a27cc7bb

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38257
Build 35146: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 1 2021, 4:47 PM

Herald added a reviewer: bhyve. · View Herald TranscriptApr 1 2021, 4:47 PM

Herald added subscribers: bcran, rgrimes, emaste, imp. · View Herald Transcript

jhb requested review of this revision.Apr 1 2021, 4:47 PM

Harbormaster completed remote builds in B38257: Diff 86698.Apr 1 2021, 4:47 PM

jhb added reviewers: elenamihailescu22_gmail.com, darius.mihaim_gmail.com.Apr 1 2021, 4:47 PM

We tested the patch and everything seems OK from our part. The fix works as intended. Thanks!

This revision is now accepted and ready to land.Apr 4 2021, 8:53 AM

ionut.mihalache1506_gmail.com mentioned this in D26387: bhyve - Snapshot Save and Restore multiple devices.Apr 8 2021, 9:36 AM

Closed by commit rGeacc27affeff: bhyve: Move the gdb_active check to gdb_cpu_suspend(). (authored by jhb). · Explain WhyApr 12 2021, 6:45 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGeacc27affeff: bhyve: Move the gdb_active check to gdb_cpu_suspend()..

jhb added a commit: rG77e736186d8f: bhyve: Move the gdb_active check to gdb_cpu_suspend()..Aug 11 2021, 10:15 PM

elenamihailescu22_gmail.com mentioned this in D34718: Warm Migration feature for bhyve [Part 2].Jun 21 2023, 6:15 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

4 lines

Diff 86698

usr.sbin/bhyve/gdb.c

Loading...