Page MenuHomeFreeBSD
Differential D28132

Handle functions that use a nop in the arm64 fbt
ClosedPublic
Actions

Authored by andrew on Jan 13 2021, 11:22 AM.
Tags
None
Referenced Files
F153636898: D28132.id85051.diff
Wed, Apr 22, 1:20 PM
Unknown Object (File)
Sun, Apr 19, 5:24 PM
Unknown Object (File)
Sun, Apr 19, 5:23 PM
Unknown Object (File)
Mon, Apr 13, 7:47 AM
Unknown Object (File)
Mon, Apr 13, 6:53 AM
Unknown Object (File)
Tue, Apr 7, 7:01 PM
Unknown Object (File)
Tue, Apr 7, 12:39 PM
Unknown Object (File)
Mar 17 2026, 1:35 PM
View All Files
Subscribers
emaste
imp

Details

Reviewers
rwatson
gnn
manu
Group Reviewers
arm64
Commits
rGefe35aecb801: Handle functions that use a nop in the arm64 fbt
rG28d945204ea1: Handle functions that use a nop in the arm64 fbt
Summary

To trace leaf asm functions we can insert a single nop instruction as
the first instruction in a function and trigger off this.

Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew created this revision.Jan 13 2021, 11:22 AM
Herald added a reviewer: gnn. · View Herald TranscriptJan 13 2021, 11:22 AM
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B36165: Diff 82202.Jan 13 2021, 11:22 AM
andrew requested review of this revision.Jan 13 2021, 11:22 AM
andrew added a comment.Jan 13 2021, 11:30 AM

Tested with dtrace -n ":::". This will trigger on memcpy as called by dtrace_getnanouptime, however it seems to be inlined by the in tree clang.

gnn accepted this revision.Jan 13 2021, 6:00 PM
This revision is now accepted and ready to land.Jan 13 2021, 6:00 PM
Closed by commit rG28d945204ea1: Handle functions that use a nop in the arm64 fbt (authored by andrew). · Explain WhyMar 3 2021, 2:27 PM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG28d945204ea1: Handle functions that use a nop in the arm64 fbt.
andrew added a commit: rGefe35aecb801: Handle functions that use a nop in the arm64 fbt.Feb 22 2022, 4:40 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
include/
8 lines
cddl/
contrib/
opensolaris/
uts/
common/
sys/
2 lines
dev/
dtrace/
aarch64/
5 lines
fbt/
aarch64/
51 lines

Diff 85051

View Options

sys/arm64/include/asm.h

Loading...
View Options

sys/cddl/contrib/opensolaris/uts/common/sys/dtrace.h

Loading...
View Options

sys/cddl/dev/dtrace/aarch64/dtrace_subr.c

Loading...
View Options

sys/cddl/dev/fbt/aarch64/fbt_isa.c

Loading...