Page MenuHomeFreeBSD
Differential D28012

[POWERPC] add bus_map_resource and bus_unmap_resource DEVMETHODs
ClosedPublic
Actions

Authored by alfredo on Jan 6 2021, 11:12 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, May 15, 11:16 AM
Unknown Object (File)
Fri, May 15, 9:39 AM
Unknown Object (File)
Fri, May 15, 9:11 AM
Unknown Object (File)
Fri, May 15, 6:51 AM
Unknown Object (File)
Fri, May 15, 5:26 AM
Unknown Object (File)
Tue, May 12, 4:04 AM
Unknown Object (File)
Mon, May 11, 7:31 PM
Unknown Object (File)
Mon, May 11, 7:31 PM
View All Files
Subscribers
bdrewery
imp
leonardo.bianconi_eldorado.org.br

Details

Reviewers
jhibbits
bdragon
luporl
bryanv
Commits
rG8d5898458818: powerpc: implement bus_map_resource and bus_unmap_resource DEVMETHODs
rGbefb0817bd5e: powerpc: implement bus_map_resource and bus_unmap_resource DEVMETHODs
Summary

Implements bus_map_resource and bus_unmap_resource DEVMETHODs on powerpc architectures, highly inspired on amd64 platform code.

This is required by virtio-modern (1.x) drivers already commited to main branch.

Test Plan

Tested on powerpc64 QEMU VM with virtio patches not published for review yet

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37332
Build 34221: arc lint + arc unit

Event Timeline

alfredo created this revision.Jan 6 2021, 11:12 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 6 2021, 11:12 PM
alfredo requested review of this revision.Jan 6 2021, 11:12 PM
Harbormaster completed remote builds in B35983: Diff 81782.Jan 6 2021, 11:12 PM
alfredo added inline comments.Jan 6 2021, 11:37 PM
sys/powerpc/powerpc/nexus.c
339

actually part of this statement is wrong, (I mixed things with another issue from virtio-modern code)

Use of bs_be_tag here actually makes virtio driver (net) crash/panic during attachment.

alfredo updated this revision to Diff 84585.EditedFeb 23 2021, 9:16 PM
alfredo edited the test plan for this revision. (Show Details)

bus tag now match platform endian

Harbormaster completed remote builds in B37332: Diff 84585.Feb 23 2021, 9:16 PM
alfredo edited the summary of this revision. (Show Details)Feb 23 2021, 9:18 PM
alfredo added a subscriber: leonardo.bianconi_eldorado.org.br.
alfredo edited reviewers, added: bryanv; removed: bdrewery.Mar 4 2021, 6:24 PM
alfredo added a child revision: D28947: [POWERPC] Switch endian of common dev information.Mar 8 2021, 10:00 PM
bryanv added inline comments.Mar 21 2021, 10:56 PM
sys/powerpc/powerpc/nexus.c
311

Missing ident

alfredo updated this revision to Diff 86273.Mar 24 2021, 9:04 PM
alfredo edited the summary of this revision. (Show Details)

fix ident

alfredo marked an inline comment as done.Mar 24 2021, 9:04 PM
Harbormaster completed remote builds in B38057: Diff 86273.Mar 24 2021, 9:04 PM
bryanv accepted this revision.Mar 28 2021, 2:48 AM
This revision is now accepted and ready to land.Mar 28 2021, 2:48 AM
Closed by commit rGbefb0817bd5e: powerpc: implement bus_map_resource and bus_unmap_resource DEVMETHODs (authored by alfredo). · Explain WhyMar 29 2021, 8:41 PM
This revision was automatically updated to reflect the committed changes.
alfredo added a commit: rGbefb0817bd5e: powerpc: implement bus_map_resource and bus_unmap_resource DEVMETHODs.
alfredo added a commit: rG8d5898458818: powerpc: implement bus_map_resource and bus_unmap_resource DEVMETHODs.May 7 2021, 2:39 AM

Revision Contents
Changeset List

PathSize
sys/
powerpc/
powerpc/
95 lines

Diff 84585

View Options

sys/powerpc/powerpc/nexus.c

Loading...