linuxkpi: Fix a compilation issue when building the Intel QAT/QuickAssist driver
ClosedPublic
Actions

Authored by nc on Jan 9 2021, 2:58 AM.

Details

Reviewers

kib
manu
bz
• hselasky

Commits

rG408c514f7398: linuxkpi: Fix the "error: unknown type name 'u32'" compilation issue when

Summary

linuxkpi: Fix the "error: unknown type name 'u32'" compilation issue when building the Intel QAT/QuickAssist driver.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

nc created this revision.Jan 9 2021, 2:58 AM

Herald added subscribers: linuxkpi, emaste. · View Herald TranscriptJan 9 2021, 2:58 AM

For reference, the compile issue is:

In file included from /root/qat/quickassist/qat/freebsd/sys/modules/qat/qat_common/../../../../../common/freeBSD/drivers/crypto/qat/qat_common/adf_heartbeat.c:69:
/usr/src/sys/compat/linuxkpi/common/include/linux/random.h:66:15: error: unknown type name 'u32'
static inline u32
              ^
/usr/src/sys/compat/linuxkpi/common/include/linux/random.h:67:17: error: unknown type name 'u32'
prandom_u32_max(u32 max)
                ^
2 errors generated.
*** Error code 1

Stop.
make[3]: stopped in /root/qat/quickassist/qat/freebsd/sys/modules/qat/qat_common
*** Error code 1

Stop.
make[2]: stopped in /root/qat/quickassist/qat
gmake[1]: *** [Makefile:1272: qat-driver-all] Error 1
gmake[1]: Leaving directory '/root/qat'
gmake: *** [Makefile:550: all] Error 2
root@omen:~/qat #

kib added inline comments.Jan 9 2021, 5:18 AM

sys/compat/linuxkpi/common/include/linux/random.h
37	Why asm/types.h and not linux/types.h? linux/types.h is what used by Linux' random.h.

Thanks for catching this! Updated.

kib accepted this revision.Jan 9 2021, 6:51 PM

kib edited reviewers, added: manu, bz, • hselasky; removed: jhb, bdrewery, imp, scottl.

This revision is now accepted and ready to land.Jan 9 2021, 6:51 PM

• hselasky accepted this revision.Jan 9 2021, 6:54 PM

Thanks for approving!

I am a Ports committer but not a Source committer, and because of this, someone would need to commit this (unless I am misunderstanding something).

You should be able to commit with added tagline 'Approved by: hselasky, kib'

Thanks! Got it in.

Closed by commit rG408c514f7398: linuxkpi: Fix the "error: unknown type name 'u32'" compilation issue when (authored by nc). · Explain WhyJan 9 2021, 11:29 PM

This revision was automatically updated to reflect the committed changes.

nc added a commit: rG408c514f7398: linuxkpi: Fix the "error: unknown type name 'u32'" compilation issue when.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

random.h

1 line

Diff 81960

View Options

sys/compat/linuxkpi/common/include/linux/random.h

linuxkpi: Fix a compilation issue when building the Intel QAT/QuickAssist driverClosedPublicActions