IOV tasks upon iflib device or psuedo device register failure.
ClosedPublic
Actions

Authored by stallamr_netapp.com on Nov 23 2020, 5:36 PM.

Details

Reviewers

markj
shurd
gallatin
• hselasky

Group Reviewers

iflib
NetApp

Commits

rS368412: iflib: Avoid leaking the freelist bitmaps upon driver detach
rS368411: iflib: Detach tasks upon device registration failure

Summary

Once MSIX interrupt assign is complete, Rx/Tx/IOV tasks gets attach to respective taskqueues. Upon IFDI_ATTACH_POST()
or any failure beyond interrupt assignment, only admin tasks gets detached so far. While I'm here, group taskqueue
detach tasks into single function and use new function instead.

Test Plan

At NetApp, tested with kernel failpoints on physical interfaces. Didnot test psuedo interfaces though.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35007
Build 31992: arc lint + arc unit

Event Timeline

stallamr_netapp.com created this revision.Nov 23 2020, 5:36 PM

Herald added a reviewer: iflib. · View Herald TranscriptNov 23 2020, 5:36 PM

Herald added subscribers: melifaro, ae. · View Herald Transcript

stallamr_netapp.com requested review of this revision.Nov 23 2020, 5:36 PM

Harbormaster completed remote builds in B34984: Diff 79907.Nov 23 2020, 5:36 PM

stallamr_netapp.com added a reviewer: NetApp.Nov 23 2020, 5:37 PM

markj added inline comments.Nov 24 2020, 6:08 PM

sys/net/iflib.c
5079	This calls `iflib_rx_sds_free()` on each rxq, so why is it necessary to keep freeing the freelist bitmaps in the loop immediately above?
5150	Same question as above.

stallamr_netapp.com added inline comments.Nov 24 2020, 6:35 PM

sys/net/iflib.c
5079	Thanks Mark for pointing this out. I agree. Above loop to free bitmap is not necessary. I will remove the loop and refresh the change.
5150	Agree. Will remove the loop and refresh the review.