Differential D26689

Store the send tag type in the common send tag header.
ClosedPublic
Actions

Authored by jhb on Oct 5 2020, 9:16 PM.

Tags

None

Referenced Files

	F169830838: D26689.id.diff
	Wed, Sep 2, 5:05 PM

	Unknown Object (File)
	Tue, Sep 1, 12:26 PM

	Unknown Object (File)
	Tue, Sep 1, 3:17 AM

	Unknown Object (File)
	Tue, Sep 1, 2:21 AM

	Unknown Object (File)
	Mon, Aug 31, 7:29 PM

	Unknown Object (File)
	Mon, Aug 31, 4:30 PM

	Unknown Object (File)
	Sun, Aug 30, 11:28 AM

	Unknown Object (File)
	Sat, Aug 29, 4:24 PM

Subscribers

menyy_mellanox.com

Details

Reviewers

gallatin
• hselasky
np
kib

Commits

rS366491: Store the send tag type in the common send tag header.

Summary

Both cxgbe(4) and mlx5(4) wrapped the existing send tag header with
their own identical headers that stored the type that the
type-specific tag structures inherited from, so in practice it seems
drivers need this in the tag anyway. This permits removing these
extra header indirections (struct cxgbe_snd_tag and struct
mlx5e_snd_tag).

In addition, this permits driver-independent code to query the type of
a tag, e.g. to know what type of tag is being queried via
if_snd_query.

Test Plan

tested NIC TLS on T6
Drew tested this as part of the TLS ratelimit patches

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 5 2020, 9:16 PM

Herald added subscribers: melifaro, ae. · View Herald TranscriptOct 5 2020, 9:16 PM

jhb requested review of this revision.Oct 5 2020, 9:16 PM

Harbormaster completed remote builds in B34007: Diff 77917.Oct 5 2020, 9:17 PM

gallatin accepted this revision.Oct 5 2020, 9:19 PM

This revision is now accepted and ready to land.Oct 5 2020, 9:19 PM

np accepted this revision.Oct 5 2020, 9:23 PM

jhb added a child revision: D26691: Support hardware rate limiting (pacing) with TLS offload..Oct 5 2020, 9:24 PM

kib accepted this revision.Oct 5 2020, 9:43 PM

kib added a subscriber: menyy_mellanox.com.

Looks good - approved!

Closed by commit rS366491: Store the send tag type in the common send tag header. (authored by jhb). · Explain WhyOct 14 2020, 5:23 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS366491: Store the send tag type in the common send tag header..

Herald added a subscriber: imp. · View Herald TranscriptOct 14 2020, 5:23 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

cxgbe/

1 line

crypto/

14 lines

16 lines

28 lines

4 lines

32 lines

mlx5/

mlx5_en/

7 lines

2 lines

2 lines

mlx5_en_hw_tls.c

30 lines

25 lines

12 lines

15 lines

kern/

3 lines

net/

2 lines

2 lines

sys/

3 lines

Diff 78225

head/sys/dev/cxgbe/adapter.h

Loading...

head/sys/dev/cxgbe/crypto/t4_kern_tls.c

Loading...

head/sys/dev/cxgbe/offload.h

Loading...

head/sys/dev/cxgbe/t4_main.c

Loading...

head/sys/dev/cxgbe/t4_sched.c

Loading...

head/sys/dev/cxgbe/t4_sge.c

Loading...

head/sys/dev/mlx5/mlx5_en/en.h

Loading...

head/sys/dev/mlx5/mlx5_en/en_hw_tls.h

Loading...

head/sys/dev/mlx5/mlx5_en/en_rl.h

Loading...

head/sys/dev/mlx5/mlx5_en/mlx5_en_hw_tls.c

Loading...

head/sys/dev/mlx5/mlx5_en/mlx5_en_main.c

Loading...

head/sys/dev/mlx5/mlx5_en/mlx5_en_rl.c

Loading...

head/sys/dev/mlx5/mlx5_en/mlx5_en_tx.c

Loading...

head/sys/kern/kern_mbuf.c

Loading...

head/sys/net/if_lagg.c

Loading...

head/sys/net/if_vlan.c

Loading...

head/sys/sys/mbuf.h

Loading...