Page MenuHomeFreeBSD

Stop using -O instead of -O2 for MIPS
ClosedPublic

Authored by arichardson on Oct 12 2020, 12:43 PM.
Tags
None
Referenced Files
F137003702: D26749.id.diff
Thu, Nov 20, 11:24 PM
F137003456: D26749.id78158.diff
Thu, Nov 20, 11:23 PM
F137001911: D26749.id78133.diff
Thu, Nov 20, 11:18 PM
F137000476: D26749.diff
Thu, Nov 20, 11:13 PM
Unknown Object (File)
Mon, Oct 27, 2:39 AM
Unknown Object (File)
Oct 18 2025, 12:03 PM
Unknown Object (File)
Oct 18 2025, 12:02 PM
Unknown Object (File)
Oct 18 2025, 12:02 PM

Details

Summary

Until clang 11 that was equivalent to -O2, but clang changed it to -O1 so
generated MIPS code will now be unnecessarily slow. It also removes a weird
special case from sys.mk.
This is similar to the D26471 change for debug kernels and should not change
anything since everything was previously building MIPS code at -O2 until clang
was updated to 11.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

share/mk/sys.mk
166 ↗(On Diff #78133)

And this one?

share/mk/sys.mk
166 ↗(On Diff #78133)

POSIX's c89 only gives you -O, -O0 and -O1, with additional levels merely optional.

This revision is now accepted and ready to land.Oct 12 2020, 5:27 PM
This revision was automatically updated to reflect the committed changes.