Page MenuHomeFreeBSD

Stop using -O instead of -O2 for MIPS
ClosedPublic

Authored by arichardson on Oct 12 2020, 12:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 27, 7:20 AM
Unknown Object (File)
Thu, Nov 27, 7:19 AM
Unknown Object (File)
Thu, Nov 20, 11:24 PM
Unknown Object (File)
Thu, Nov 20, 11:23 PM
Unknown Object (File)
Thu, Nov 20, 11:18 PM
Unknown Object (File)
Thu, Nov 20, 11:13 PM
Unknown Object (File)
Oct 27 2025, 2:39 AM
Unknown Object (File)
Oct 18 2025, 12:03 PM

Details

Summary

Until clang 11 that was equivalent to -O2, but clang changed it to -O1 so
generated MIPS code will now be unnecessarily slow. It also removes a weird
special case from sys.mk.
This is similar to the D26471 change for debug kernels and should not change
anything since everything was previously building MIPS code at -O2 until clang
was updated to 11.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34112
Build 31280: arc lint + arc unit

Event Timeline

share/mk/sys.mk
166

And this one?

share/mk/sys.mk
166

POSIX's c89 only gives you -O, -O0 and -O1, with additional levels merely optional.

This revision is now accepted and ready to land.Oct 12 2020, 5:27 PM
This revision was automatically updated to reflect the committed changes.