Page MenuHomeFreeBSD

Store the send tag type in the common send tag header.
ClosedPublic

Authored by jhb on Oct 5 2020, 9:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 27, 11:33 PM
Unknown Object (File)
Tue, Sep 22, 6:48 PM
Unknown Object (File)
Mon, Sep 21, 10:41 AM
Unknown Object (File)
Tue, Sep 8, 12:21 AM
Unknown Object (File)
Sat, Sep 5, 8:10 PM
Unknown Object (File)
Sat, Sep 5, 8:10 PM
Unknown Object (File)
Sat, Sep 5, 6:18 PM
Unknown Object (File)
Thu, Sep 3, 5:41 PM

Details

Summary

Both cxgbe(4) and mlx5(4) wrapped the existing send tag header with
their own identical headers that stored the type that the
type-specific tag structures inherited from, so in practice it seems
drivers need this in the tag anyway. This permits removing these
extra header indirections (struct cxgbe_snd_tag and struct
mlx5e_snd_tag).

In addition, this permits driver-independent code to query the type of
a tag, e.g. to know what type of tag is being queried via
if_snd_query.

Test Plan
  • tested NIC TLS on T6
  • Drew tested this as part of the TLS ratelimit patches

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 34007
Build 31196: arc lint + arc unit