Page MenuHomeFreeBSD

Store the send tag type in the common send tag header.
ClosedPublic

Authored by jhb on Oct 5 2020, 9:16 PM.
Tags
None
Referenced Files
F152059894: D26689.id77917.diff
Sun, Apr 12, 10:46 AM
Unknown Object (File)
Sat, Apr 11, 8:50 PM
Unknown Object (File)
Sat, Apr 11, 12:34 PM
Unknown Object (File)
Fri, Apr 10, 4:03 PM
Unknown Object (File)
Tue, Apr 7, 8:49 AM
Unknown Object (File)
Sat, Apr 4, 9:56 PM
Unknown Object (File)
Mon, Mar 30, 12:34 PM
Unknown Object (File)
Sat, Mar 28, 6:51 AM

Details

Summary

Both cxgbe(4) and mlx5(4) wrapped the existing send tag header with
their own identical headers that stored the type that the
type-specific tag structures inherited from, so in practice it seems
drivers need this in the tag anyway. This permits removing these
extra header indirections (struct cxgbe_snd_tag and struct
mlx5e_snd_tag).

In addition, this permits driver-independent code to query the type of
a tag, e.g. to know what type of tag is being queried via
if_snd_query.

Test Plan
  • tested NIC TLS on T6
  • Drew tested this as part of the TLS ratelimit patches

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 34007
Build 31196: arc lint + arc unit