Add a macro to check for IPv6 multicast MAC addresses
ClosedPublic
Actions

Authored by mhorne on Sep 30 2020, 5:45 PM.

Details

Reviewers

adrian
rscheff
erj
thj
bz
ae

Commits

rS367163: net: add ETHER_IS_IPV6_MULTICAST

Summary

This can be used to query if a received ethernet packet has an IPv6
multicast address, e.g. for IPv6 Neighbor Discovery Protocol.

Of course, ETHER_IS_MULTICAST is still preferred in the general case.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33902
Build 31104: arc lint + arc unit

Event Timeline

mhorne created this revision.Sep 30 2020, 5:45 PM

Herald added subscribers: melifaro, ae. · View Herald TranscriptSep 30 2020, 5:45 PM

mhorne requested review of this revision.Sep 30 2020, 5:45 PM

Harbormaster completed remote builds in B33902: Diff 77692.Sep 30 2020, 5:45 PM

allanjude added reviewers: thj, bz.Oct 6 2020, 1:43 PM

Hi, any thoughts on this?

This definition is used by NetApp as part of a larger set of changes that is not yet upstream-ready. It doesn't offer much value on its own, but helps reduce their local diff against FreeBSD.

I'd appreciate a prod in either direction of "looks good, go ahead" or "save it for the larger patch". Thanks.

For reference, this definition comes from RFC 2464, Section 7.

ae accepted this revision.Oct 29 2020, 4:05 PM

This revision is now accepted and ready to land.Oct 29 2020, 4:05 PM

Closed by commit rS367163: net: add ETHER_IS_IPV6_MULTICAST (authored by mhorne). · Explain WhyOct 30 2020, 1:33 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rS367163: net: add ETHER_IS_IPV6_MULTICAST.

Herald added a subscriber: imp. · View Herald TranscriptOct 30 2020, 1:33 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

ethernet.h

2 lines

Diff 77692

View Options

Add a macro to check for IPv6 multicast MAC addressesClosedPublicActions