Page MenuHomeFreeBSD
Differential D25874

remove some serial drivers (rc, rp, cy)
ClosedPublic
Actions

Authored by jmg on Jul 29 2020, 6:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 9:09 PM
Unknown Object (File)
Oct 22 2024, 5:51 AM
Unknown Object (File)
Sep 29 2024, 7:27 AM
Unknown Object (File)
Sep 28 2024, 5:12 AM
Unknown Object (File)
Sep 24 2024, 4:38 PM
Unknown Object (File)
Sep 24 2024, 4:44 AM
Unknown Object (File)
Sep 23 2024, 10:44 PM
Unknown Object (File)
Sep 20 2024, 6:57 AM
View All 77 Files
Subscribers
0mp
bcr
zeising

Details

Reviewers
imp
emaste
phk
kevans
Group Reviewers
manpages
Commits
rS363683: remove some long abandonded serial drivers (cy, rc, rp) since 2008
Summary

These drivers were left behind in 2008 when the switch to
MPSAFE tty was done. They haven't been hooked up to the
build, and a couple of them still reference ttycreate which
doesn't exist anymore.

Test Plan

make universe
(to be done)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32643
Build 30096: arc lint + arc unit

Event Timeline

jmg created this revision.Jul 29 2020, 6:59 AM
Herald added a reviewer: manpages. · View Herald TranscriptJul 29 2020, 6:59 AM
jmg requested review of this revision.Jul 29 2020, 6:59 AM
Harbormaster completed remote builds in B32637: Diff 75106.Jul 29 2020, 6:59 AM
jmg updated this revision to Diff 75107.Jul 29 2020, 7:01 AM

too smart w/ command line, include the rest of the files..

Harbormaster completed remote builds in B32638: Diff 75107.Jul 29 2020, 7:01 AM
jmg edited the summary of this revision. (Show Details)Jul 29 2020, 7:01 AM
phk accepted this revision.Jul 29 2020, 8:04 AM

Way overdue.

This revision is now accepted and ready to land.Jul 29 2020, 8:04 AM
jmg updated this revision to Diff 75110.Jul 29 2020, 8:05 AM

forgot to remove from files..

This revision now requires review to proceed.Jul 29 2020, 8:05 AM
Harbormaster completed remote builds in B32641: Diff 75110.Jul 29 2020, 8:05 AM
jmg updated this revision to Diff 75112.Jul 29 2020, 8:56 AM

didn't complain about missing file on command line, that being
rp's module dir..

Harbormaster completed remote builds in B32643: Diff 75112.Jul 29 2020, 8:56 AM
0mp added a subscriber: 0mp.Jul 29 2020, 10:10 AM

It looks like no manual pages reference those drivers anymore (checked with ag 'Xr (rc|rp|cy) 4')

zeising added a subscriber: zeising.Jul 29 2020, 10:46 AM

Removed manual pages need to be added to ObsoleteFiles.inc as well.

bcr accepted this revision as: manpages.Jul 29 2020, 11:43 AM
bcr added a subscriber: bcr.

All good from manpages.

emaste accepted this revision.Jul 29 2020, 1:01 PM

Modules also need to be added to ObsoleteFiles.inc

This revision is now accepted and ready to land.Jul 29 2020, 1:01 PM
jmg added a comment.Jul 29 2020, 7:34 PM
In D25874#573062, @zeising wrote:

Removed manual pages need to be added to ObsoleteFiles.inc as well.

Thanks for the reminder. I thought of this, and then promptly forgot before doing it. :)

kevans accepted this revision.Jul 29 2020, 11:42 PM
jmg closed this revision.Jul 30 2020, 6:08 AM

commited in https://reviews.freebsd.org/rS363683

Not sure why it didn't auto close.

jmg added a commit: rS363683: remove some long abandonded serial drivers (cy, rc, rp) since 2008.Oct 20 2020, 6:57 AM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
3 lines
sys/
conf/
7 lines
dev/
2242 lines
152 lines
194 lines
77 lines
38 lines
1314 lines
72 lines
1113 lines
508 lines
368 lines
1033 lines
76 lines
modules/
8 lines
8 lines

Diff 75112

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/cy.4

Loading...
View Options

share/man/man4/rc.4

Loading...
View Options

share/man/man4/rp.4

Loading...
View Options

sys/conf/files

Loading...
View Options

sys/dev/cy/

Loading...
View Options

sys/dev/cy/cy.c

Loading...
View Options

sys/dev/cy/cy_isa.c

Loading...
View Options

sys/dev/cy/cy_pci.c

Loading...
View Options

sys/dev/cy/cyreg.h

Loading...
View Options

sys/dev/cy/cyvar.h

Loading...
View Options

sys/dev/rc/

Loading...
View Options

sys/dev/rc/rc.c

Loading...
View Options

sys/dev/rc/rcreg.h

Loading...
View Options

sys/dev/rp/

Loading...
View Options

sys/dev/rp/rp.c

Loading...
View Options

sys/dev/rp/rp_isa.c

Loading...
View Options

sys/dev/rp/rp_pci.c

Loading...
View Options

sys/dev/rp/rpreg.h

Loading...
View Options

sys/dev/rp/rpvar.h

Loading...
View Options

sys/modules/rc/

Loading...
View Options

sys/modules/rc/Makefile

Loading...
View Options

sys/modules/rp/

Loading...
View Options

sys/modules/rp/Makefile

Loading...