Page MenuHomeFreeBSD

remove some serial drivers (rc, rp, cy)
ClosedPublic

Authored by jmg on Jul 29 2020, 6:59 AM.

Details

Reviewers
imp
emaste
phk
kevans
Group Reviewers
manpages
Summary

These drivers were left behind in 2008 when the switch to
MPSAFE tty was done. They haven't been hooked up to the
build, and a couple of them still reference ttycreate which
doesn't exist anymore.

Test Plan

make universe
(to be done)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 32637
Build 30090: arc lint + arc unit

Event Timeline

jmg created this revision.Jul 29 2020, 6:59 AM
jmg requested review of this revision.Jul 29 2020, 6:59 AM
jmg updated this revision to Diff 75107.Jul 29 2020, 7:01 AM

too smart w/ command line, include the rest of the files..

jmg edited the summary of this revision. (Show Details)Jul 29 2020, 7:01 AM
phk accepted this revision.Jul 29 2020, 8:04 AM

Way overdue.

This revision is now accepted and ready to land.Jul 29 2020, 8:04 AM
jmg updated this revision to Diff 75110.Jul 29 2020, 8:05 AM

forgot to remove from files..

This revision now requires review to proceed.Jul 29 2020, 8:05 AM
jmg updated this revision to Diff 75112.Jul 29 2020, 8:56 AM

didn't complain about missing file on command line, that being
rp's module dir..

0mp added a subscriber: 0mp.Jul 29 2020, 10:10 AM

It looks like no manual pages reference those drivers anymore (checked with ag 'Xr (rc|rp|cy) 4')

Removed manual pages need to be added to ObsoleteFiles.inc as well.

bcr accepted this revision as: manpages.Jul 29 2020, 11:43 AM
bcr added a subscriber: bcr.

All good from manpages.

emaste accepted this revision.Jul 29 2020, 1:01 PM

Modules also need to be added to ObsoleteFiles.inc

This revision is now accepted and ready to land.Jul 29 2020, 1:01 PM
jmg added a comment.Jul 29 2020, 7:34 PM

Removed manual pages need to be added to ObsoleteFiles.inc as well.

Thanks for the reminder. I thought of this, and then promptly forgot before doing it. :)

kevans accepted this revision.Jul 29 2020, 11:42 PM
jmg closed this revision.Jul 30 2020, 6:08 AM

commited in https://reviews.freebsd.org/rS363683

Not sure why it didn't auto close.