Only include object files from .ALLSRC when linking crt1 objects.
ClosedPublic
Actions

Authored by jhb on Jun 26 2020, 4:55 PM.

Details

Reviewers

kib
sjg
emaste

Commits

rS362660: Only include object files from .ALLSRC when linking crt1 objects.

Test Plan

make tinderbox and readelf -n of /bin/sh for all archs still shows all notes

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31980
Build 29527: arc lint + arc unit

Event Timeline

jhb created this revision.Jun 26 2020, 4:55 PM

Herald added subscribers: emaste, andrew. · View Herald TranscriptJun 26 2020, 4:55 PM

jhb requested review of this revision.Jun 26 2020, 4:55 PM

Harbormaster completed remote builds in B31980: Diff 73699.Jun 26 2020, 4:55 PM

LGTM, maybe worth a comment?

This revision is now accepted and ready to land.Jun 26 2020, 5:12 PM

We already use a slightly different pattern (ALLSRC:N:*.h:[1]) in csu/Makefile.inc without a comment, and also not sure what the comment would say? I am hopeful if I can get some of the other reviews in this train all landed that I can move most of this duplicated logic up into csu/Makefile.inc anyway at which point there would be a single instance of this command.

kib accepted this revision.Jun 26 2020, 7:10 PM

jhb added a child revision: D25304: Include ABI note tag in shared libraries..Jun 26 2020, 7:34 PM

jhb added a parent revision: D25374: Always compile the brand and ignore init ELF notes standalone..

Closed by commit rS362660: Only include object files from .ALLSRC when linking crt1 objects. (authored by jhb). · Explain WhyJun 26 2020, 7:46 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS362660: Only include object files from .ALLSRC when linking crt1 objects..

Herald added a subscriber: imp. · View Herald TranscriptJun 26 2020, 7:46 PM