Page MenuHomeFreeBSD

Always compile the brand and ignore init ELF notes standalone.
ClosedPublic

Authored by jhb on Jun 20 2020, 6:42 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Jun 20 2020, 6:42 PM

I will rebase my other changes on top of this if it gets ok'd.

kib added inline comments.
lib/csu/arm/crt1_s.S
48 ↗(On Diff #73400)

This line was left from an intermediate version ?

69 ↗(On Diff #73400)

Might be add arm_ignore_init_note.S ? Or if Makefile rules allow to handle it without much trouble, arm/ignore_init_note.S ?

This revision is now accepted and ready to land.Jun 20 2020, 7:14 PM
  • Fixup for needed #include.
This revision now requires review to proceed.Jun 22 2020, 10:16 PM
lib/csu/arm/crt1_s.S
48 ↗(On Diff #73400)

Oops, yes. I wasn't sure if I needed it for the NT_FREEBSD_ARCH_TAG (you'd think I would need it actually for that). Hmm, I'll rebuild to make sure I don't need this.

Ah, so the assembler didn't reject this, but linking binaries eventually fails due to an undefined symbol for NT_FREEBSD_ARCH_TAG. I've uncommented the #include. For some reason doing a 'rm /usr/obj/<path>/*/bin/sh/sh' didn't relink /bin/sh. Ah, I probably needed to delete sh.full.

69 ↗(On Diff #73400)

Well, it would be more like arch_tag_note.S. I didn't think we wanted it on other platforms (if we did we'd have to fix them all to construct MACHINE_ARCH in a safe way). If we do maybe want it on other platforms some day that would argue for moving it to its own file, but I feel like we can probably wait to do that until it's needed for something other than arm?

This revision is now accepted and ready to land.Jun 23 2020, 3:36 AM