Page MenuHomeFreeBSD

Only include object files from .ALLSRC when linking crt1 objects.
ClosedPublic

Authored by jhb on Jun 26 2020, 4:55 PM.

Details

Test Plan
  • make tinderbox and readelf -n of /bin/sh for all archs still shows all notes

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Jun 26 2020, 4:55 PM

LGTM, maybe worth a comment?

This revision is now accepted and ready to land.Jun 26 2020, 5:12 PM

We already use a slightly different pattern (ALLSRC:N:*.h:[1]) in csu/Makefile.inc without a comment, and also not sure what the comment would say? I am hopeful if I can get some of the other reviews in this train all landed that I can move most of this duplicated logic up into csu/Makefile.inc anyway at which point there would be a single instance of this command.