Page MenuHomeFreeBSD
Differential D25414

bhyve: allow for automatic destruction on power-off
ClosedPublic
Actions

Authored by kaktus on Jun 23 2020, 5:58 PM.
Tags
None
Referenced Files
F136997213: D25414.id.diff
Thu, Nov 20, 11:00 PM
F136993921: D25414.id73551.diff
Thu, Nov 20, 10:48 PM
F136993787: D25414.id73531.diff
Thu, Nov 20, 10:48 PM
F136993428: D25414.id73625.diff
Thu, Nov 20, 10:47 PM
F136991553: D25414.diff
Thu, Nov 20, 10:41 PM
Unknown Object (File)
Tue, Nov 18, 10:26 PM
Unknown Object (File)
Tue, Nov 18, 3:39 PM
Unknown Object (File)
Tue, Nov 18, 6:42 AM
View All Files
Subscribers
0mp
bcran
grehan
imp
rgrimes

Details

Reviewers
swills
grehan
0mp
kib
Group Reviewers
bhyve
manpages
Commits
rS362612: bhyve: allow for automatic destruction on power-off
Summary

Introduce -D flag that allows for the VM to be destroyed on guest initiated power-off by the bhyve(8) process itself.
This is quality of life change that allows for simpler deployments without the need for bhyvectl --destroy.

Requested by: swills

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kaktus created this revision.Jun 23 2020, 5:58 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptJun 23 2020, 5:58 PM
kaktus requested review of this revision.Jun 23 2020, 5:58 PM
Harbormaster completed remote builds in B31900: Diff 73531.Jun 23 2020, 5:58 PM
grehan accepted this revision.Jun 23 2020, 8:35 PM
grehan added a subscriber: grehan.

Nice change. Don't forget to update the man page.

This revision is now accepted and ready to land.Jun 23 2020, 8:35 PM
kaktus updated this revision to Diff 73551.Jun 23 2020, 10:04 PM
kaktus added a reviewer: manpages.

Update man page.

@grehan happy for a MFC in say 2 weeks after commit to head?

This revision now requires review to proceed.Jun 23 2020, 10:04 PM
Harbormaster completed remote builds in B31910: Diff 73551.Jun 23 2020, 10:04 PM
grehan added a comment.Jun 23 2020, 10:06 PM

happy for a MFC in say 2 weeks after commit to head?

Yep, sounds good.

0mp accepted this revision.Jun 23 2020, 10:12 PM
0mp added a subscriber: 0mp.

LGTM when it comes to the manual.

Also, maybe Relnotes: yes?

This revision is now accepted and ready to land.Jun 23 2020, 10:12 PM
swills added a comment.Jun 24 2020, 3:48 PM

This is a really great, thank you so much! Overall, this looks very good, only noticed one minor question.

usr.sbin/bhyve/bhyverun.c
807 ↗(On Diff #73551)

Not sure 1 still makes sense in this case. It's not indicating a failure or issue of some kind, is it?

swills accepted this revision.Jun 24 2020, 4:59 PM
kaktus added a comment.Jun 24 2020, 7:35 PM

As mentioned on irc, I believe we're bound by the already defined exit codes, as describes in section EXIT STATUS of bhyve(8).

kib accepted this revision.Jun 25 2020, 11:44 AM
Closed by commit rS362612: bhyve: allow for automatic destruction on power-off (authored by kaktus). · Explain WhyJun 25 2020, 12:35 PM
This revision was automatically updated to reflect the committed changes.
kaktus added a commit: rS362612: bhyve: allow for automatic destruction on power-off.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bhyve/
6 lines
13 lines

Diff 73625

View Options

head/usr.sbin/bhyve/bhyve.8

Loading...
View Options

head/usr.sbin/bhyve/bhyverun.c

Loading...