Sync vis(1) with recent NetBSD sources
ClosedPublic
Actions

Authored by gbe on Jun 19 2020, 11:06 AM.

Details

Reviewers

emaste
lwhsu

Group Reviewers

manpages
Src Committers

Commits

rG15fccd86b9dd: Merge tag 'vendor/NetBSD/vis/20210621' into vis

Summary

Sync vis(1) with recent NetBSD sources.

This differential replaces https://reviews.freebsd.org/D23893, which was a direct update to the src repository.

Test Plan

make in the vis directory, after a merge from vendor -> src

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 31825
Build 29385: arc lint + arc unit

Event Timeline

gbe created this revision.Jun 19 2020, 11:06 AM

Herald added a reviewer: manpages. · View Herald TranscriptJun 19 2020, 11:06 AM

Herald added a subscriber: imp. · View Herald Transcript

gbe requested review of this revision.Jun 19 2020, 11:06 AM

Harbormaster completed remote builds in B31825: Diff 73329.Jun 19 2020, 11:06 AM

gbe edited the summary of this revision. (Show Details)Jun 19 2020, 11:07 AM

gbe added a reviewer: Src Committers.

bcr added a subscriber: bcr.Jun 19 2020, 12:12 PM

bcr added inline comments.

vis.1
140	s/non-white space/non-whitespace/ (I'm thinking we should add this to our word list here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-word-list.html)

Address the comments.

vis.1
140	This is a vendor import. I would just wait to get this into -CURRENT and then fix the manpage towards to our standards. There is also a manpage update pending by @fernape that adds an example section to the manpage, which, should after the manpage update also been send upstream.

@emaste like requested, this is a vendor import of the recent vis sources.

fernape mentioned this in D25242: vis(1): Add EXAMPLES section.Jul 21 2020, 4:51 PM

Could someone review and maybe commit this?

@emaste, would it be okay if I commit this?

I would update the vendor sources first and then I would use the usual 'svn copy' method to do the merge from the vendor branch.

@emaste ping?

@emaste is there anything I can do to get this committed?

@emaste any change that this can be committed before the switch to git?

In D25358#618884, @gbe wrote:

@emaste any change that this can be committed before the switch to git?

Nope. It will have to wait. Your reward for eating, though, is that I'd be happy to do the import to test the process for real once things open again.

In D25358#618885, @imp wrote:

In D25358#618884, @gbe wrote:

@emaste any change that this can be committed before the switch to git?

Nope. It will have to wait. Your reward for eating, though, is that I'd be happy to do the import to test the process for real once things open again.

OK, even if I don't understand the phrase "your reward for eating", since I am not a native speaker. ;)

In D25358#618886, @gbe wrote:

In D25358#618885, @imp wrote:

In D25358#618884, @gbe wrote:

@emaste any change that this can be committed before the switch to git?

Nope. It will have to wait. Your reward for eating, though, is that I'd be happy to do the import to test the process for real once things open again.

OK, even if I don't understand the phrase "your reward for eating", since I am not a native speaker. ;)

Waiting. Your reward for waiting. I can't type this morning.

Sorry this fell off my list, I will put it at the top of my post-git list if @imp doesn't get to it first.

In D25358#619091, @emaste wrote:

Sorry this fell off my list, I will put it at the top of my post-git list if @imp doesn't get to it first.

No worries, Christmas is a head and new years eve is on the horizon! I just don't like to work on new things, when the old things are still not finished.

--Gordon

@imp and @emaste ping? :)

Ping? That is somewhat getting something discourage further work for FreeBSD!

Doh! My brains have been fried for the last two months and this dropped on the floor. I'll take care of it tonight.

Has this change been committed yet?

In D25358#675151, @bcr wrote:

Has this change been committed yet?

Not to my knowledge.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 22 2021, 12:06 AM

Closed by commit rG15fccd86b9dd: Merge tag 'vendor/NetBSD/vis/20210621' into vis (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG15fccd86b9dd: Merge tag 'vendor/NetBSD/vis/20210621' into vis.

Please check to see if there's any conflicts between this and what I committed.
I just did a fresh vendor import since just apply the patch wasn't enough and phab sucks and reviewing vendor merges.