Link efi programs with -pie rather than -shared
ClosedPublic
Actions

Authored by arichardson on May 9 2020, 5:55 PM.

Details

Reviewers

emaste
andrew
jhb
brooks

Commits

rGaa2cddc0d21d: Link efi programs with -pie rather than -shared
rS366644: Link efi programs with -pie rather than -shared

Summary

This was causing build failures in CheriBSD where we were passing -pie
already by default.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31007
Build 28713: arc lint + arc unit

Event Timeline

arichardson created this revision.May 9 2020, 5:55 PM

Herald added a subscriber: bcran. · View Herald TranscriptMay 9 2020, 5:55 PM

arichardson requested review of this revision.May 9 2020, 5:55 PM

Harbormaster completed remote builds in B31007: Diff 71596.May 9 2020, 5:55 PM

Looks like this breaks aarch64, I got a "Synchronous exception" after the loader detects filesystems. Rebuilding after reverting the change fixed it.

In D24787#550414, @greg_unrelenting.technology wrote:

Looks like this breaks aarch64, I got a "Synchronous exception" after the loader detects filesystems. Rebuilding after reverting the change fixed it.

Does this fix it? https://github.com/CTSRD-CHERI/cheribsd/commit/ef7b5749427620d6ee1c9834ea6a264f816e99ea

In D24787#560671, @andrew wrote:

In D24787#550414, @greg_unrelenting.technology wrote:

Looks like this breaks aarch64, I got a "Synchronous exception" after the loader detects filesystems. Rebuilding after reverting the change fixed it.

Does this fix it? https://github.com/CTSRD-CHERI/cheribsd/commit/ef7b5749427620d6ee1c9834ea6a264f816e99ea