Page MenuHomeFreeBSD
Differential D23710

Fix panics when using iflib pseudo device support
ClosedPublic
Actions

Authored by mmacy on Feb 16 2020, 2:02 AM.
Tags
None
Referenced Files
F166514335: D23710.diff
Thu, Aug 13, 9:55 PM
F166494734: D23710.id72478.diff
Thu, Aug 13, 8:29 PM
F166486085: D23710.id68389.diff
Thu, Aug 13, 7:55 PM
F166461415: D23710.id68429.diff
Thu, Aug 13, 5:22 PM
Unknown Object (File)
Wed, Aug 12, 4:44 PM
Unknown Object (File)
Wed, Aug 12, 3:04 PM
Unknown Object (File)
Wed, Aug 12, 1:07 PM
Unknown Object (File)
Sat, Aug 8, 9:49 PM
View All Files
Subscribers
ae
afedorov
gallatin
imp
melifaro

Details

Reviewers
• hselasky
jhb
shurd
gallatin
Group Reviewers
iflib
Commits
rS363592: Fix panics when using iflib pseudo device support
rS361665: Fix panics when using iflib pseudo device support
Summary
  • _iflib_assert checks for values that are only relevant when doing queue management
  • iflib_pseudo_register can return without dropping the context sx lock
Test Plan

ifconfig wg create with the fixes

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 29412

Event Timeline

mmacy created this revision.Feb 16 2020, 2:02 AM
Herald added a reviewer: shurd. · View Herald TranscriptFeb 16 2020, 2:02 AM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added subscribers: melifaro, ae, imp. · View Herald Transcript
Harbormaster completed remote builds in B29412: Diff 68389.Feb 16 2020, 2:02 AM
• hselasky added a comment.Feb 16 2020, 6:01 AM

Can you upload patch context?

mmacy updated this revision to Diff 68429.Feb 16 2020, 10:41 PM
• hselasky accepted this revision.Feb 16 2020, 10:57 PM
gallatin accepted this revision.Feb 18 2020, 2:31 PM
gallatin added a subscriber: gallatin.

I'd prefer the check be moved inside _iflib_assert(), but that's just a nit.

This revision is now accepted and ready to land.Feb 18 2020, 2:31 PM
afedorov added a subscriber: afedorov.Mar 31 2020, 1:31 PM

Are there any objections to not committing this?

• hselasky added a comment.Mar 31 2020, 1:36 PM

No objections. Maybe split the commit into two when upstreaming and write a good commit message and don't forget to MFC.

• hselasky added a comment.Mar 31 2020, 2:39 PM

@mmacy: Ping.

mmacy added a comment.May 27 2020, 12:01 AM

I have further changes.

Closed by commit rS361665: Fix panics when using iflib pseudo device support (authored by mmacy). · Explain WhyMay 31 2020, 6:42 PM
This revision was automatically updated to reflect the committed changes.
mmacy added a commit: rS361665: Fix panics when using iflib pseudo device support.
mmacy added a commit: rS363592: Fix panics when using iflib pseudo device support.Jul 27 2020, 1:38 AM

Revision Contents
Changeset List

PathSize
sys/
net/
4 lines

Diff 68389

View Options

sys/net/iflib.c

Loading...