Page MenuHomeFreeBSD

Fix panics when using iflib pseudo device support
ClosedPublic

Authored by mmacy on Feb 16 2020, 2:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 3:50 AM
Unknown Object (File)
Mon, Mar 11, 3:50 AM
Unknown Object (File)
Mon, Mar 11, 3:50 AM
Unknown Object (File)
Mon, Mar 11, 3:46 AM
Unknown Object (File)
Mon, Mar 11, 3:38 AM
Unknown Object (File)
Dec 22 2023, 11:20 PM
Unknown Object (File)
Dec 20 2023, 5:52 AM
Unknown Object (File)
Dec 12 2023, 12:36 AM

Details

Summary
  • _iflib_assert checks for values that are only relevant when doing queue management
  • iflib_pseudo_register can return without dropping the context sx lock
Test Plan

ifconfig wg create with the fixes

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gallatin added a subscriber: gallatin.

I'd prefer the check be moved inside _iflib_assert(), but that's just a nit.

This revision is now accepted and ready to land.Feb 18 2020, 2:31 PM

Are there any objections to not committing this?

No objections. Maybe split the commit into two when upstreaming and write a good commit message and don't forget to MFC.

This revision was automatically updated to reflect the committed changes.