Paths

Table of Contentst

-
sys/net/
-
net/
-
iflib.c

Fix panics when using iflib pseudo device support
ClosedPublic
Actions

Authored by mmacy on Feb 16 2020, 2:02 AM.

Details

Reviewers

• hselasky
jhb
shurd
gallatin

Group Reviewers

iflib

Commits

rS363592: Fix panics when using iflib pseudo device support
rS361665: Fix panics when using iflib pseudo device support

Summary

_iflib_assert checks for values that are only relevant when doing queue management
iflib_pseudo_register can return without dropping the context sx lock

Test Plan

ifconfig wg create with the fixes

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 29412

Event Timeline

mmacy created this revision.Feb 16 2020, 2:02 AM

Herald added a reviewer: shurd. · View Herald TranscriptFeb 16 2020, 2:02 AM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

Harbormaster completed remote builds in B29412: Diff 68389.Feb 16 2020, 2:02 AM

Can you upload patch context?

mmacy updated this revision to Diff 68429.Feb 16 2020, 10:41 PM

• hselasky accepted this revision.Feb 16 2020, 10:57 PM

I'd prefer the check be moved inside _iflib_assert(), but that's just a nit.

This revision is now accepted and ready to land.Feb 18 2020, 2:31 PM

Are there any objections to not committing this?

No objections. Maybe split the commit into two when upstreaming and write a good commit message and don't forget to MFC.

@mmacy: Ping.

I have further changes.

Closed by commit rS361665: Fix panics when using iflib pseudo device support (authored by mmacy). · Explain WhyMay 31 2020, 6:42 PM

This revision was automatically updated to reflect the committed changes.

mmacy added a commit: rS361665: Fix panics when using iflib pseudo device support.

mmacy added a commit: rS363592: Fix panics when using iflib pseudo device support.Jul 27 2020, 1:38 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

iflib.c

4 lines

Diff 68389

View Options

sys/net/iflib.c

Context not available.
	if_setgetcounterfn(ctx->ifc_ifp, iflib_if_get_counter);	if_setgetcounterfn(ctx->ifc_ifp, iflib_if_get_counter);
	iflib_add_device_sysctl_post(ctx);	iflib_add_device_sysctl_post(ctx);
	ctx->ifc_flags \|= IFC_INIT_DONE;	ctx->ifc_flags \|= IFC_INIT_DONE;
		CTX_UNLOCK(ctx);
	return (0);	return (0);
	}	}
	_iflib_pre_assert(scctx);	_iflib_pre_assert(scctx);
Context not available.
	device_t dev = ctx->ifc_dev;	device_t dev = ctx->ifc_dev;
	if_t ifp;	if_t ifp;

	_iflib_assert(sctx);	if ((sctx->isc_flags & IFLIB_PSEUDO) == 0)
		_iflib_assert(sctx);

	CTX_LOCK_INIT(ctx);	CTX_LOCK_INIT(ctx);
	STATE_LOCK_INIT(ctx, device_get_nameunit(ctx->ifc_dev));	STATE_LOCK_INIT(ctx, device_get_nameunit(ctx->ifc_dev));
Context not available.

Fix panics when using iflib pseudo device supportClosedPublicActions