Page MenuHomeFreeBSD
Differential D21974

Drop support for FreeBSD 11.2 in the Ports Tree
ClosedPublic
Actions

Authored by rene on Oct 10 2019, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 17, 8:15 PM
Unknown Object (File)
Mon, Nov 17, 12:54 AM
Unknown Object (File)
Sun, Nov 16, 11:04 PM
Unknown Object (File)
Sun, Nov 16, 11:04 PM
Unknown Object (File)
Sun, Nov 16, 9:15 PM
Unknown Object (File)
Sun, Nov 16, 5:59 PM
Unknown Object (File)
Sun, Nov 16, 5:59 PM
Unknown Object (File)
Sun, Nov 16, 5:59 PM
View All Files
Subscribers
andrew
antoine
emaste
jonathan
linimon
mat
zeising

Details

Reviewers
dbn
jbeich
dch
antoine
zeising
Group Reviewers
x11
portmgr
Commits
rP516983: Clean up support for FreeBSD 11.2.
rP516839: MFH: r516838
rP516838: bsd.port.mk: update minimal supported version of FreeBSD to 11.3
Summary

FreeBSD 11.2 will reach end-of-life in November 2019, so remove specific support for it in the Ports Tree.

Of notable interest:

  • graphics/drm-fbsd-11.2-kmod got renamed to graphics/drm-fbsd-11.3-kmod:
rene@e17:/usr/ports/graphics % svn status
M       Makefile
A  +    drm-fbsd-11.3-kmod
        > moved from drm-fbsd11.2-kmod
M  +    drm-fbsd-11.3-kmod/Makefile
M  +    drm-fbsd-11.3-kmod/pkg-descr
M  +    drm-fbsd-11.3-kmod/pkg-message
D       drm-fbsd11.2-kmod
        > moved to drm-fbsd-11.3-kmod
M       drm-kmod/Makefile
  • the changes to lang/gnats-*-aarch64 are mostly theoretical, the expired port might as well be removed
  • patches of some ports got updated and carry some additional baggage from `make makepatch'
Test Plan

Test ports that got changed significantly in this patch.

Merge to 2019Q4 once landed because FreeBSD 11.2 will also expire there.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rene created this revision.Oct 10 2019, 8:19 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptOct 10 2019, 8:19 PM
Herald added subscribers: jonathan, mat, emaste, andrew. · View Herald Transcript
rene added a comment.Oct 10 2019, 9:41 PM

I unintentionally added an extra hyphen to 'drm-fbsd11.3-kmod', this has been fixed locally. Currently build-testing on a poudriere 11.3-i386 jail.

linimon added a subscriber: linimon.Oct 11 2019, 4:36 AM
linimon added inline comments.Oct 11 2019, 4:47 AM
MOVED
13080 ↗(On Diff #63134)

You've probably already fixed this, but in case not, this entry still has the extra hyphen.

lang/gnatcross-aarch64/Makefile
11 ↗(On Diff #63134)

I think rather than removing this stanza we ought to merely remove the port. The expiration is only a few days away in any case.

Also above you refer to these ports as "gnats-*" and yes I remember gnats well but these are actually "gnatcross-*" :-)

net/mpd5/files/patch-src-Makefile
24

Is this deletinon intentional?

antoine requested changes to this revision.Oct 11 2019, 9:57 PM
antoine added a subscriber: antoine.
  • Please wait 3 or 4 days after actual EoL before removing 11.2 support (some builds will still be in flight)
  • Having 11.2 hardcoded in portname and package name was a bad idea ; renaming it to 11.3 is an even worse idea, especially in a quarterly branch that is supposed to be stable (pkg upgrade will not work)
This revision now requires changes to proceed.Oct 11 2019, 9:57 PM
rene marked 2 inline comments as done.Oct 12 2019, 8:46 AM
rene added inline comments.
lang/gnatcross-aarch64/Makefile
11 ↗(On Diff #63134)

Hmm yes, I'll see if the new version builds.

net/mpd5/files/patch-src-Makefile
24

It is a deletion from the patch, not the final file.

rene marked an inline comment as done.Oct 12 2019, 8:51 AM
In D21974#480339, @antoine wrote:
  • Please wait 3 or 4 days after actual EoL before removing 11.2 support (some builds will still be in flight)

Ok.

  • Having 11.2 hardcoded in portname and package name was a bad idea ; renaming it to 11.3 is an even worse idea, especially in a quarterly branch that is supposed to be stable (pkg upgrade will not work)

Fair point, how about droppinb the minor version numbernfrom the port completely? This would still need a pkg set -o but avoids possible confusion for which FreeBSD version this port is intended (11.2 only vs 11.2+).

rene mentioned this in rP514446: lang/gnatcross-*aarch64: bump base version of FreeBSD from 11.0 to 11.3.Oct 14 2019, 9:52 AM
rene updated this revision to Diff 63250.Oct 14 2019, 12:45 PM
  • Remove now committed lang-gnatcross-*aarch64 changes
  • Do not rename graphics/drm-fbsd11.2-kmod per request of @antoine
zeising added a subscriber: zeising.Oct 14 2019, 8:15 PM
In D21974#480339, @antoine wrote:
  • Please wait 3 or 4 days after actual EoL before removing 11.2 support (some builds will still be in flight)
  • Having 11.2 hardcoded in portname and package name was a bad idea ; renaming it to 11.3 is an even worse idea, especially in a quarterly branch that is supposed to be stable (pkg upgrade will not work)

@antoine : Do you have any suggestions for naming schemes for future updates?

dns/knot-resolver/Makefile
106

While you're here, this should probably be "broken on i386".

graphics/drm-kmod/Makefile
25–30

Since you're not renaming the drm kmod port, this needs to be reverted as well.

rene updated this revision to Diff 63291.Oct 15 2019, 3:05 PM
  • tidy up
  • rebase
rene marked 2 inline comments as done.Oct 15 2019, 3:06 PM
zeising accepted this revision.Oct 16 2019, 8:21 AM
jbeich added a comment.Oct 30 2019, 10:12 PM

multimedia/libva bit looks OK. I haven't reviewed the rest and run out of time trying to identify what else can be removed (but at least managed some cleanup like rP514391).

rene updated this revision to Diff 63878.Nov 2 2019, 10:29 AM

Rebase on r516291

mat added inline comments.Nov 4 2019, 1:43 PM
Mk/bsd.port.mk
181–183

Let's get more in the future and put "13" here ? ^^

dns/knot-resolver/Makefile
106

Which would end up having:

"does not run on i386 while you are running i386 (reason: libknot (installed by knot2) is broken on i386)"

But maybe the intent is making sure people know it is i386's fault.

dns/knot2/Makefile
18 ↗(On Diff #63878)

Not sure this is needed.

graphics/drm-fbsd11.2-kmod/Makefile
35–37

So, mmm.

.if ${OPSYS} == FreeBSD && ${OSVERSION} > 1200000

should be enough.

graphics/drm-fbsd11.2-kmod/pkg-descr
3

The port directory says 11.2.

net/zerotier/Makefile
35

This is always true, it only supports early version of 12-CURRENT from 2016.

mat added a comment.Nov 4 2019, 1:44 PM

IMHO, the only thing that should be merged to 2019Q4 is line 1165 of bsd.port.mk.

rene added a comment.Nov 4 2019, 1:55 PM
In D21974#485928, @mat wrote:

IMHO, the only thing that should be merged to 2019Q4 is line 1165 of bsd.port.mk.

OK. That might be easier if that line is committed first in its own commit.

mat added a comment.Nov 4 2019, 2:34 PM
In D21974#485929, @rene wrote:
In D21974#485928, @mat wrote:

IMHO, the only thing that should be merged to 2019Q4 is line 1165 of bsd.port.mk.

OK. That might be easier if that line is committed first in its own commit.

Yeah, good thing we're portmgr and we can do whatever we want :-p

This revision was not accepted when it landed; it landed in state Needs Review.Nov 5 2019, 9:08 PM
Closed by commit rP516838: bsd.port.mk: update minimal supported version of FreeBSD to 11.3 (authored by rene). · Explain Why
This revision was automatically updated to reflect the committed changes.
rene added a commit: rP516838: bsd.port.mk: update minimal supported version of FreeBSD to 11.3.
rene added a commit: rP516839: MFH: r516838.
rene marked 2 inline comments as done.Nov 5 2019, 9:40 PM
rene added inline comments.
graphics/drm-fbsd11.2-kmod/pkg-descr
3

I suggested to change the directory name to 11.3 but that met opposition. Ideally I would rename it to just "drm-fbsd11-kmod"

net/zerotier/Makefile
35

Hmm yes, by now that condition is indeed always true. Do we technically still support those versions? On the other hand, that condition can be removed once 12.0 goes EOL.

rene reopened this revision.Nov 5 2019, 9:40 PM
rene mentioned this in rP516864: dns/knot2 does not build on any supported i386 version..Nov 6 2019, 8:45 AM
rene mentioned this in rP516866: dns/knot-resolver: IGNORE on i386 because dns/knot2 is broken there.Nov 6 2019, 9:10 AM
rene marked 2 inline comments as done.Nov 6 2019, 9:12 AM
rene added inline comments.
dns/knot-resolver/Makefile
106

Heh, but indeed this port is useless without dns/knot2 so also not_for_i386

rene updated this revision to Diff 64003.Nov 6 2019, 3:33 PM
rene marked an inline comment as done.

Rebase on r516892

rene updated this revision to Diff 64004.Nov 6 2019, 3:37 PM

Leave out local modification.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 7 2019, 4:30 PM
Closed by commit rP516983: Clean up support for FreeBSD 11.2. (authored by rene). · Explain Why
This revision was automatically updated to reflect the committed changes.
rene added a commit: rP516983: Clean up support for FreeBSD 11.2..

Revision Contents
Changeset List

PathSize
Mk/
2 lines
6 lines
Tools/
scripts/
6 lines
audio/
supercollider/
2 lines
devel/
ElectricFence/
files/
10 lines
py-pycapsicum/
files/
14 lines
dns/
knot-resolver/
4 lines
emulators/
i386-wine-devel/
4 lines
i386-wine/
4 lines
rtc/
files/
4 lines
graphics/
drm-fbsd11.2-kmod/
2 lines
2 lines
drm-kmod/
6 lines
japanese/
man/
files/
15 lines
multimedia/
libva/
1 line
net-mgmt/
kapacitor/
3 lines
net/
mpd5/
files/
33 lines
zerotier/
2 lines
security/
ipsec-tools/
4 lines

Diff 63250

View Options

Mk/bsd.options.mk

Loading...
View Options

Mk/bsd.port.mk

Loading...
View Options

Tools/scripts/mfh

Loading...
View Options

audio/supercollider/Makefile

Loading...
View Options

devel/ElectricFence/files/patch-Makefile

Loading...
View Options

devel/py-pycapsicum/files/patch-__pycapsicum.c

Loading...
View Options

dns/knot-resolver/Makefile

Loading...
View Options

emulators/i386-wine-devel/Makefile.inc

Loading...
View Options

emulators/i386-wine/Makefile.inc

Loading...
View Options

emulators/rtc/files/Makefile

Loading...
View Options

graphics/drm-fbsd11.2-kmod/Makefile

Loading...
View Options

graphics/drm-fbsd11.2-kmod/pkg-descr

Loading...
View Options

graphics/drm-kmod/Makefile

Loading...
View Options

japanese/man/files/patch-man__Makefile

Loading...
View Options

multimedia/libva/Makefile

Loading...
View Options

net-mgmt/kapacitor/Makefile

Loading...
View Options

net/mpd5/files/patch-src-Makefile

Loading...
View Options

net/zerotier/Makefile

Loading...
View Options

security/ipsec-tools/Makefile

Loading...