Page MenuHomeFreeBSD

linux: add trivial renameat2 implementation
ClosedPublic

Authored by emaste on Sep 10 2019, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 2:23 PM
Unknown Object (File)
Jan 16 2024, 8:09 PM
Unknown Object (File)
Jan 14 2024, 11:08 AM
Unknown Object (File)
Dec 28 2023, 1:40 PM
Unknown Object (File)
Dec 22 2023, 10:01 PM
Unknown Object (File)
Nov 30 2023, 8:38 PM
Unknown Object (File)
Nov 24 2023, 1:53 AM
Unknown Object (File)
Nov 5 2023, 3:17 PM
Subscribers

Details

Summary

Just return EINVAL if flags != 0. The Linux man page documents one case of EINVAL as "The filesystem does not support one of the flags in flags."

After rS351723 userland binaries will try using new system calls.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg added inline comments.
sys/compat/linux/linux_file.c
732

I would add a rate check here to prevent spamming. You can find sample code in falloc_noinstall. It's literally few lines, but it's not a hard requirement.

This revision is now accepted and ready to land.Sep 10 2019, 5:56 PM

make linux_renameat pass through to linux_renameat2

This revision now requires review to proceed.Sep 10 2019, 6:39 PM

use c99 initializers suggested by mjg

mjg added inline comments.
sys/compat/linux/linux_file.c
694

}; should be on a new line

This revision is now accepted and ready to land.Sep 10 2019, 7:05 PM
This revision was automatically updated to reflect the committed changes.