Page MenuHomeFreeBSD
Differential D21547

ix, ixv: Read msix_bar from device configuration
ClosedPublic
Actions

Authored by piotr.pietruszewski_intel.com on Sep 6 2019, 12:40 PM.
Tags
None
Referenced Files
F139877894: D21547.diff
Wed, Dec 17, 12:13 PM
Unknown Object (File)
Mon, Dec 15, 1:05 AM
Unknown Object (File)
Sun, Dec 7, 11:40 PM
Unknown Object (File)
Thu, Dec 4, 10:17 PM
Unknown Object (File)
Sun, Nov 30, 9:24 AM
Unknown Object (File)
Sat, Nov 29, 4:18 PM
Unknown Object (File)
Fri, Nov 28, 1:44 PM
Unknown Object (File)
Thu, Nov 27, 1:28 AM
View All Files
Subscribers
ae
erj
imp
jacob.e.keller_intel.com

Details

Reviewers
marius
shurd
jhb
erj
Group Reviewers
Intel Networking
Commits
rS352656: ix, ixv: Read msix_bar from device configuration
Summary

Instead of predicting MSI-X bar basing on mac type, read it from device
configuration.

This patch resolves PR 239704.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26306
Build 24785: arc lint + arc unit

Event Timeline

piotr.pietruszewski_intel.com created this revision.Sep 6 2019, 12:40 PM
Herald added a subscriber: ae. · View Herald TranscriptSep 6 2019, 12:40 PM
Harbormaster completed remote builds in B26306: Diff 61724.Sep 6 2019, 12:40 PM
piotr.pietruszewski_intel.com added a reviewer: Intel Networking.Sep 6 2019, 12:53 PM
kgalazka added reviewers: marius, shurd.Sep 6 2019, 4:34 PM
erj added a reviewer: jhb.Sep 9 2019, 5:30 PM
erj added a subscriber: erj.

Is there a reason that we wouldn't do this for all of our drivers, instead of hardcoding the BAR index?

jacob.e.keller_intel.com added a subscriber: jacob.e.keller_intel.com.Sep 9 2019, 6:01 PM

I agree with Eric, we should depend on the device to be configured properly, and push to get the images for the device updated if they're wrong.

jhb added a comment.Sep 13 2019, 5:03 AM

If the BAR varies across devices, I think using pci_msix_table_bar is probably the simplest thing to do.

erj accepted this revision.Sep 17 2019, 4:38 PM
This revision is now accepted and ready to land.Sep 17 2019, 4:38 PM
Closed by commit rS352656: ix, ixv: Read msix_bar from device configuration (authored by erj). · Explain WhySep 24 2019, 5:06 PM
This revision was automatically updated to reflect the committed changes.
erj added a commit: rS352656: ix, ixv: Read msix_bar from device configuration.
Herald added a subscriber: imp. · View Herald TranscriptSep 24 2019, 5:06 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
5 lines
2 lines
2 lines

Diff 61724

View Options

sys/dev/ixgbe/if_ix.c

Loading...
View Options

sys/dev/ixgbe/if_ixv.c

Loading...
View Options

sys/dev/ixgbe/ixgbe.h

Loading...