net: Update SFF-8024 definitions and strings with values from rev 4.6
ClosedPublic
Actions

Authored by erj on Jul 23 2019, 8:45 PM.

Details

Reviewers

• hselasky
melifaro
jhb
np
slavash
gallatin

Commits

rS351153: net: Update SFF-8024 definitions and strings with values from rev 4.6

Summary

This will let ifconfig -v's SFF eeprom read functionality recognize more
module types.

Signed-off-by: Eric Joyner <erj@freebsd.org>

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25473
Build 24092: arc lint + arc unit

Event Timeline

erj created this revision.Jul 23 2019, 8:45 PM

Herald added a subscriber: ae. · View Herald TranscriptJul 23 2019, 8:45 PM

Harbormaster completed remote builds in B25473: Diff 60060.Jul 23 2019, 8:45 PM

erj added reviewers: • hselasky, melifaro, jhb, np.Jul 24 2019, 4:23 PM

erj set the repository for this revision to rS FreeBSD src repository - subversion.

erj added a project: network.

Herald added a subscriber: imp. · View Herald TranscriptJul 24 2019, 4:23 PM

• hselasky added reviewers: slavash, gallatin.Jul 24 2019, 4:28 PM

erj added inline comments.Jul 24 2019, 4:29 PM

sys/net/sff8472.h
435	Are these strings not allowed to have spaces? It would be useful for this entry (at least) to say "QSFP+ or later" instead -- we do have QSFP28 cables that have an 0xD ID instead of 0x11.

gallatin accepted this revision.Jul 24 2019, 8:51 PM

This revision is now accepted and ready to land.Jul 24 2019, 8:51 PM

Closed by commit rS351153: net: Update SFF-8024 definitions and strings with values from rev 4.6 (authored by erj). · Explain WhyAug 17 2019, 12:11 AM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rS351153: net: Update SFF-8024 definitions and strings with values from rev 4.6.

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

sfp.c

69 lines

sys/

net/

sff8472.h

77 lines

Diff 60060

View Options

sbin/ifconfig/sfp.c