Page MenuHomeFreeBSD
Differential D21018

tests/sys/opencrypto: enable armv8crypto
ClosedPublic
Actions

Authored by val_packett.cool on Jul 21 2019, 7:28 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, May 2, 8:11 PM
Unknown Object (File)
Thu, May 2, 8:11 PM
Unknown Object (File)
Thu, May 2, 8:11 PM
Unknown Object (File)
Thu, May 2, 8:10 PM
Unknown Object (File)
Thu, May 2, 8:10 PM
Unknown Object (File)
Thu, May 2, 4:11 PM
Unknown Object (File)
Fri, Apr 26, 6:31 PM
Unknown Object (File)
Fri, Apr 26, 3:24 AM
View All 68 Files
Subscribers
emaste
imp
lwhsu

Details

Reviewers
ngie
jmg
jhb
Group Reviewers
Contributor Reviews (src)
Commits
rS350837: tests/sys/opencrypto: enable armv8crypto on aarch64
Summary

The tests were useful for adding XTS (D21017) and will no doubt be useful for adding more of the things :)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

val_packett.cool created this revision.Jul 21 2019, 7:28 PM
Herald added a reviewer: jmg. · View Herald TranscriptJul 21 2019, 7:28 PM
Herald added a subscriber: imp. · View Herald Transcript
val_packett.cool added a parent revision: D21012: armv8crypto: add missing unlock for session (fix "sleeping thread owns a non-sleepable lock").Jul 21 2019, 7:28 PM
val_packett.cool mentioned this in D21017: armv8crypto: add AES-XTS support.
lwhsu added a reviewer: jhb.Jul 22 2019, 2:11 PM
lwhsu added a subscriber: lwhsu.
ngie added a comment.Jul 22 2019, 4:15 PM

Could you please test this change out on amd64?

Thank you for the submission :)!

tests/sys/opencrypto/runtests.sh
67

Please use a switch statement here, e.g.,

case “${cpu_type}” in
aarch64)
    cpu_module=...
    ;;
amd64|i386)
    cpu_module=...
    ;;
esac

The above change would break some testing on i386.

PS please pardon my editing. I’m submitting the comment via my iPhone).

val_packett.cool updated this revision to Diff 60027.Jul 22 2019, 7:10 PM
val_packett.cool updated this revision to Diff 60028.Jul 22 2019, 7:16 PM
val_packett.cool marked an inline comment as done.
In D21018#456270, @ngie wrote:

Could you please test this change out on amd64?

Yes, works fine of course.

tests/sys/opencrypto/runtests.sh
67

Of course Intel added AES-NI to the 32-bit mode, why did I assume that all new features were restricted to 64-bit.. Sorry :D

Updated the patch.

emaste added a subscriber: emaste.Aug 8 2019, 8:09 PM

@ngie will you commit this?

This revision was not accepted when it landed; it landed in state Needs Review.Aug 10 2019, 3:53 PM
Closed by commit rS350837: tests/sys/opencrypto: enable armv8crypto on aarch64 (authored by ngie). · Explain Why
This revision was automatically updated to reflect the committed changes.
ngie added a commit: rS350837: tests/sys/opencrypto: enable armv8crypto on aarch64.

Revision Contents
Changeset List

PathSize
tests/
sys/
opencrypto/
i/
tests/
sys/
opencrypto/
5 lines
11 lines

Diff 59995

View Options

tests/sys/opencrypto/cryptotest.py

Loading...
View Options

tests/sys/opencrypto/runtests.sh

Loading...