Enable NVMe on aarch64
ClosedPublic
Actions

Authored by val_packett.cool on Mar 20 2019, 11:01 AM.

Details

Reviewers

manu
imp

Group Reviewers

arm64
Contributor Reviews (src)

Commits

rS345408: Add nvme support to the arm64 GENERIC kernel.

Summary

Required for (and tested on) AWS EC2 a1 instances.

Let's use nda by default just like powerpc64 does,.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

val_packett.cool created this revision.Mar 20 2019, 11:01 AM

Herald added a reviewer: manu. · View Herald TranscriptMar 20 2019, 11:01 AM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

Aside from the whitespace issue, I'm ready to commit this unless any of the arm-y people object.

sys/arm64/conf/GENERIC
176	This should be "options<space><tab>..." . (see sys/conf/NOTES -- this is an old FreeBSD custom which results in tab alignment working even in patches)

val_packett.cool added inline comments.Mar 20 2019, 8:47 PM

sys/arm64/conf/GENERIC
176	oh. I copy-pasted from `powerpc/conf/GENERIC64` — the space wasn't there

+1 on cperciva's spacing nits.

This revision is now accepted and ready to land.Mar 20 2019, 9:57 PM

val_packett.cool updated this revision to Diff 55301.Mar 20 2019, 10:15 PM

This revision now requires review to proceed.Mar 20 2019, 10:15 PM

val_packett.cool marked an inline comment as done.Mar 20 2019, 10:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 22 2019, 6:36 AM

Closed by commit rS345408: Add nvme support to the arm64 GENERIC kernel. (authored by cperciva). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

conf/

GENERIC

5 lines

Diff 55301

View Options

Enable NVMe on aarch64ClosedPublicActions