Details

stand/i386/libi386/pxe.c
3	Ed suggests that I don't add ARR to both lines here but just move my statement below the existing one which will mostly look the same as a diff except this line wouldn't be present.
sys/dev/rc/rc.c
5	Similarly for this file and the next two.

emaste added inline comments.Mar 6 2019, 7:50 PM

stand/i386/libi386/pxe.c
3	I'd prefer we didn't add new All rights reserved statements; the current one is ambiguous, but I don't think we need to address that ambiguity in this change?

A few more stragglers.

This revision now requires review to proceed.Mar 6 2019, 7:52 PM

Harbormaster completed remote builds in B22921: Diff 54782.Mar 6 2019, 7:52 PM

I'll review if you ack your are done updating John

stand/i386/libi386/pxe.c
3	I am mixed on that, but shall defer to you and John, and since he already updated it just agree that we should address this in a seperate review/commit, preferably with associated copyright holders present. Waiting for the new diff, which I thought I saw uploaded but still see a few added All Rights Reserved around the PXE stuff

Don't add new ARR lines, just move my line below existing ones.

Harbormaster completed remote builds in B22923: Diff 54786.Mar 6 2019, 9:13 PM

rgrimes added inline comments.Mar 6 2019, 9:28 PM

sys/x86/x86/mptable.c
5	Added white space

jhb marked an inline comment as done.Mar 6 2019, 9:44 PM

Whitespace.

Harbormaster completed remote builds in B22924: Diff 54787.Mar 6 2019, 9:45 PM

rgrimes accepted this revision.Mar 6 2019, 9:58 PM

This revision is now accepted and ready to land.Mar 6 2019, 9:58 PM

This revision was automatically updated to reflect the committed changes.

dim added a commit: rS367457: MFC r344855 (by jhb):.Nov 23 2020, 12:43 AM

Herald added a subscriber: bcran. · View Herald TranscriptNov 23 2020, 12:43 AM

Drop "All rights reserved" from my copyright statements.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 54786

contrib/elftoolchain/libelf/gelf_mips64el.c

lib/libc/tests/gen/makecontext_test.c

lib/libdevctl/devctl.h

lib/libdevctl/devctl.3

lib/libdevctl/devctl.c

lib/libkvm/kvm_aarch64.h

lib/libkvm/kvm_amd64.h

lib/libkvm/kvm_arm.h

lib/libkvm/kvm_i386.h

lib/libkvm/kvm_mips.h

lib/libkvm/kvm_native.3

lib/libkvm/kvm_riscv.h

lib/libkvm/kvm_sparc64.h

lib/libsysdecode/errno.c

lib/libsysdecode/signal.c

lib/libsysdecode/syscallnames.c

lib/libsysdecode/sysdecode.h

lib/libsysdecode/sysdecode.3

lib/libsysdecode/sysdecode_abi_to_freebsd_errno.3

lib/libsysdecode/sysdecode_cap_rights.3

lib/libsysdecode/sysdecode_enum.3

lib/libsysdecode/sysdecode_fcntl_arg.3

lib/libsysdecode/sysdecode_ioctlname.3

lib/libsysdecode/sysdecode_kevent.3

lib/libsysdecode/sysdecode_mask.3

lib/libsysdecode/sysdecode_quotactl_cmd.3

lib/libsysdecode/sysdecode_sigcode.3

lib/libsysdecode/sysdecode_socket_protocol.3

lib/libsysdecode/sysdecode_sockopt_name.3

lib/libsysdecode/sysdecode_syscallnames.3

lib/libsysdecode/sysdecode_utrace.3

lib/libutil/kinfo_getvmobject.3

sbin/hastd/refcnt.h

share/man/man3/sigevent.3

share/man/man4/ktr.4

share/man/man4/witness.4

share/man/man9/BUS_GET_CPUS.9

share/man/man9/BUS_RESCAN.9

share/man/man9/atomic.9

share/man/man9/bus_map_resource.9

share/man/man9/critical_enter.9

share/man/man9/ithread.9

share/man/man9/ktr.9

share/man/man9/runqueue.9

share/man/man9/scheduler.9

share/man/man9/sleepqueue.9

share/man/man9/swi.9

stand/efi/libefi/devpath.c

stand/i386/cdboot/cdboot.S

stand/i386/libi386/pxe.h

stand/i386/libi386/pxe.c

stand/i386/pxeldr/pxeldr.S

sys/amd64/include/intr_machdep.h

sys/arm/arm/ptrace_machdep.c

sys/dev/acpica/acpi_isab.c

sys/dev/acpica/acpi_pcivar.h

sys/dev/pci/vga_pci.c

sys/dev/rc/rc.c

sys/dev/rc/rcreg.h

sys/i386/pci/pci_pir.c

sys/kern/kern_ktr.c

sys/kern/kern_rwlock.c

sys/kern/subr_lock.c

sys/kern/subr_sleepqueue.c

sys/kern/subr_smp.c

sys/sys/_rwlock.h

sys/sys/refcount.h

sys/sys/rwlock.h

sys/sys/sleepqueue.h

sys/sys/turnstile.h

sys/x86/acpica/madt.c

sys/x86/include/apicvar.h

sys/x86/include/intr_machdep.h

sys/x86/isa/atpic.c

Drop "All rights reserved" from my copyright statements.
ClosedPublic
Actions

Revision Contents
Changeset List