Differential D17879

First part of D17787:
ClosedPublic
Actions

Authored by glebius on Nov 6 2018, 11:17 PM.

Tags

None

Referenced Files

	F135621788: D17879.id50375.diff
	Tue, Nov 11, 9:13 AM

	Unknown Object (File)
	Fri, Oct 24, 1:53 AM

	Unknown Object (File)
	Fri, Oct 24, 1:53 AM

	Unknown Object (File)
	Fri, Oct 24, 1:53 AM

	Unknown Object (File)
	Thu, Oct 23, 5:21 PM

	Unknown Object (File)
	Wed, Oct 15, 2:35 AM

	Unknown Object (File)
	Oct 12 2025, 2:37 AM

	Unknown Object (File)
	Sep 29 2025, 4:20 PM

View All 80 Files

Subscribers

Details

Reviewers

mmacy
kib
gallatin
jtl
bz
markj

Commits

rS349763: MFC r340404, r340415, r340417, r340419 and r340420:
rS340404: Uninline epoch(9) entrance and exit. There is no proof that modern

Summary

Uninline epoch(9) entrance and exit. There is no proof that modern processors would benefit from avoiding a call, but bloating code. In fact, clang created an uninlined real function for many object files in the network stack.
Remove private copies of critical_enter/exit.
Move epoch_private.h into subr_epoch.c.

There is no functional change.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20671
Build 20086: arc lint + arc unit

Event Timeline

glebius created this revision.Nov 6 2018, 11:17 PM

Harbormaster completed remote builds in B20671: Diff 50095.Nov 6 2018, 11:17 PM

kib added inline comments.Nov 7 2018, 3:35 AM

sys/kern/subr_epoch.c
245	IMO thi sis an obfuscation.
256	Why using thread_lite and sched_pin_lite in a .c file, esp. when proc.h is already included ?
321	Wrong indent.

glebius marked 3 inline comments as done.Nov 7 2018, 9:23 PM

glebius added inline comments.

sys/kern/subr_epoch.c
245	I totally agree. But this is exact what was taken from epoch_private.h. Per mmacy@'s request I'm splitting the bigger change in small once. This just uninlines stuff.
256	Same answer. To be addressed in next commits.
321	Agreed. Taken from another file as is. To be cleaned up later.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 13 2018, 7:02 PM

Closed by commit rS340404: Uninline epoch(9) entrance and exit. There is no proof that modern (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 13 2018, 7:02 PM

• hselasky added a commit: rS349763: MFC r340404, r340415, r340417, r340419 and r340420:.Jul 5 2019, 12:26 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

145 lines

sys/

53 lines

epoch_private.h

Diff 50095

sys/kern/subr_epoch.c

Loading...

sys/sys/epoch.h

Loading...

sys/sys/epoch_private.h

Loading...