ixlv(4): Update to use iflib; change name to iavf(4)
ClosedPublic
Actions

Authored by erj on Jul 24 2018, 6:37 PM.

Details

Reviewers

sbruno
shurd
kbowling
gallatin
jeffrey.e.pieper_intel.com

Group Reviewers

Intel Networking

Commits

rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9)

Summary

(Summary forthcoming)

A list of git commits that are contained in this revision can be found here: https://github.com/freebsd/freebsd/compare/master...intel-wired-ethernet:ixl-iflib-sriov

Also includes changes to the PF driver (ixl(4)).

Includes the contents of D16428 already.

Test Plan

(To be filled out)

At least run the VF driver with an ixl(4) host bare metal and using bhyve, and a Linux (RHEL?) host using KVM.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19990
Build 19496: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

ixl(4): Fix module Makefile when PCI_IOV is enabled

Harbormaster completed remote builds in B18360: Diff 45891.Jul 26 2018, 9:08 PM

In general, I looked around at ixlv.c, and it looks like there are many functions for the main pf which are identical, or nearly identical for the VF. Can we please work on collapsing them down to common code?

sys/dev/ixl/ixl_pf_main.c
2365	I just hate that there are 2 functions which do almost the same thing. Can't you just change the args to ixl_disable_rings() to take pf and qtag and do this in a single function?
sys/dev/ixl/ixl_txrx.c
529	Errant space.

ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
Remove a space

Harbormaster completed remote builds in B18537: Diff 46214.Aug 2 2018, 8:47 PM

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it

Harbormaster completed remote builds in B18564: Diff 46257.Aug 3 2018, 6:33 PM

Changes from D16428:

iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

ixl(4): Add tunable to enable VF loopback; enable by default
ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing

Harbormaster completed remote builds in B18682: Diff 46482.Aug 9 2018, 6:40 PM

ixl(4): Fix compile error when PCI_IOV isn't defined

Harbormaster completed remote builds in B18688: Diff 46490.Aug 9 2018, 10:24 PM

gallatin accepted this revision.Aug 10 2018, 3:41 PM

This revision is now accepted and ready to land.Aug 10 2018, 3:41 PM

Several outstanding issues:

System back trace while running netperf tcp_rr test with jumbo frames enabled:

Fatal trap 12: page fault while in kernel mode
cpuid = 0; apic id = 00
fault virtual address = 0x1af0000
fault code = supervisor read data, page not present
instruction pointer = 0x20:0xffffffff80bdeb4f
stack pointer = 0x28:0xfffffe0025eeccb0
frame pointer = 0x28:0xfffffe0025eeccc0
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 12 (swi4: clock (0))
[ thread pid 12 tid 100034 ]
Stopped at m_tag_delete_chain+0x1f: movq (%rsi),%rdi
db> bt
Tracing pid 12 tid 100034 td 0xfffff800032c4580
m_tag_delete_chain() at m_tag_delete_chain+0x1f/frame 0xfffffe0025eeccc0
uma_zfree_arg() at uma_zfree_arg+0x3e/frame 0xfffffe0025eecd20
m_freem() at m_freem+0x9a/frame 0xfffffe0025eecd40
vtnet_txq_eof() at vtnet_txq_eof+0x75/frame 0xfffffe0025eecd70
vtnet_txq_mq_start_locked() at vtnet_txq_mq_start_locked+0x65/frame 0xfffffe0025eecdd0
vtnet_txq_mq_start() at vtnet_txq_mq_start+0x68/frame 0xfffffe0025eece10
ether_output_frame() at ether_output_frame+0xaa/frame 0xfffffe0025eece40
ether_output() at ether_output+0x6b7/frame 0xfffffe0025eecee0
ip_output() at ip_output+0x13e6/frame 0xfffffe0025eed020
tcp_output() at tcp_output+0x1b0c/frame 0xfffffe0025eed1b0
tcp_timer_delack() at tcp_timer_delack+0xf4/frame 0xfffffe0025eed1f0
softclock_call_cc() at softclock_call_cc+0x12e/frame 0xfffffe0025eed2a0
softclock() at softclock+0x79/frame 0xfffffe0025eed2c0
ithread_loop() at ithread_loop+0x1a7/frame 0xfffffe0025eed330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025eed370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025eed370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

Fatal trap 9: general protection fault while in kernel mode
cpuid = 1; apic id = 01
instruction pointer = 0x20:0xffffffff82d70048
stack pointer = 0x28:0xfffffe0025ec5150
frame pointer = 0x28:0xfffffe0025ec5180
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 0 (if_io_tqg_1)
[ thread pid 0 tid 100026 ]
Stopped at ixl_isc_rxd_pkt_get+0xc8: cmpl ll+0x1b(%rax),%esi
db> bt
Tracing pid 0 tid 100026 td 0xfffff800032ad580
ixl_isc_rxd_pkt_get() at ixl_isc_rxd_pkt_get+0xc8/frame 0xfffffe0025ec5180
iflib_rxeof() at iflib_rxeof+0x136/frame 0xfffffe0025ec5260
_task_fn_rx() at _task_fn_rx+0x76/frame 0xfffffe0025ec52a0
gtaskqueue_run_locked() at gtaskqueue_run_locked+0x144/frame 0xfffffe0025ec5300
gtaskqueue_thread_loop() at gtaskqueue_thread_loop+0x98/frame 0xfffffe0025ec5330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025ec5370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025ec5370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

It is possible to work around the issue by increasing the value of the rx_budget counter to the current value of the number of queues (44):
sysctl dev.ixl.0.iflib.rx_budget=44

Unable to initialize over 63 VF's:

Aug 10 14:48:56 u1017 kernel: ixl3: 0x400000 bytes of rid 0x184 res 3 failed (0, 0xffffffffffffffff).

Memory leak reported when unloading if_ixlv with 64 VF’s spawned:

Aug 10 14:51:18 u1017 kernel: ixlv62: Using MSIX interrupts with 5 vectors
Aug 10 14:51:18 u1017 kernel: ixlv62: Ethernet address: e2:db:49:42:7a:85
Aug 10 14:51:18 u1017 kernel: ixlv62: netmap queues/slots: TX 4/1024, RX 4/1024
Aug 10 14:51:18 u1017 kernel: ixlv63: <Intel(R) Ethernet Virtual Function 700 Series (X722)> at device 0.79 on pci13
Aug 10 14:51:18 u1017 kernel: ixlv62: link state changed to UP
Aug 10 14:51:18 u1017 kernel: ixlv63: PF API 1.1 / VF API 1.1
Aug 10 14:51:18 u1017 kernel: ixlv63: VSIs 1, QPs 4, MSIX 5, RSS sizes: key 52 lut 64
Aug 10 14:51:18 u1017 kernel: ixlv63: using 1024 tx descriptors and 1024 rx descriptors
Aug 10 14:51:18 u1017 kernel: ixlv63: msix_init qsets capped at 4
Aug 10 14:51:18 u1017 kernel: ixlv63: pxm cpus: 36 queue msgs: 4 admincnt: 1
Aug 10 14:51:18 u1017 kernel: ixlv63: using 4 rx queues 4 tx queues
Aug 10 14:51:18 u1017 kernel: ixlv63: Using MSIX interrupts with 4 vectors
Aug 10 14:51:18 u1017 kernel: ixlv63: failed to allocate IRQ for rid 5, name rxq3.
Aug 10 14:51:18 u1017 kernel: ixlv63: _iflib_irq_alloc failed 12
Aug 10 14:51:18 u1017 kernel: ixlv63: Failed to allocate queue RX int vector 3, err: 12
Aug 10 14:51:18 u1017 kernel: ixlv63: IFDI_MSIX_INTR_ASSIGN failed 12
Aug 10 14:51:18 u1017 kernel: device_attach: ixlv63 attach returned 12
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked MSI vectors
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked memory resources

After kldunload:

Aug 10 15:00:18 u1017 kernel: ixlv62: detached
Aug 10 15:00:18 u1017 kernel: pci13: <network, ethernet> at device 0.78 (no driver attached)
Aug 10 15:00:18 u1017 kernel: Warning: memory type ixlv leaked memory on destroy (4 allocations, 8192 bytes leaked).

This revision now requires changes to proceed.Aug 10 2018, 4:20 PM

ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic

Harbormaster completed remote builds in B18703: Diff 46521.Aug 10 2018, 5:37 PM

ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
ixlv(4): Fix a memory leak when interrupt setup fails
ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
ixlv(4): Remove comments and commented out code
ixlv(4): Remove list of media types displayed in "ifconfig -m"

Harbormaster completed remote builds in B18780: Diff 46642.Aug 14 2018, 12:03 AM

ixl(4): Enhance Malicious Driver Detection messages with VF information
ixl(4): Print out additional event information when a LAN Overflow Event occurs
ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path

Harbormaster completed remote builds in B18879: Diff 46809.Aug 16 2018, 11:45 PM

gallatin added inline comments.Aug 17 2018, 7:34 PM

sys/dev/ixl/if_ixl.c
1206	Please consider limiting this to a few prints. Otherwise, I anticipate this spamming the console / messages log at some point for somebody.
sys/dev/ixl/ixl_pf_main.c
2491	Nice! This would have been helpful during bringup of the iflib driver, but better late than never :)
sys/dev/ixl/ixl_txrx.c
384	0 is a perfectly valid DMA address on non-x86, or on x86 when using IOMMUs

ixl(4): Fix RX MDD event display
ixl/ixlv(4): Add more MPASS statements to TX path

Harbormaster completed remote builds in B18994: Diff 47009.Aug 21 2018, 12:42 AM

ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message

Harbormaster completed remote builds in B19027: Diff 47074.Aug 22 2018, 12:48 AM

ixl/ixlv(4): Fix TXD credits update for DWB mode

Harbormaster completed remote builds in B19111: Diff 47190.Aug 23 2018, 5:56 PM

ixl(4): Fix memory leak when head writeback is disabled

Harbormaster completed remote builds in B19117: Diff 47209.Aug 23 2018, 9:22 PM

ixl/ixlv Missing semicolon in DWB fix

Harbormaster completed remote builds in B19214: Diff 47347.Aug 27 2018, 3:43 PM

iflib: Destroy state lock at end of iflib_device_deregister()
iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
ixl(4): Fix kernel panic during init() when Admin Queue is not alive

Harbormaster completed remote builds in B19307: Diff 47509.Aug 31 2018, 12:01 AM

ixlv(4): Swap MALLOC_DEFINE/DECLARE statements
ixlv(4): Remove commented out code
ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses
ixlv(4): Update some debug printf()'s to use newer debug functions
ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists

Harbormaster completed remote builds in B19398: Diff 47671.Sep 4 2018, 11:33 PM

ixlv(4): Disable queues before initialization.

Harbormaster completed remote builds in B19573: Diff 48012.Sep 13 2018, 6:00 PM

ixl(4): Configure promiscuous mode during driver init

Harbormaster completed remote builds in B19583: Diff 48025.Sep 13 2018, 11:00 PM

ixl(4): Fix compile error introduced by previous commit

Harbormaster completed remote builds in B19585: Diff 48027.Sep 13 2018, 11:10 PM

ixl(4): Fix filter handling when SR-IOV is enabled
Revert "iflib: Free RX queue TCP LRO memory on unload"

Harbormaster completed remote builds in B19703: Diff 48274.Sep 20 2018, 5:40 PM

ixlv(4): Update driver version to 2.0.0-k
ixlv(4): Remove dynamic ITR code, since it's unused
ixlv(4): Set max number of queues used in iflib based on number VF receives from PF
ixlv(4): Code cleanup
ixlv(4): Don't sleep for a response to a VC msg if driver is in detach
ixl(4): Clear VF qtag queue flags when VF is being reinitialized
ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for completion
ixlv(4): Modify debug prints, and stop printing out "Queue already enabled" warnings
ixl(4): Update version number to 2.1.0-k

Harbormaster completed remote builds in B19831: Diff 48493.Sep 27 2018, 12:56 AM

erj mentioned this in D15927: Update ixl(4) and ixlv(4) man pages.Oct 2 2018, 3:54 PM

Rebased onto latest master, and added:

ixl(4): Reconfigure MAC/VLAN filters after adding VEB during SR-IOV init

Harbormaster completed remote builds in B19934: Diff 48688.Oct 3 2018, 8:10 PM

Ugh, rebasing changes the commit SHAs :(

I guess it's the price you pay for the appearance of cleanliness...

krzysztof.galazka_intel.com mentioned this in D17404: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 4 2018, 12:32 PM

ixlv/iavf(4): Change "ixlv" driver name to "iavf"

Harbormaster completed remote builds in B19990: Diff 48761.Oct 4 2018, 10:29 PM

erj retitled this revision from ixlv(4): Update to use iflib to ixlv(4): Update to use iflib; change name to iavf(4).Oct 4 2018, 10:31 PM

iavf(4): Move modules/Makefile entry so that it's in alphabetical order
iavf(4): Update MODULE_* macros with new "iavf" name

Harbormaster completed remote builds in B20010: Diff 48795.Oct 5 2018, 6:52 PM

erj added a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 5 2018, 8:21 PM

erj added a child revision: D15927: Update ixl(4) and ixlv(4) man pages.

Can you rename the sys/dev/ixl dir to iavf as part of this? I'd really like to see this change done now in 12.0, it would be very awkward to try and MFC later.

Sorry the first part of my comment made no sense, ixl is the pf and will remain for 25/40g hw parts.

jeffrey.e.pieper_intel.com accepted this revision.Oct 11 2018, 8:14 PM

This revision is now accepted and ready to land.Oct 11 2018, 8:14 PM

sbruno accepted this revision.Oct 11 2018, 10:48 PM

Any last-minute assents or objections?

kbowling accepted this revision.Oct 12 2018, 5:55 AM

erj removed a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 12 2018, 5:28 PM

Closed by commit rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9) (authored by erj). · Explain WhyOct 12 2018, 10:41 PM

This revision was automatically updated to reflect the committed changes.

erj mentioned this in rS339634: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 23 2018, 4:37 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

GENERIC

5 lines

NOTES

7 lines

conf/

files.amd64

24 lines

dev/

ixl/

34 lines

216 lines

2858 lines

38 lines

23 lines

39 lines

12 lines

195 lines

554 lines

16 lines

20 lines

249 lines

151 lines

614 lines

modules/

Makefile

3 lines

	iavf/
	ixlv/

Makefile

6 lines

ixl/

Makefile

10 lines

ixlv/

net/

4 lines

124 lines

1 line

Commit	Tree	Parents	Author	Summary	Date
29ca424e0db7	366a7fc2f5b2	b3237522d21b	Eric Joyner	ixlv/iavf(4): Change "ixlv" driver name to "iavf" (Show More…)	Oct 4 2018, 8:50 PM
b3237522d21b	a2d5afe4311c	df77d475866a	Eric Joyner	ixl(4): Reconfigure MAC/VLAN filters after adding VEB during SR-IOV init (Show More…)	Oct 3 2018, 7:57 PM
df77d475866a	c1d8661bae88	7665a4769fa5	Eric Joyner	ixl(4): Update version number to 2.1.0-k (Show More…)	Sep 27 2018, 12:50 AM
7665a4769fa5	c325212c54ab	c7746d3510f1	Eric Joyner	ixlv(4): Modify debug prints, and stop printing out "Queue already enabled"… (Show More…)	Sep 27 2018, 12:46 AM
c7746d3510f1	dfd7633da723	74922330369b	Eric Joyner	ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for… (Show More…)	Sep 27 2018, 12:44 AM
74922330369b	d216e023d0af	859163942d21	Eric Joyner	ixl(4): Clear VF qtag queue flags when VF is being reinitialized (Show More…)	Sep 27 2018, 12:12 AM
859163942d21	efebec9676b9	0ab05516b801	Eric Joyner	ixlv(4): Don't sleep for a response to a VC msg if driver is in detach (Show More…)	Sep 27 2018, 12:11 AM
0ab05516b801	be257696ba00	ead4eeb0473b	Eric Joyner	ixlv(4): Code cleanup (Show More…)	Sep 27 2018, 12:10 AM
ead4eeb0473b	6c990699b6b0	181424581197	Eric Joyner	ixlv(4): Set max number of queues used in iflib based on number VF receives… (Show More…)	Sep 27 2018, 12:07 AM
181424581197	6fe764a3ed37	fd79a2ccc082	Eric Joyner	ixlv(4): Remove dynamic ITR code, since it's unused (Show More…)	Sep 27 2018, 12:06 AM
fd79a2ccc082	bc2d3d85b62c	58ac8da9cefe	Eric Joyner	ixlv(4): Update driver version to 2.0.0-k (Show More…)	Sep 27 2018, 12:04 AM
58ac8da9cefe	46b9a84decf6	72c20910290d	Krzysztof Galazka	ixl(4): Fix filter handling when SR-IOV is enabled (Show More…)	Sep 20 2018, 3:38 PM
72c20910290d	1336dae9ea6f	16f3222027a2	Eric Joyner	ixl(4): Fix compile error introduced by previous commit (Show More…)	Sep 13 2018, 11:00 PM
16f3222027a2	7b5217f69f1a	af83f9d18f8d	Eric Joyner	ixl(4): Configure promiscuous mode during driver init (Show More…)	Sep 13 2018, 10:51 PM
af83f9d18f8d	da75bdb36c99	407c46e7c8b9	Piotr Pietruszewski	ixlv(4): Disable queues before initialization. (Show More…)	Sep 13 2018, 5:51 PM
407c46e7c8b9	2aa4f4dda2c0	1e91a0ff549d	Eric Joyner	ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists (Show More…)	Sep 4 2018, 11:23 PM
1e91a0ff549d	3b89d176c2d8	8e8feb566f64	Eric Joyner	ixlv(4): Update some debug printf()'s to use newer debug functions (Show More…)	Sep 4 2018, 11:23 PM
8e8feb566f64	cd20e9e2d2c2	bf35648c91f4	Eric Joyner	ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses (Show More…)	Sep 4 2018, 11:20 PM
bf35648c91f4	71357c90cf56	0de3f7cb8e55	Eric Joyner	ixlv(4): Remove commented out code (Show More…)	Sep 4 2018, 11:13 PM
0de3f7cb8e55	b591f33a9f67	28251dd3a238	Eric Joyner	ixlv(4): Swap MALLOC_DEFINE/DECLARE statements (Show More…)	Sep 4 2018, 11:11 PM
28251dd3a238	780cb57028ba	f110bac1ce8f	Eric Joyner	ixl(4): Fix kernel panic during init() when Admin Queue is not alive (Show More…)	Aug 30 2018, 11:52 PM
f110bac1ce8f	7c2415b017d6	e2cad3ec9080	Krzysztof Galazka	ixl/ixlv Missing semicolon in DWB fix (Show More…)	Aug 27 2018, 11:21 AM
e2cad3ec9080	f893eb769d1c	f5d9e201c63d	Eric Joyner	ixl(4): Fix memory leak when head writeback is disabled (Show More…)	Aug 23 2018, 9:15 PM
f5d9e201c63d	63cf4d97b43d	fb57b5fd089c	Krzysztof Galazka	ixl/ixlv(4): Fix TXD credits update for DWB mode (Show More…)	Aug 23 2018, 8:37 AM
fb57b5fd089c	2674578adbcc	3843579fdce9	Eric Joyner	ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config… (Show More…)	Aug 22 2018, 12:41 AM
3843579fdce9	699863b90377	43598e54ad4f	Eric Joyner	ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue… (Show More…)	Aug 21 2018, 10:36 PM
43598e54ad4f	e5d67c9d5966	9a6415007321	Eric Joyner	ixl/ixlv(4): Add more MPASS statements to TX path (Show More…)	Aug 21 2018, 12:34 AM
9a6415007321	918ce991a90c	afe925cf1d16	Eric Joyner	ixl(4): Fix RX MDD event display (Show More…)	Aug 20 2018, 8:30 PM
afe925cf1d16	4a3cb333c050	5fe4a7970803	Eric Joyner	ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path (Show More…)	Aug 16 2018, 11:38 PM
5fe4a7970803	cd294e9c138b	1f9ac83fb665	Eric Joyner	ixl(4): Print out additional event information when a LAN Overflow Event occurs (Show More…)	Aug 16 2018, 11:37 PM
1f9ac83fb665	dbd097035910	b722fb9f4ac9	Eric Joyner	ixl(4): Enhance Malicious Driver Detection messages with VF information (Show More…)	Aug 16 2018, 11:36 PM
b722fb9f4ac9	e7bcf6cbd78f	f90d215efd04	Eric Joyner	ixlv(4): Remove list of media types displayed in "ifconfig -m" (Show More…)	Aug 13 2018, 11:45 PM
f90d215efd04	567fefd71c63	2b66a6b31641	Eric Joyner	ixlv(4): Remove comments and commented out code (Show More…)	Aug 13 2018, 11:43 PM
2b66a6b31641	8b514950d54b	7c81f45822f6	Eric Joyner	ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT (Show More…)	Aug 13 2018, 11:40 PM
7c81f45822f6	175ccd847a73	f1d3496b3d89	Eric Joyner	ixlv(4): Fix a memory leak when interrupt setup fails (Show More…)	Aug 13 2018, 11:03 PM
f1d3496b3d89	39249a16425d	e2a6991d7175	Eric Joyner	ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV (Show More…)	Aug 13 2018, 10:10 PM
e2a6991d7175	2ab0ec2d524d	0cb40a34cc98	Eric Joyner	ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic (Show More…)	Aug 10 2018, 5:27 PM
0cb40a34cc98	ab6d7ab8a88e	51b70540a4e6	Eric Joyner	ixl(4): Fix compile error when PCI_IOV isn't defined (Show More…)	Aug 9 2018, 10:17 PM
51b70540a4e6	8ac7cc4b5d6b	bbf6b8f6d938	Eric Joyner	ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing (Show More…)	Aug 9 2018, 6:23 PM
bbf6b8f6d938	d141f6eb8f0a	4965e2925b1c	Eric Joyner	ixl(4): Add tunable to enable VF loopback; enable by default (Show More…)	Aug 9 2018, 12:10 AM
4965e2925b1c	b8bffc4ec580	1455e8ea029b	Eric Joyner	ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to… (Show More…)	Aug 3 2018, 6:27 PM
1455e8ea029b	7a321c0ba703	e16259d0cb21	Eric Joyner	ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one… (Show More…)	Aug 2 2018, 8:41 PM
e16259d0cb21	cdfd306ae56c	07b89e5d6765	Eric Joyner	ixl(4): Fix module Makefile when PCI_IOV is enabled (Show More…)	Jul 26 2018, 9:02 PM
07b89e5d6765	91ffad5e9d67	be39750bfe05	Eric Joyner	ixl/ixlv(4): Preserve code removal done in r336313 (Show More…)	Jul 25 2018, 7:54 PM
be39750bfe05	b87bb19bd78f	03163159582f	Eric Joyner	ixlv(4): Use same TX DMA seg sizes as the ones in ixl(4) (Show More…)	Jul 25 2018, 7:50 PM
03163159582f	a5e801033355	cd0ba74a889f	Eric Joyner	ixlv(4): Remove old/dead code (Show More…)	Jul 25 2018, 5:58 PM
cd0ba74a889f	7086140ccbbb	f0bad80034a1	Eric Joyner	ixl/ixlv(4): Fix module Makefiles (Show More…)	Jul 25 2018, 4:15 PM
f0bad80034a1	753dd19f5a15	d7b9a53192e3	Eric Joyner	ixlv(4): Re-add driver to GENERIC and build files (Show More…)	Jul 25 2018, 4:08 PM
d7b9a53192e3	35973cb58cb8	cca8927a14b5	Eric Joyner	ixlv(4): Fixup bad merge (Show More…)	Jul 24 2018, 7:17 AM
cca8927a14b5	32c0866a8887	77939f5bbca5	Eric Joyner	ixlv(4): Convert some M_DEVBUF malloc types to M_IXLV (Show More…)	Jul 24 2018, 6:48 AM
77939f5bbca5	0e675d988697	cc1120e5fe69	Eric Joyner	ixlv(4): Check if ASQ is alive before sending message to PF (Show More…)	Jul 24 2018, 6:47 AM
cc1120e5fe69	c82072c6cd53	a4b13cff3a59	Eric Joyner	ixlv(4): Remove unused states and variables from ixlv.h (Show More…)	Jul 24 2018, 6:42 AM
a4b13cff3a59	0f41115711b3	c0dde44dffbb	Eric Joyner	ixl(4): Update debug.filter_list to print out VF filters (Show More…)	Jul 24 2018, 6:41 AM
c0dde44dffbb	807d4d9ebaad	5ceaeaf842f0	Eric Joyner	ixl(4): Remove comments and unused sysctl (Show More…)	Jul 24 2018, 6:40 AM
5ceaeaf842f0	0a582d083550	4b70d156dbf1	Eric Joyner	ixl(4): Add debug print statements to filter add/delete functions (Show More…)	Jul 24 2018, 6:40 AM
4b70d156dbf1	d08bfb9af223	044959a78fa7	Eric Joyner	ixl(4): Remove unnecessary MPASS() (Show More…)	Jul 24 2018, 6:39 AM
044959a78fa7	0c36344f9c5a	3b3bf5546717	Eric Joyner	ixl(4): Set IXL_FILTER_USED when adding a MAC filter (Show More…)	Jul 24 2018, 6:38 AM
3b3bf5546717	c7242b0a48be	0c8d8e0c0a52	Eric Joyner	ixl(4): Remove unused sysctl (Show More…)	Jul 24 2018, 6:38 AM
0c8d8e0c0a52	10895885f605	5e3424bdd547	Eric Joyner	ixl(4): Admin queue interrupt fixes (and VFLR handling) (Show More…)	Jul 24 2018, 6:36 AM
5e3424bdd547	68674c0deedf	8770534f074d	Eric Joyner	ixl(4): Update ixl_handle_vflr() for iflib (Show More…)	Jul 24 2018, 6:34 AM
8770534f074d	d7f0932f7993	5be70db2aefd	Eric Joyner	ixl(4): Make VFs use LRXQTHRESH value of 1, like PF (Show More…)	Jul 24 2018, 6:32 AM
5be70db2aefd	8c17d1efac7f	25aaecc1d5aa	Eric Joyner	ixl(4): Re-add VF filters after VF reset (Show More…)	Jul 24 2018, 6:31 AM
25aaecc1d5aa	b835f038f2c1	35f49740c2b9	Eric Joyner	ixl(4): Add new debug mask flag and shortcut functions (Show More…)	Jul 24 2018, 6:29 AM
35f49740c2b9	bbb7620e60a7	b65ad4dc3df5	Eric Joyner	ixl(4): Remove unused variables in struct ixl_pf (Show More…)	Jul 24 2018, 6:27 AM
b65ad4dc3df5	53df09e8ec86	5438034e1dc3	Eric Joyner	ixlv(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:48 AM
5438034e1dc3	bed9e3009308	d42d14b544a1	Eric Joyner	ixlv(4): Fixes to admin queue interrupt handling (Show More…)	Jul 24 2018, 5:46 AM
d42d14b544a1	2c286715cc15	7336614b23a5	Eric Joyner	ixlv(4): Re-enable PCI busmaster after reset (Show More…)	Jul 24 2018, 5:45 AM
7336614b23a5	4ed129c1941c	61cb63335a72	Eric Joyner	ixlv(4): Add missing line break at end of message (Show More…)	Jul 24 2018, 5:44 AM
61cb63335a72	5a552dd62da3	c2a65690ba16	Eric Joyner	ixlv(4): Configure multicast promiscuous when there are more multicast filters… (Show More…)	Jul 24 2018, 5:43 AM
c2a65690ba16	8920a27112cd	b6b7529bd845	Eric Joyner	ixlv(4): Try to handle critical AQ errors better (Show More…)	Jul 24 2018, 5:42 AM
b6b7529bd845	a03441e5d60f	3f5c49bf11de	Eric Joyner	ixlv(4): Attempt to fix VFLR recovery (Show More…)	Jul 24 2018, 5:40 AM
3f5c49bf11de	045a4a04ac11	59f857437994	Eric Joyner	ixlv(4): Fix TX initialization (Show More…)	Jul 24 2018, 5:38 AM
59f857437994	1be0a10d0438	e23bc9d28639	Eric Joyner	ixlv(4): Add VF reset debug sysctls (Show More…)	Jul 24 2018, 5:36 AM
e23bc9d28639	784e1ad1b816	e2247c4eb73b	Eric Joyner	ixl(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:29 AM
e2247c4eb73b	2be453ab5ef3	59244a114f63	Eric Joyner	ixlv(4): Set a driver state for the VF at the end of attach (Show More…)	Jul 24 2018, 5:09 AM
59244a114f63	0160e13a264d	6935a0e1ba72	Eric Joyner	ixlv(4): Don't set IFLIB_ADMIN_ALWAYS_RUN flag (Show More…)	Jul 24 2018, 5:07 AM
6935a0e1ba72	7a5c7ddae426	f7a0e55083d2	Eric Joyner	ixl(4): Make ixl_if_vflr_handle() call ixl_handle_vflr() (Show More…)	Jul 24 2018, 5:06 AM
f7a0e55083d2	ed2cb7fda675	a425faec1543	Eric Joyner	ixl(4): Setup softirq to handle VFLR interrupt task (Show More…)	Jul 24 2018, 5:06 AM
a425faec1543	825b1b25e550	37db21501d51	Eric Joyner	ixl(4): Remove old comment (Show More…)	Jul 24 2018, 5:05 AM
37db21501d51	2c67977ecb66	419bc2734a56	Eric Joyner	ixlv(4): Add VF reset request debug sysctl (Show More…)	Jul 14 2018, 12:21 AM
419bc2734a56	ac87c82d1ebc	0dfddbf4289f	Eric Joyner	ixlv(4): Convert VC msg functions to return an error on failure, instead of void (Show More…)	Jul 14 2018, 12:08 AM
0dfddbf4289f	597b74554657	173ec327bf4a	Eric Joyner	ixlv(4): Remove unnecessary #include (Show More…)	Jul 13 2018, 11:37 PM
173ec327bf4a	da654b3d8631	e85fc9362f57	Eric Joyner	ixl/ixlv(4): Add per-queue stats to VF (Show More…)	Jul 13 2018, 11:05 PM
e85fc9362f57	9305f0fbe122	71359375fada	Eric Joyner	ixl/ixlv(4): Add VSI stats sysctls to VF driver (Show More…)	Jul 13 2018, 7:35 PM
71359375fada	eb57aecde5d2	55f9575c4f25	Eric Joyner	ixlv(4): Enable checking for critical AQ errors during AQ processing (Show More…)	Jul 13 2018, 6:42 PM
55f9575c4f25	8cdec2d2ca2b	b3185e9d9d6c	Eric Joyner	ixlv: Add debug sysctl to print out VF filter lists (Show More…)	Jul 12 2018, 5:12 PM
b3185e9d9d6c	a46606c0c028	8baf237c266d	Eric Joyner	ixl/ixlv: Support for the VF configuring promiscuous mode (Show More…)	Jul 11 2018, 10:21 PM
8baf237c266d	ba29b0036161	7bc4ca81e45d	Eric Joyner	ixl/ixlv: Remove README and commented out code	Jul 9 2018, 7:25 PM
7bc4ca81e45d	ef12a2714b89	6520bc93a293	Eric Joyner	ixlv: Start reworking VF sysctls, change more debug statements to use new… (Show More…)	Jul 7 2018, 12:20 AM
6520bc93a293	0d24801f13fc	2ccc95ff7fa2	Eric Joyner	ixlv: Add core_debug_mask & shared_debug_mask sysctls and tunables (Show More…)	Jul 5 2018, 11:48 PM
2ccc95ff7fa2	fc32270d5a5b	1eef3adbe4eb	Eric Joyner	ixl/ixlv: Re-comment printf (Show More…)	Jul 3 2018, 12:52 AM
1eef3adbe4eb	926de3481633	74e927043373	Eric Joyner	ixl/ixlv: VF can ping! (Show More…)	Jul 3 2018, 12:48 AM
74e927043373	3c3a7e0feb2a	1fb93de40f78	Eric Joyner	ixlv: Fix compile error and memory leak (Show More…)	Jun 29 2018, 9:49 PM
1fb93de40f78	466964b8625e	d28a7a19d4ad	Eric Joyner	ixl/ixlv: Make a large number of small changes (Show More…)	Jun 29 2018, 9:45 PM
d28a7a19d4ad	ad1aec915411	f51b12ce2838	Eric Joyner	ixlv(4): Remove a couple empty lines (Show More…)	Jun 27 2018, 8:19 PM
f51b12ce2838	4781a436c5c2	9b4ba346ed90	Eric Joyner	ixl(4): Reset created VF after it is setup (Show More…)	Jun 26 2018, 6:03 PM
9b4ba346ed90	c57bdde7af47	00c902970923	Eric Joyner	ixl/ixlv(4): Move ixl_aq_max_speed_to_value back into PF-only files from… (Show More…)	Jun 26 2018, 6:03 PM
00c902970923	9723de51ba09	addd741b7f59	Eric Joyner	ixlv(4): Update comments and formatting (Show More…)	Jun 26 2018, 6:02 PM
addd741b7f59	f70ad19e58f7	0ea06c00d740	Eric Joyner	ixlv(4): Remove commented out code (Show More…)	Jun 26 2018, 6:02 PM
0ea06c00d740	d43219a5fae3	6f73ec108ebb	Eric Joyner	ixlv(4): Assert that VC mgr is setup when ixl_if_init() begins (Show More…)	Jun 26 2018, 6:02 PM
6f73ec108ebb	79d5416f13ac	cdd5aa07769f	Eric Joyner	ixlv(4): Update more functions to use ixlv_sc as interface softc (Show More…)	Jun 26 2018, 6:01 PM
cdd5aa07769f	93619f7e63d0	bb5a47041bca	Eric Joyner	ixlv(4): Call ixl_vc_init_mgr() on attach (Show More…)	Jun 26 2018, 5:59 PM
bb5a47041bca	c3790233624e	bae78296bb25	Eric Joyner	ixlv(4): Fix panic on failed attach (Show More…)	Jun 26 2018, 5:57 PM
bae78296bb25	299e04c6f623	b1fcea7a07a5	Eric Joyner	ixl/ixlv(4): Stop setting legacy intr field in iflib txrx function pointer… (Show More…)	Jun 26 2018, 4:01 PM
b1fcea7a07a5	64f171ed94a3	daab7a7530da	Eric Joyner	ixlv(4): Remove some of the calls to ixl_vc_mgr code (Show More…)	Jun 26 2018, 12:36 AM
daab7a7530da	eebe9fd77df2	7574ad3c2513	Eric Joyner	ixlv(4): Change version string and device ID list to match ixl(4)'s (Show More…)	Jun 22 2018, 11:29 PM
7574ad3c2513	0de19517a662	d3e460d10deb	Eric Joyner	ixl(4): Fix up error message by adding a newline (Show More…)	Jun 19 2018, 5:57 PM
d3e460d10deb	8404660d647d	588ec13bd0f0	Eric Joyner	ixl(4): Fix kernel panic (Show More…)	May 24 2018, 11:07 PM
588ec13bd0f0	91cad78bd51b	52095726f827	Eric Joyner	ixl(4): Fix VF queue disable during reinit (Show More…)	May 24 2018, 10:39 PM
52095726f827	f3e5cb2d0bec	e18a33258dc4	Eric Joyner	ixl(4): Remove unused variables	May 23 2018, 6:41 PM
e18a33258dc4	6f56d9272ec6	55eea3ad6e6b	Eric Joyner	ixl(4): Fix improper queue mapping during PF LAN VSI context setup (Show More…)	May 22 2018, 9:33 PM
55eea3ad6e6b	1732639caa22	d25c05fc107a	Eric Joyner	ixl(4): Change malloc type to M_NOWAIT (Show More…)	Jul 24 2018, 5:23 PM
d25c05fc107a	6bb6cd395fc0	38f4aa2037a5	Eric Joyner	ixl(4): Get device_t from pf struct instead of iflib (Show More…)	Jul 24 2018, 5:22 PM
38f4aa2037a5	3a3167df7337	a1aa41403200	Eric Joyner	ixl(4): Remove pci_iov_detach() call from driver detach (Show More…)	Jul 24 2018, 5:06 PM
a1aa41403200	9969498b8ee8	06bb02c83767	Eric Joyner	ixl(4): Implement SR-IOV handlers for iflib (Show More…)	Jul 24 2018, 5:04 PM
06bb02c83767	c18742444acb	07a933a6380a	Eric Joyner	Revert "iflib: Free RX queue TCP LRO memory on unload" (Show More…)	Sep 20 2018, 5:36 PM
07a933a6380a	f1c2c54d7c40	7bb86db9d6e9	Eric Joyner	iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock… (Show More…)	Aug 28 2018, 11:40 PM
7bb86db9d6e9	954e7e6f9d61	56bda4b5feba	Eric Joyner	iflib: Destroy state lock at end of iflib_device_deregister() (Show More…)	Aug 28 2018, 11:16 PM
56bda4b5feba	80b4dadb63c3	a2ffd7c2f729	Eric Joyner	iflib: Free RX queue TCP LRO memory on unload (Show More…)	Aug 13 2018, 11:50 PM
a2ffd7c2f729	13515182c319	2913a78dec44	Eric Joyner	iflib: Free remaining interrupt resources on failure in iflib_device_register() (Show More…)	Aug 13 2018, 11:47 PM
2913a78dec44	70d0e38d594a	2e6bfc180639	Eric Joyner	iflib: Add STATE_LOCK() around flag setting in iflib_request_reset() (Show More…)	Aug 9 2018, 6:28 PM
2e6bfc180639	676ec00d8ef7	91712effcefa	Eric Joyner	iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach (Show More…)	Aug 9 2018, 6:11 PM
91712effcefa	a6f544f3ec2e	a3fcdf6ef21d	Eric Joyner	iflib: Add public iflib_request_reset() for drivers to use (Show More…)	Jul 24 2018, 5:00 AM
a3fcdf6ef21d	a6a72077eabe	e640273705c6	Eric Joyner	iflib: Check IFLIB_ADMIN_ALWAYS_RUN flag in IOV task (Show More…)	Jul 24 2018, 4:59 AM
e640273705c6	fb34508d80a3	6d21d5af7b4f	Eric Joyner	iflib: style fixes (Show More…)	Jun 26 2018, 4:03 PM
6d21d5af7b4f	8e273b2dfbb6	af02cb62dce2	Eric Joyner	iflib: Call pci_iov_detach() during iflib_device_deregister() (Show More…)	May 22 2018, 9:26 PM