Details

Reviewers

sbruno
shurd
kbowling
gallatin
jeffrey.e.pieper_intel.com

Group Reviewers

Intel Networking

Commits

rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9)

Summary

(Summary forthcoming)

A list of git commits that are contained in this revision can be found here: https://github.com/freebsd/freebsd/compare/master...intel-wired-ethernet:ixl-iflib-sriov

Also includes changes to the PF driver (ixl(4)).

Includes the contents of D16428 already.

Test Plan

(To be filled out)

At least run the VF driver with an ixl(4) host bare metal and using bhyve, and a Linux (RHEL?) host using KVM.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18308
Build 18033: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

ixl(4): Fix module Makefile when PCI_IOV is enabled

Harbormaster completed remote builds in B18360: Diff 45891.Jul 26 2018, 9:08 PM

In general, I looked around at ixlv.c, and it looks like there are many functions for the main pf which are identical, or nearly identical for the VF. Can we please work on collapsing them down to common code?

sys/dev/ixl/ixl_pf_main.c
2370	I just hate that there are 2 functions which do almost the same thing. Can't you just change the args to ixl_disable_rings() to take pf and qtag and do this in a single function?
sys/dev/ixl/ixl_txrx.c
501	Errant space.

ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
Remove a space

Harbormaster completed remote builds in B18537: Diff 46214.Aug 2 2018, 8:47 PM

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it

Harbormaster completed remote builds in B18564: Diff 46257.Aug 3 2018, 6:33 PM

Changes from D16428:

iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

ixl(4): Add tunable to enable VF loopback; enable by default
ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing

Harbormaster completed remote builds in B18682: Diff 46482.Aug 9 2018, 6:40 PM

ixl(4): Fix compile error when PCI_IOV isn't defined

Harbormaster completed remote builds in B18688: Diff 46490.Aug 9 2018, 10:24 PM

gallatin accepted this revision.Aug 10 2018, 3:41 PM

This revision is now accepted and ready to land.Aug 10 2018, 3:41 PM

Several outstanding issues:

System back trace while running netperf tcp_rr test with jumbo frames enabled:

Fatal trap 12: page fault while in kernel mode
cpuid = 0; apic id = 00
fault virtual address = 0x1af0000
fault code = supervisor read data, page not present
instruction pointer = 0x20:0xffffffff80bdeb4f
stack pointer = 0x28:0xfffffe0025eeccb0
frame pointer = 0x28:0xfffffe0025eeccc0
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 12 (swi4: clock (0))
[ thread pid 12 tid 100034 ]
Stopped at m_tag_delete_chain+0x1f: movq (%rsi),%rdi
db> bt
Tracing pid 12 tid 100034 td 0xfffff800032c4580
m_tag_delete_chain() at m_tag_delete_chain+0x1f/frame 0xfffffe0025eeccc0
uma_zfree_arg() at uma_zfree_arg+0x3e/frame 0xfffffe0025eecd20
m_freem() at m_freem+0x9a/frame 0xfffffe0025eecd40
vtnet_txq_eof() at vtnet_txq_eof+0x75/frame 0xfffffe0025eecd70
vtnet_txq_mq_start_locked() at vtnet_txq_mq_start_locked+0x65/frame 0xfffffe0025eecdd0
vtnet_txq_mq_start() at vtnet_txq_mq_start+0x68/frame 0xfffffe0025eece10
ether_output_frame() at ether_output_frame+0xaa/frame 0xfffffe0025eece40
ether_output() at ether_output+0x6b7/frame 0xfffffe0025eecee0
ip_output() at ip_output+0x13e6/frame 0xfffffe0025eed020
tcp_output() at tcp_output+0x1b0c/frame 0xfffffe0025eed1b0
tcp_timer_delack() at tcp_timer_delack+0xf4/frame 0xfffffe0025eed1f0
softclock_call_cc() at softclock_call_cc+0x12e/frame 0xfffffe0025eed2a0
softclock() at softclock+0x79/frame 0xfffffe0025eed2c0
ithread_loop() at ithread_loop+0x1a7/frame 0xfffffe0025eed330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025eed370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025eed370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

Fatal trap 9: general protection fault while in kernel mode
cpuid = 1; apic id = 01
instruction pointer = 0x20:0xffffffff82d70048
stack pointer = 0x28:0xfffffe0025ec5150
frame pointer = 0x28:0xfffffe0025ec5180
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 0 (if_io_tqg_1)
[ thread pid 0 tid 100026 ]
Stopped at ixl_isc_rxd_pkt_get+0xc8: cmpl ll+0x1b(%rax),%esi
db> bt
Tracing pid 0 tid 100026 td 0xfffff800032ad580
ixl_isc_rxd_pkt_get() at ixl_isc_rxd_pkt_get+0xc8/frame 0xfffffe0025ec5180
iflib_rxeof() at iflib_rxeof+0x136/frame 0xfffffe0025ec5260
_task_fn_rx() at _task_fn_rx+0x76/frame 0xfffffe0025ec52a0
gtaskqueue_run_locked() at gtaskqueue_run_locked+0x144/frame 0xfffffe0025ec5300
gtaskqueue_thread_loop() at gtaskqueue_thread_loop+0x98/frame 0xfffffe0025ec5330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025ec5370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025ec5370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

It is possible to work around the issue by increasing the value of the rx_budget counter to the current value of the number of queues (44):
sysctl dev.ixl.0.iflib.rx_budget=44

Unable to initialize over 63 VF's:

Aug 10 14:48:56 u1017 kernel: ixl3: 0x400000 bytes of rid 0x184 res 3 failed (0, 0xffffffffffffffff).

Memory leak reported when unloading if_ixlv with 64 VF’s spawned:

Aug 10 14:51:18 u1017 kernel: ixlv62: Using MSIX interrupts with 5 vectors
Aug 10 14:51:18 u1017 kernel: ixlv62: Ethernet address: e2:db:49:42:7a:85
Aug 10 14:51:18 u1017 kernel: ixlv62: netmap queues/slots: TX 4/1024, RX 4/1024
Aug 10 14:51:18 u1017 kernel: ixlv63: <Intel(R) Ethernet Virtual Function 700 Series (X722)> at device 0.79 on pci13
Aug 10 14:51:18 u1017 kernel: ixlv62: link state changed to UP
Aug 10 14:51:18 u1017 kernel: ixlv63: PF API 1.1 / VF API 1.1
Aug 10 14:51:18 u1017 kernel: ixlv63: VSIs 1, QPs 4, MSIX 5, RSS sizes: key 52 lut 64
Aug 10 14:51:18 u1017 kernel: ixlv63: using 1024 tx descriptors and 1024 rx descriptors
Aug 10 14:51:18 u1017 kernel: ixlv63: msix_init qsets capped at 4
Aug 10 14:51:18 u1017 kernel: ixlv63: pxm cpus: 36 queue msgs: 4 admincnt: 1
Aug 10 14:51:18 u1017 kernel: ixlv63: using 4 rx queues 4 tx queues
Aug 10 14:51:18 u1017 kernel: ixlv63: Using MSIX interrupts with 4 vectors
Aug 10 14:51:18 u1017 kernel: ixlv63: failed to allocate IRQ for rid 5, name rxq3.
Aug 10 14:51:18 u1017 kernel: ixlv63: _iflib_irq_alloc failed 12
Aug 10 14:51:18 u1017 kernel: ixlv63: Failed to allocate queue RX int vector 3, err: 12
Aug 10 14:51:18 u1017 kernel: ixlv63: IFDI_MSIX_INTR_ASSIGN failed 12
Aug 10 14:51:18 u1017 kernel: device_attach: ixlv63 attach returned 12
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked MSI vectors
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked memory resources

After kldunload:

Aug 10 15:00:18 u1017 kernel: ixlv62: detached
Aug 10 15:00:18 u1017 kernel: pci13: <network, ethernet> at device 0.78 (no driver attached)
Aug 10 15:00:18 u1017 kernel: Warning: memory type ixlv leaked memory on destroy (4 allocations, 8192 bytes leaked).

This revision now requires changes to proceed.Aug 10 2018, 4:20 PM

ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic

Harbormaster completed remote builds in B18703: Diff 46521.Aug 10 2018, 5:37 PM

ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
ixlv(4): Fix a memory leak when interrupt setup fails
ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
ixlv(4): Remove comments and commented out code
ixlv(4): Remove list of media types displayed in "ifconfig -m"

Harbormaster completed remote builds in B18780: Diff 46642.Aug 14 2018, 12:03 AM

ixl(4): Enhance Malicious Driver Detection messages with VF information
ixl(4): Print out additional event information when a LAN Overflow Event occurs
ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path

Harbormaster completed remote builds in B18879: Diff 46809.Aug 16 2018, 11:45 PM

gallatin added inline comments.Aug 17 2018, 7:34 PM

sys/dev/ixl/if_ixl.c
1191	Please consider limiting this to a few prints. Otherwise, I anticipate this spamming the console / messages log at some point for somebody.
sys/dev/ixl/ixl_pf_main.c
2481	Nice! This would have been helpful during bringup of the iflib driver, but better late than never :)
sys/dev/ixl/ixl_txrx.c
366	0 is a perfectly valid DMA address on non-x86, or on x86 when using IOMMUs

ixl(4): Fix RX MDD event display
ixl/ixlv(4): Add more MPASS statements to TX path

Harbormaster completed remote builds in B18994: Diff 47009.Aug 21 2018, 12:42 AM

ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message

Harbormaster completed remote builds in B19027: Diff 47074.Aug 22 2018, 12:48 AM

ixl/ixlv(4): Fix TXD credits update for DWB mode

Harbormaster completed remote builds in B19111: Diff 47190.Aug 23 2018, 5:56 PM

ixl(4): Fix memory leak when head writeback is disabled

Harbormaster completed remote builds in B19117: Diff 47209.Aug 23 2018, 9:22 PM

ixl/ixlv Missing semicolon in DWB fix

Harbormaster completed remote builds in B19214: Diff 47347.Aug 27 2018, 3:43 PM

iflib: Destroy state lock at end of iflib_device_deregister()
iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
ixl(4): Fix kernel panic during init() when Admin Queue is not alive

Harbormaster completed remote builds in B19307: Diff 47509.Aug 31 2018, 12:01 AM

ixlv(4): Swap MALLOC_DEFINE/DECLARE statements
ixlv(4): Remove commented out code
ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses
ixlv(4): Update some debug printf()'s to use newer debug functions
ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists

Harbormaster completed remote builds in B19398: Diff 47671.Sep 4 2018, 11:33 PM

ixlv(4): Disable queues before initialization.

Harbormaster completed remote builds in B19573: Diff 48012.Sep 13 2018, 6:00 PM

ixl(4): Configure promiscuous mode during driver init

Harbormaster completed remote builds in B19583: Diff 48025.Sep 13 2018, 11:00 PM

ixl(4): Fix compile error introduced by previous commit

Harbormaster completed remote builds in B19585: Diff 48027.Sep 13 2018, 11:10 PM

ixl(4): Fix filter handling when SR-IOV is enabled
Revert "iflib: Free RX queue TCP LRO memory on unload"

Harbormaster completed remote builds in B19703: Diff 48274.Sep 20 2018, 5:40 PM

ixlv(4): Update driver version to 2.0.0-k
ixlv(4): Remove dynamic ITR code, since it's unused
ixlv(4): Set max number of queues used in iflib based on number VF receives from PF
ixlv(4): Code cleanup
ixlv(4): Don't sleep for a response to a VC msg if driver is in detach
ixl(4): Clear VF qtag queue flags when VF is being reinitialized
ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for completion
ixlv(4): Modify debug prints, and stop printing out "Queue already enabled" warnings
ixl(4): Update version number to 2.1.0-k

Harbormaster completed remote builds in B19831: Diff 48493.Sep 27 2018, 12:56 AM

erj mentioned this in D15927: Update ixl(4) and ixlv(4) man pages.Oct 2 2018, 3:54 PM

Rebased onto latest master, and added:

ixl(4): Reconfigure MAC/VLAN filters after adding VEB during SR-IOV init

Harbormaster completed remote builds in B19934: Diff 48688.Oct 3 2018, 8:10 PM

Ugh, rebasing changes the commit SHAs :(

I guess it's the price you pay for the appearance of cleanliness...

kgalazka mentioned this in D17404: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 4 2018, 12:32 PM

ixlv/iavf(4): Change "ixlv" driver name to "iavf"

Harbormaster completed remote builds in B19990: Diff 48761.Oct 4 2018, 10:29 PM

erj retitled this revision from ixlv(4): Update to use iflib to ixlv(4): Update to use iflib; change name to iavf(4).Oct 4 2018, 10:31 PM

iavf(4): Move modules/Makefile entry so that it's in alphabetical order
iavf(4): Update MODULE_* macros with new "iavf" name

Harbormaster completed remote builds in B20010: Diff 48795.Oct 5 2018, 6:52 PM

erj added a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 5 2018, 8:21 PM

erj added a child revision: D15927: Update ixl(4) and ixlv(4) man pages.

Can you rename the sys/dev/ixl dir to iavf as part of this? I'd really like to see this change done now in 12.0, it would be very awkward to try and MFC later.

Sorry the first part of my comment made no sense, ixl is the pf and will remain for 25/40g hw parts.

jeffrey.e.pieper_intel.com accepted this revision.Oct 11 2018, 8:14 PM

This revision is now accepted and ready to land.Oct 11 2018, 8:14 PM

sbruno accepted this revision.Oct 11 2018, 10:48 PM

Any last-minute assents or objections?

kbowling accepted this revision.Oct 12 2018, 5:55 AM

erj removed a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 12 2018, 5:28 PM

Closed by commit rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9) (authored by erj). · Explain WhyOct 12 2018, 10:41 PM

This revision was automatically updated to reflect the committed changes.

erj mentioned this in rS339634: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 23 2018, 4:37 AM

Commit	Tree	Parents	Author	Summary	Date
0f9a255eebad	677867cacc9f	c97c2f359864	Eric Joyner	ixlv(4): Fixup bad merge (Show More…)	Jul 24 2018, 7:17 AM
c97c2f359864	631291e06267	e1a0f45b078c	Eric Joyner	ixlv(4): Convert some M_DEVBUF malloc types to M_IXLV (Show More…)	Jul 24 2018, 6:48 AM
e1a0f45b078c	9350cd00b928	f6ef6a7d1f72	Eric Joyner	ixlv(4): Check if ASQ is alive before sending message to PF (Show More…)	Jul 24 2018, 6:47 AM
f6ef6a7d1f72	0b0b7ec3cad2	fa47a3ea6da4	Eric Joyner	ixlv(4): Remove unused states and variables from ixlv.h (Show More…)	Jul 24 2018, 6:42 AM
fa47a3ea6da4	77eec4d6868a	8f2e5d99422b	Eric Joyner	ixl(4): Update debug.filter_list to print out VF filters (Show More…)	Jul 24 2018, 6:41 AM
8f2e5d99422b	42679ca80ec6	48ff72ac30e5	Eric Joyner	ixl(4): Remove comments and unused sysctl (Show More…)	Jul 24 2018, 6:40 AM
48ff72ac30e5	7292e93138a2	96a1809b3ec5	Eric Joyner	ixl(4): Add debug print statements to filter add/delete functions (Show More…)	Jul 24 2018, 6:40 AM
96a1809b3ec5	069cd79c86b9	db51cd8f4091	Eric Joyner	ixl(4): Remove unnecessary MPASS() (Show More…)	Jul 24 2018, 6:39 AM
db51cd8f4091	379ad6abaae7	8e3887ec36e3	Eric Joyner	ixl(4): Set IXL_FILTER_USED when adding a MAC filter (Show More…)	Jul 24 2018, 6:38 AM
8e3887ec36e3	90f16473285e	73a8c136dbc6	Eric Joyner	ixl(4): Remove unused sysctl (Show More…)	Jul 24 2018, 6:38 AM
73a8c136dbc6	585516f8fb4a	1477f8a8caed	Eric Joyner	ixl(4): Admin queue interrupt fixes (and VFLR handling) (Show More…)	Jul 24 2018, 6:36 AM
1477f8a8caed	0b6b7ede285d	a6d18816451f	Eric Joyner	ixl(4): Update ixl_handle_vflr() for iflib (Show More…)	Jul 24 2018, 6:34 AM
a6d18816451f	cd4cc12e3d42	1457d769ba13	Eric Joyner	ixl(4): Make VFs use LRXQTHRESH value of 1, like PF (Show More…)	Jul 24 2018, 6:32 AM
1457d769ba13	45f3eb6db744	dc88fecf61ef	Eric Joyner	ixl(4): Re-add VF filters after VF reset (Show More…)	Jul 24 2018, 6:31 AM
dc88fecf61ef	906ebc1583bb	e17877a2074d	Eric Joyner	ixl(4): Add new debug mask flag and shortcut functions (Show More…)	Jul 24 2018, 6:29 AM
e17877a2074d	a2d2165d3ed7	7f82088d4a94	Eric Joyner	ixl(4): Remove unused variables in struct ixl_pf (Show More…)	Jul 24 2018, 6:27 AM
7f82088d4a94	3d304920fef6	90a5e515aa88	Eric Joyner	ixlv(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:48 AM
90a5e515aa88	d974604fd221	0ddfb48edf5b	Eric Joyner	ixlv(4): Fixes to admin queue interrupt handling (Show More…)	Jul 24 2018, 5:46 AM
0ddfb48edf5b	17f6831576e3	d858fb6dee50	Eric Joyner	ixlv(4): Re-enable PCI busmaster after reset (Show More…)	Jul 24 2018, 5:45 AM
d858fb6dee50	e9cacc55ad35	6afc11ec603b	Eric Joyner	ixlv(4): Add missing line break at end of message (Show More…)	Jul 24 2018, 5:44 AM
6afc11ec603b	f05dd4966f77	d85326efd7ff	Eric Joyner	ixlv(4): Configure multicast promiscuous when there are more multicast filters… (Show More…)	Jul 24 2018, 5:43 AM
d85326efd7ff	4d0336639a1c	0c0b9c55ad24	Eric Joyner	ixlv(4): Try to handle critical AQ errors better (Show More…)	Jul 24 2018, 5:42 AM
0c0b9c55ad24	8bfeb96dd4a2	4c41ca3d622c	Eric Joyner	ixlv(4): Attempt to fix VFLR recovery (Show More…)	Jul 24 2018, 5:40 AM
4c41ca3d622c	5d03e574feab	646c92672b86	Eric Joyner	ixlv(4): Fix TX initialization (Show More…)	Jul 24 2018, 5:38 AM
646c92672b86	08a8307bcfca	b2fa4df8f659	Eric Joyner	ixlv(4): Add VF reset debug sysctls (Show More…)	Jul 24 2018, 5:36 AM
b2fa4df8f659	058a4566a071	c5139c8e2720	Eric Joyner	ixl(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:29 AM
c5139c8e2720	7a6b66651109	7a09fbd5ed45	Eric Joyner	ixlv(4): Set a driver state for the VF at the end of attach (Show More…)	Jul 24 2018, 5:09 AM
7a09fbd5ed45	51962bb5d655	3f9eb0f3b7a8	Eric Joyner	ixlv(4): Don't set IFLIB_ADMIN_ALWAYS_RUN flag (Show More…)	Jul 24 2018, 5:07 AM
3f9eb0f3b7a8	146ffc7578ed	70ae12841f91	Eric Joyner	ixl(4): Make ixl_if_vflr_handle() call ixl_handle_vflr() (Show More…)	Jul 24 2018, 5:06 AM
70ae12841f91	66da8dc075f8	8992dc9bff02	Eric Joyner	ixl(4): Setup softirq to handle VFLR interrupt task (Show More…)	Jul 24 2018, 5:06 AM
8992dc9bff02	2d5fbdebb406	2d5bef29b88a	Eric Joyner	ixl(4): Remove old comment (Show More…)	Jul 24 2018, 5:05 AM
2d5bef29b88a	c60dea20acc4	6322df173014	Eric Joyner	ixlv(4): Add VF reset request debug sysctl (Show More…)	Jul 14 2018, 12:21 AM
6322df173014	e970ace7856c	a6cd4a40469b	Eric Joyner	ixlv(4): Convert VC msg functions to return an error on failure, instead of void (Show More…)	Jul 14 2018, 12:08 AM
a6cd4a40469b	f4810675cd4a	6d6f77f3d7e7	Eric Joyner	ixlv(4): Remove unnecessary #include (Show More…)	Jul 13 2018, 11:37 PM
6d6f77f3d7e7	b405828324d6	7ba44b6c9101	Eric Joyner	ixl/ixlv(4): Add per-queue stats to VF (Show More…)	Jul 13 2018, 11:05 PM
7ba44b6c9101	08f353185cc8	252343673d16	Eric Joyner	ixl/ixlv(4): Add VSI stats sysctls to VF driver (Show More…)	Jul 13 2018, 7:35 PM
252343673d16	6072c3668a4d	1432a79863fa	Eric Joyner	ixlv(4): Enable checking for critical AQ errors during AQ processing (Show More…)	Jul 13 2018, 6:42 PM
1432a79863fa	af30705831b6	ff79c3939412	Eric Joyner	ixlv: Add debug sysctl to print out VF filter lists (Show More…)	Jul 12 2018, 5:12 PM
ff79c3939412	727c487d6a41	ec1066b4ba86	Eric Joyner	ixl/ixlv: Support for the VF configuring promiscuous mode (Show More…)	Jul 11 2018, 10:21 PM
ec1066b4ba86	0f73c8956155	d736bcc89151	Eric Joyner	ixl/ixlv: Remove README and commented out code	Jul 9 2018, 7:25 PM
d736bcc89151	7689b08db073	9675472082f6	Eric Joyner	ixlv: Start reworking VF sysctls, change more debug statements to use new… (Show More…)	Jul 7 2018, 12:20 AM
9675472082f6	46c8efe7d078	a2a6cd38177f	Eric Joyner	ixlv: Add core_debug_mask & shared_debug_mask sysctls and tunables (Show More…)	Jul 5 2018, 11:48 PM
a2a6cd38177f	b5bf31da53bb	98dadf475aa7	Eric Joyner	ixl/ixlv: Re-comment printf (Show More…)	Jul 3 2018, 12:52 AM
98dadf475aa7	d931a0115915	72aea9b0b1a3	Eric Joyner	ixl/ixlv: VF can ping! (Show More…)	Jul 3 2018, 12:48 AM
72aea9b0b1a3	6f5e8a99b94d	c4d74cb50559	Eric Joyner	ixlv: Fix compile error and memory leak (Show More…)	Jun 29 2018, 9:49 PM
c4d74cb50559	ff92e1413b44	cd1cff6a10a2	Eric Joyner	ixl/ixlv: Make a large number of small changes (Show More…)	Jun 29 2018, 9:45 PM
cd1cff6a10a2	f5d1f6f3e0ea	3500baee15e2	Eric Joyner	ixlv(4): Remove a couple empty lines (Show More…)	Jun 27 2018, 8:19 PM
3500baee15e2	a7fc85ce26b3	4221cf9b4b21	Eric Joyner	ixl(4): Reset created VF after it is setup (Show More…)	Jun 26 2018, 6:03 PM
4221cf9b4b21	adcd593013d3	1213503662da	Eric Joyner	ixl/ixlv(4): Move ixl_aq_max_speed_to_value back into PF-only files from… (Show More…)	Jun 26 2018, 6:03 PM
1213503662da	3272397b2707	c9bb4491414d	Eric Joyner	ixlv(4): Update comments and formatting (Show More…)	Jun 26 2018, 6:02 PM
c9bb4491414d	f76903fe55f9	20a63405c67a	Eric Joyner	ixlv(4): Remove commented out code (Show More…)	Jun 26 2018, 6:02 PM
20a63405c67a	1e7294e47992	8358893900e0	Eric Joyner	ixlv(4): Assert that VC mgr is setup when ixl_if_init() begins (Show More…)	Jun 26 2018, 6:02 PM
8358893900e0	5ad9095b3240	4a400398650a	Eric Joyner	ixlv(4): Update more functions to use ixlv_sc as interface softc (Show More…)	Jun 26 2018, 6:01 PM
4a400398650a	4e6d63ae509d	afdbf9b39e5a	Eric Joyner	ixlv(4): Call ixl_vc_init_mgr() on attach (Show More…)	Jun 26 2018, 5:59 PM
afdbf9b39e5a	6e01cbb423d9	74303538107f	Eric Joyner	ixlv(4): Fix panic on failed attach (Show More…)	Jun 26 2018, 5:57 PM
74303538107f	1e34f9b9e32a	842029aac41f	Eric Joyner	ixl/ixlv(4): Stop setting legacy intr field in iflib txrx function pointer… (Show More…)	Jun 26 2018, 4:01 PM
842029aac41f	a3de84819de3	fc333e71eba9	Eric Joyner	ixlv(4): Remove some of the calls to ixl_vc_mgr code (Show More…)	Jun 26 2018, 12:36 AM
fc333e71eba9	762c8a647351	ef809e2948e9	Eric Joyner	ixlv(4): Change version string and device ID list to match ixl(4)'s (Show More…)	Jun 22 2018, 11:29 PM
ef809e2948e9	7e09fcb52f29	c74122b16ad1	Eric Joyner	ixl(4): Fix up error message by adding a newline (Show More…)	Jun 19 2018, 5:57 PM
c74122b16ad1	85c309858267	c1ce323e9180	Eric Joyner	ixl(4): Fix kernel panic (Show More…)	May 24 2018, 11:07 PM
c1ce323e9180	4cbd120cf3cb	975af49b91b5	Eric Joyner	ixl(4): Fix VF queue disable during reinit (Show More…)	May 24 2018, 10:39 PM
975af49b91b5	2174a41146b3	63d3ce94c02c	Eric Joyner	ixl(4): Remove unused variables	May 23 2018, 6:41 PM
63d3ce94c02c	55655c636c72	95ff8b719592	Eric Joyner	ixl(4): Fix improper queue mapping during PF LAN VSI context setup (Show More…)	May 22 2018, 9:33 PM
95ff8b719592	f7eb8d0ee6b0	0ecc889c3e6a	Eric Joyner	ixl(4): Change malloc type to M_NOWAIT (Show More…)	Jul 24 2018, 5:23 PM
0ecc889c3e6a	163682a0d4a8	7bdc625d3671	Eric Joyner	ixl(4): Get device_t from pf struct instead of iflib (Show More…)	Jul 24 2018, 5:22 PM
7bdc625d3671	ecfbb97ea36c	d1da96f0d9f5	Eric Joyner	ixl(4): Remove pci_iov_detach() call from driver detach (Show More…)	Jul 24 2018, 5:06 PM
d1da96f0d9f5	524b1690613b	e8e6ce7f02b6	Eric Joyner	ixl(4): Implement SR-IOV handlers for iflib (Show More…)	Jul 24 2018, 5:04 PM
e8e6ce7f02b6	769d5b9da00b	0bf984d0871e	Eric Joyner	iflib: Add public iflib_request_reset() for drivers to use (Show More…)	Jul 24 2018, 5:00 AM
0bf984d0871e	e1f3ddc20eea	41a113a36bdb	Eric Joyner	iflib: Check IFLIB_ADMIN_ALWAYS_RUN flag in IOV task (Show More…)	Jul 24 2018, 4:59 AM
41a113a36bdb	8ac89b299860	910779344325	Eric Joyner	iflib: style fixes (Show More…)	Jun 26 2018, 4:03 PM
910779344325	e160e0c286ff	b8150c4df501	Eric Joyner	iflib: Call pci_iov_detach() during iflib_device_deregister() (Show More…)	May 22 2018, 9:26 PM

ixlv(4): Update to use iflib; change name to iavf(4)
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 45801

sys/dev/ixl/README

sys/dev/ixl/i40e_osdep.c

sys/dev/ixl/if_ixl.c

sys/dev/ixl/if_ixlv.c

sys/dev/ixl/ixl.h

sys/dev/ixl/ixl_debug.h

sys/dev/ixl/ixl_pf.h

sys/dev/ixl/ixl_pf_iov.h

sys/dev/ixl/ixl_pf_iov.c

sys/dev/ixl/ixl_pf_main.c

sys/dev/ixl/ixl_pf_qmgr.h

sys/dev/ixl/ixl_pf_qmgr.c

sys/dev/ixl/ixl_txrx.c

sys/dev/ixl/ixlv.h

sys/dev/ixl/ixlvc.c

sys/modules/ixl/Makefile

sys/modules/ixlv/Makefile

sys/net/iflib.h

sys/net/iflib.c

ixlv(4): Update to use iflib; change name to iavf(4)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45801

sys/dev/ixl/README

sys/dev/ixl/i40e_osdep.c

sys/dev/ixl/if_ixl.c

sys/dev/ixl/if_ixlv.c

sys/dev/ixl/ixl.h

sys/dev/ixl/ixl_debug.h

sys/dev/ixl/ixl_pf.h

sys/dev/ixl/ixl_pf_iov.h

sys/dev/ixl/ixl_pf_iov.c

sys/dev/ixl/ixl_pf_main.c

sys/dev/ixl/ixl_pf_qmgr.h

sys/dev/ixl/ixl_pf_qmgr.c

sys/dev/ixl/ixl_txrx.c

sys/dev/ixl/ixlv.h

sys/dev/ixl/ixlvc.c

sys/modules/ixl/Makefile

sys/modules/ixlv/Makefile

sys/net/iflib.h

sys/net/iflib.c

ixlv(4): Update to use iflib; change name to iavf(4)
ClosedPublic
Actions

Revision Contents
Changeset List