ixlv(4): Update to use iflib; change name to iavf(4)
ClosedPublic
Actions

Authored by erj on Jul 24 2018, 6:37 PM.

Details

Reviewers

sbruno
shurd
kbowling
gallatin
jeffrey.e.pieper_intel.com

Group Reviewers

Intel Networking

Commits

rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9)

Summary

(Summary forthcoming)

A list of git commits that are contained in this revision can be found here: https://github.com/freebsd/freebsd/compare/master...intel-wired-ethernet:ixl-iflib-sriov

Also includes changes to the PF driver (ixl(4)).

Includes the contents of D16428 already.

Test Plan

(To be filled out)

At least run the VF driver with an ixl(4) host bare metal and using bhyve, and a Linux (RHEL?) host using KVM.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19831
Build 19363: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

ixl(4): Fix module Makefile when PCI_IOV is enabled

Harbormaster completed remote builds in B18360: Diff 45891.Jul 26 2018, 9:08 PM

In general, I looked around at ixlv.c, and it looks like there are many functions for the main pf which are identical, or nearly identical for the VF. Can we please work on collapsing them down to common code?

sys/dev/ixl/ixl_pf_main.c
2365	I just hate that there are 2 functions which do almost the same thing. Can't you just change the args to ixl_disable_rings() to take pf and qtag and do this in a single function?
sys/dev/ixl/ixl_txrx.c
529	Errant space.

ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
Remove a space

Harbormaster completed remote builds in B18537: Diff 46214.Aug 2 2018, 8:47 PM

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it

Harbormaster completed remote builds in B18564: Diff 46257.Aug 3 2018, 6:33 PM

Changes from D16428:

iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

ixl(4): Add tunable to enable VF loopback; enable by default
ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing

Harbormaster completed remote builds in B18682: Diff 46482.Aug 9 2018, 6:40 PM

ixl(4): Fix compile error when PCI_IOV isn't defined

Harbormaster completed remote builds in B18688: Diff 46490.Aug 9 2018, 10:24 PM

gallatin accepted this revision.Aug 10 2018, 3:41 PM

This revision is now accepted and ready to land.Aug 10 2018, 3:41 PM

Several outstanding issues:

System back trace while running netperf tcp_rr test with jumbo frames enabled:

Fatal trap 12: page fault while in kernel mode
cpuid = 0; apic id = 00
fault virtual address = 0x1af0000
fault code = supervisor read data, page not present
instruction pointer = 0x20:0xffffffff80bdeb4f
stack pointer = 0x28:0xfffffe0025eeccb0
frame pointer = 0x28:0xfffffe0025eeccc0
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 12 (swi4: clock (0))
[ thread pid 12 tid 100034 ]
Stopped at m_tag_delete_chain+0x1f: movq (%rsi),%rdi
db> bt
Tracing pid 12 tid 100034 td 0xfffff800032c4580
m_tag_delete_chain() at m_tag_delete_chain+0x1f/frame 0xfffffe0025eeccc0
uma_zfree_arg() at uma_zfree_arg+0x3e/frame 0xfffffe0025eecd20
m_freem() at m_freem+0x9a/frame 0xfffffe0025eecd40
vtnet_txq_eof() at vtnet_txq_eof+0x75/frame 0xfffffe0025eecd70
vtnet_txq_mq_start_locked() at vtnet_txq_mq_start_locked+0x65/frame 0xfffffe0025eecdd0
vtnet_txq_mq_start() at vtnet_txq_mq_start+0x68/frame 0xfffffe0025eece10
ether_output_frame() at ether_output_frame+0xaa/frame 0xfffffe0025eece40
ether_output() at ether_output+0x6b7/frame 0xfffffe0025eecee0
ip_output() at ip_output+0x13e6/frame 0xfffffe0025eed020
tcp_output() at tcp_output+0x1b0c/frame 0xfffffe0025eed1b0
tcp_timer_delack() at tcp_timer_delack+0xf4/frame 0xfffffe0025eed1f0
softclock_call_cc() at softclock_call_cc+0x12e/frame 0xfffffe0025eed2a0
softclock() at softclock+0x79/frame 0xfffffe0025eed2c0
ithread_loop() at ithread_loop+0x1a7/frame 0xfffffe0025eed330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025eed370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025eed370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

Fatal trap 9: general protection fault while in kernel mode
cpuid = 1; apic id = 01
instruction pointer = 0x20:0xffffffff82d70048
stack pointer = 0x28:0xfffffe0025ec5150
frame pointer = 0x28:0xfffffe0025ec5180
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 0 (if_io_tqg_1)
[ thread pid 0 tid 100026 ]
Stopped at ixl_isc_rxd_pkt_get+0xc8: cmpl ll+0x1b(%rax),%esi
db> bt
Tracing pid 0 tid 100026 td 0xfffff800032ad580
ixl_isc_rxd_pkt_get() at ixl_isc_rxd_pkt_get+0xc8/frame 0xfffffe0025ec5180
iflib_rxeof() at iflib_rxeof+0x136/frame 0xfffffe0025ec5260
_task_fn_rx() at _task_fn_rx+0x76/frame 0xfffffe0025ec52a0
gtaskqueue_run_locked() at gtaskqueue_run_locked+0x144/frame 0xfffffe0025ec5300
gtaskqueue_thread_loop() at gtaskqueue_thread_loop+0x98/frame 0xfffffe0025ec5330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025ec5370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025ec5370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

It is possible to work around the issue by increasing the value of the rx_budget counter to the current value of the number of queues (44):
sysctl dev.ixl.0.iflib.rx_budget=44

Unable to initialize over 63 VF's:

Aug 10 14:48:56 u1017 kernel: ixl3: 0x400000 bytes of rid 0x184 res 3 failed (0, 0xffffffffffffffff).

Memory leak reported when unloading if_ixlv with 64 VF’s spawned:

Aug 10 14:51:18 u1017 kernel: ixlv62: Using MSIX interrupts with 5 vectors
Aug 10 14:51:18 u1017 kernel: ixlv62: Ethernet address: e2:db:49:42:7a:85
Aug 10 14:51:18 u1017 kernel: ixlv62: netmap queues/slots: TX 4/1024, RX 4/1024
Aug 10 14:51:18 u1017 kernel: ixlv63: <Intel(R) Ethernet Virtual Function 700 Series (X722)> at device 0.79 on pci13
Aug 10 14:51:18 u1017 kernel: ixlv62: link state changed to UP
Aug 10 14:51:18 u1017 kernel: ixlv63: PF API 1.1 / VF API 1.1
Aug 10 14:51:18 u1017 kernel: ixlv63: VSIs 1, QPs 4, MSIX 5, RSS sizes: key 52 lut 64
Aug 10 14:51:18 u1017 kernel: ixlv63: using 1024 tx descriptors and 1024 rx descriptors
Aug 10 14:51:18 u1017 kernel: ixlv63: msix_init qsets capped at 4
Aug 10 14:51:18 u1017 kernel: ixlv63: pxm cpus: 36 queue msgs: 4 admincnt: 1
Aug 10 14:51:18 u1017 kernel: ixlv63: using 4 rx queues 4 tx queues
Aug 10 14:51:18 u1017 kernel: ixlv63: Using MSIX interrupts with 4 vectors
Aug 10 14:51:18 u1017 kernel: ixlv63: failed to allocate IRQ for rid 5, name rxq3.
Aug 10 14:51:18 u1017 kernel: ixlv63: _iflib_irq_alloc failed 12
Aug 10 14:51:18 u1017 kernel: ixlv63: Failed to allocate queue RX int vector 3, err: 12
Aug 10 14:51:18 u1017 kernel: ixlv63: IFDI_MSIX_INTR_ASSIGN failed 12
Aug 10 14:51:18 u1017 kernel: device_attach: ixlv63 attach returned 12
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked MSI vectors
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked memory resources

After kldunload:

Aug 10 15:00:18 u1017 kernel: ixlv62: detached
Aug 10 15:00:18 u1017 kernel: pci13: <network, ethernet> at device 0.78 (no driver attached)
Aug 10 15:00:18 u1017 kernel: Warning: memory type ixlv leaked memory on destroy (4 allocations, 8192 bytes leaked).

This revision now requires changes to proceed.Aug 10 2018, 4:20 PM

ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic

Harbormaster completed remote builds in B18703: Diff 46521.Aug 10 2018, 5:37 PM

ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
ixlv(4): Fix a memory leak when interrupt setup fails
ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
ixlv(4): Remove comments and commented out code
ixlv(4): Remove list of media types displayed in "ifconfig -m"

Harbormaster completed remote builds in B18780: Diff 46642.Aug 14 2018, 12:03 AM

ixl(4): Enhance Malicious Driver Detection messages with VF information
ixl(4): Print out additional event information when a LAN Overflow Event occurs
ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path

Harbormaster completed remote builds in B18879: Diff 46809.Aug 16 2018, 11:45 PM

gallatin added inline comments.Aug 17 2018, 7:34 PM

sys/dev/ixl/if_ixl.c
1206	Please consider limiting this to a few prints. Otherwise, I anticipate this spamming the console / messages log at some point for somebody.
sys/dev/ixl/ixl_pf_main.c
2491	Nice! This would have been helpful during bringup of the iflib driver, but better late than never :)
sys/dev/ixl/ixl_txrx.c
384	0 is a perfectly valid DMA address on non-x86, or on x86 when using IOMMUs

ixl(4): Fix RX MDD event display
ixl/ixlv(4): Add more MPASS statements to TX path

Harbormaster completed remote builds in B18994: Diff 47009.Aug 21 2018, 12:42 AM

ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message

Harbormaster completed remote builds in B19027: Diff 47074.Aug 22 2018, 12:48 AM

ixl/ixlv(4): Fix TXD credits update for DWB mode

Harbormaster completed remote builds in B19111: Diff 47190.Aug 23 2018, 5:56 PM

ixl(4): Fix memory leak when head writeback is disabled

Harbormaster completed remote builds in B19117: Diff 47209.Aug 23 2018, 9:22 PM

ixl/ixlv Missing semicolon in DWB fix

Harbormaster completed remote builds in B19214: Diff 47347.Aug 27 2018, 3:43 PM

iflib: Destroy state lock at end of iflib_device_deregister()
iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
ixl(4): Fix kernel panic during init() when Admin Queue is not alive

Harbormaster completed remote builds in B19307: Diff 47509.Aug 31 2018, 12:01 AM

ixlv(4): Swap MALLOC_DEFINE/DECLARE statements
ixlv(4): Remove commented out code
ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses
ixlv(4): Update some debug printf()'s to use newer debug functions
ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists

Harbormaster completed remote builds in B19398: Diff 47671.Sep 4 2018, 11:33 PM

ixlv(4): Disable queues before initialization.

Harbormaster completed remote builds in B19573: Diff 48012.Sep 13 2018, 6:00 PM

ixl(4): Configure promiscuous mode during driver init

Harbormaster completed remote builds in B19583: Diff 48025.Sep 13 2018, 11:00 PM

ixl(4): Fix compile error introduced by previous commit

Harbormaster completed remote builds in B19585: Diff 48027.Sep 13 2018, 11:10 PM

ixl(4): Fix filter handling when SR-IOV is enabled
Revert "iflib: Free RX queue TCP LRO memory on unload"

Harbormaster completed remote builds in B19703: Diff 48274.Sep 20 2018, 5:40 PM

ixlv(4): Update driver version to 2.0.0-k
ixlv(4): Remove dynamic ITR code, since it's unused
ixlv(4): Set max number of queues used in iflib based on number VF receives from PF
ixlv(4): Code cleanup
ixlv(4): Don't sleep for a response to a VC msg if driver is in detach
ixl(4): Clear VF qtag queue flags when VF is being reinitialized
ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for completion
ixlv(4): Modify debug prints, and stop printing out "Queue already enabled" warnings
ixl(4): Update version number to 2.1.0-k

Harbormaster completed remote builds in B19831: Diff 48493.Sep 27 2018, 12:56 AM

erj mentioned this in D15927: Update ixl(4) and ixlv(4) man pages.Oct 2 2018, 3:54 PM

Rebased onto latest master, and added:

ixl(4): Reconfigure MAC/VLAN filters after adding VEB during SR-IOV init

Harbormaster completed remote builds in B19934: Diff 48688.Oct 3 2018, 8:10 PM

Ugh, rebasing changes the commit SHAs :(

I guess it's the price you pay for the appearance of cleanliness...

krzysztof.galazka_intel.com mentioned this in D17404: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 4 2018, 12:32 PM

ixlv/iavf(4): Change "ixlv" driver name to "iavf"

Harbormaster completed remote builds in B19990: Diff 48761.Oct 4 2018, 10:29 PM

erj retitled this revision from ixlv(4): Update to use iflib to ixlv(4): Update to use iflib; change name to iavf(4).Oct 4 2018, 10:31 PM

iavf(4): Move modules/Makefile entry so that it's in alphabetical order
iavf(4): Update MODULE_* macros with new "iavf" name

Harbormaster completed remote builds in B20010: Diff 48795.Oct 5 2018, 6:52 PM

erj added a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 5 2018, 8:21 PM

erj added a child revision: D15927: Update ixl(4) and ixlv(4) man pages.

Can you rename the sys/dev/ixl dir to iavf as part of this? I'd really like to see this change done now in 12.0, it would be very awkward to try and MFC later.

Sorry the first part of my comment made no sense, ixl is the pf and will remain for 25/40g hw parts.

jeffrey.e.pieper_intel.com accepted this revision.Oct 11 2018, 8:14 PM

This revision is now accepted and ready to land.Oct 11 2018, 8:14 PM

sbruno accepted this revision.Oct 11 2018, 10:48 PM

Any last-minute assents or objections?

kbowling accepted this revision.Oct 12 2018, 5:55 AM

erj removed a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 12 2018, 5:28 PM

Closed by commit rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9) (authored by erj). · Explain WhyOct 12 2018, 10:41 PM

This revision was automatically updated to reflect the committed changes.

erj mentioned this in rS339634: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 23 2018, 4:37 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

GENERIC

2 lines

NOTES

2 lines

conf/

files.amd64

8 lines

dev/

ixl/

34 lines

216 lines

2840 lines

38 lines

23 lines

39 lines

12 lines

192 lines

554 lines

16 lines

20 lines

249 lines

151 lines

614 lines

modules/

Makefile

1 line

ixl/

Makefile

10 lines

ixlv/

Makefile

4 lines

net/

iflib.h

4 lines

iflib.c

124 lines

iflib_private.h

1 line

Commit	Tree	Parents	Author	Summary	Date
1b8c4e2f77bc	bc797ee97942	582c5ea6f538	Eric Joyner	ixl(4): Update version number to 2.1.0-k (Show More…)	Sep 27 2018, 12:50 AM
582c5ea6f538	77cc177ce934	9a93af47e97a	Eric Joyner	ixlv(4): Modify debug prints, and stop printing out "Queue already enabled"… (Show More…)	Sep 27 2018, 12:46 AM
9a93af47e97a	3835ed3e5a55	086e9dff9560	Eric Joyner	ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for… (Show More…)	Sep 27 2018, 12:44 AM
086e9dff9560	fc0434820b69	b8818c78a8ff	Eric Joyner	ixl(4): Clear VF qtag queue flags when VF is being reinitialized (Show More…)	Sep 27 2018, 12:12 AM
b8818c78a8ff	d8114faac04f	f1bd01081844	Eric Joyner	ixlv(4): Don't sleep for a response to a VC msg if driver is in detach (Show More…)	Sep 27 2018, 12:11 AM
f1bd01081844	9169412b6b12	be4e50671937	Eric Joyner	ixlv(4): Code cleanup (Show More…)	Sep 27 2018, 12:10 AM
be4e50671937	ceeb8cef2cb7	0ee3a519b718	Eric Joyner	ixlv(4): Set max number of queues used in iflib based on number VF receives… (Show More…)	Sep 27 2018, 12:07 AM
0ee3a519b718	aa775a5a171b	c61263594c21	Eric Joyner	ixlv(4): Remove dynamic ITR code, since it's unused (Show More…)	Sep 27 2018, 12:06 AM
c61263594c21	7bf9f3abc364	a8fcdd8d4d65	Eric Joyner	ixlv(4): Update driver version to 2.0.0-k (Show More…)	Sep 27 2018, 12:04 AM
a8fcdd8d4d65	c9ab51275b38	4874ad0dc04b	Krzysztof Galazka	ixl(4): Fix filter handling when SR-IOV is enabled (Show More…)	Sep 20 2018, 3:38 PM
4874ad0dc04b	cda66a4e227d	f58a82d3e113	Eric Joyner	ixl(4): Fix compile error introduced by previous commit (Show More…)	Sep 13 2018, 11:00 PM
f58a82d3e113	4b5f744c4289	c13912d80e24	Eric Joyner	ixl(4): Configure promiscuous mode during driver init (Show More…)	Sep 13 2018, 10:51 PM
c13912d80e24	b34cf5691f9d	47cf66b0e3d2	Piotr Pietruszewski	ixlv(4): Disable queues before initialization. (Show More…)	Sep 13 2018, 5:51 PM
47cf66b0e3d2	3086a6f59055	93f634a309ff	Eric Joyner	ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists (Show More…)	Sep 4 2018, 11:23 PM
93f634a309ff	369040b20502	d330f8ced38a	Eric Joyner	ixlv(4): Update some debug printf()'s to use newer debug functions (Show More…)	Sep 4 2018, 11:23 PM
d330f8ced38a	7d3ba69d0db7	7ecf3956d373	Eric Joyner	ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses (Show More…)	Sep 4 2018, 11:20 PM
7ecf3956d373	31e61ce665af	801dd557923a	Eric Joyner	ixlv(4): Remove commented out code (Show More…)	Sep 4 2018, 11:13 PM
801dd557923a	0145fdc1a4e4	a5b86f9f0dcb	Eric Joyner	ixlv(4): Swap MALLOC_DEFINE/DECLARE statements (Show More…)	Sep 4 2018, 11:11 PM
a5b86f9f0dcb	9947df18e588	c5c699d949ed	Eric Joyner	ixl(4): Fix kernel panic during init() when Admin Queue is not alive (Show More…)	Aug 30 2018, 11:52 PM
c5c699d949ed	0893c0773d96	313b397404bf	Krzysztof Galazka	ixl/ixlv Missing semicolon in DWB fix (Show More…)	Aug 27 2018, 11:21 AM
313b397404bf	f5b4540b420a	2a2caa33c978	Eric Joyner	ixl(4): Fix memory leak when head writeback is disabled (Show More…)	Aug 23 2018, 9:15 PM
2a2caa33c978	3f69ad8a5ea5	fc2fbccaafb4	Krzysztof Galazka	ixl/ixlv(4): Fix TXD credits update for DWB mode (Show More…)	Aug 23 2018, 8:37 AM
fc2fbccaafb4	2de75a980985	653e2cf4624a	Eric Joyner	ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config… (Show More…)	Aug 22 2018, 12:41 AM
653e2cf4624a	af292e860318	8794d1f65028	Eric Joyner	ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue… (Show More…)	Aug 21 2018, 10:36 PM
8794d1f65028	b6970f5dd38d	882cb8a36883	Eric Joyner	ixl/ixlv(4): Add more MPASS statements to TX path (Show More…)	Aug 21 2018, 12:34 AM
882cb8a36883	c452141a6499	afe410f99613	Eric Joyner	ixl(4): Fix RX MDD event display (Show More…)	Aug 20 2018, 8:30 PM
afe410f99613	fffc80fd573d	c87cf1b4d434	Eric Joyner	ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path (Show More…)	Aug 16 2018, 11:38 PM
c87cf1b4d434	8cf9932452f8	b6c57206a492	Eric Joyner	ixl(4): Print out additional event information when a LAN Overflow Event occurs (Show More…)	Aug 16 2018, 11:37 PM
b6c57206a492	03245b2ebbbe	439d16052c96	Eric Joyner	ixl(4): Enhance Malicious Driver Detection messages with VF information (Show More…)	Aug 16 2018, 11:36 PM
439d16052c96	bedaefd1876b	68069dbe3818	Eric Joyner	ixlv(4): Remove list of media types displayed in "ifconfig -m" (Show More…)	Aug 13 2018, 11:45 PM
68069dbe3818	36aa3fe240e5	cf497e8cbf96	Eric Joyner	ixlv(4): Remove comments and commented out code (Show More…)	Aug 13 2018, 11:43 PM
cf497e8cbf96	6a97b30f938a	140016cff9d5	Eric Joyner	ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT (Show More…)	Aug 13 2018, 11:40 PM
140016cff9d5	cea4cca353b8	84baae1b5271	Eric Joyner	ixlv(4): Fix a memory leak when interrupt setup fails (Show More…)	Aug 13 2018, 11:03 PM
84baae1b5271	8f14f15b53b2	5ebf37de3c31	Eric Joyner	ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV (Show More…)	Aug 13 2018, 10:10 PM
5ebf37de3c31	965dfa7acefb	d3c64adb7701	Eric Joyner	ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic (Show More…)	Aug 10 2018, 5:27 PM
d3c64adb7701	6155ec08b54d	fba962d299db	Eric Joyner	ixl(4): Fix compile error when PCI_IOV isn't defined (Show More…)	Aug 9 2018, 10:17 PM
fba962d299db	55da69a0621a	ad665a0eb8de	Eric Joyner	ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing (Show More…)	Aug 9 2018, 6:23 PM
ad665a0eb8de	0e5635a7c25d	e985011460b6	Eric Joyner	ixl(4): Add tunable to enable VF loopback; enable by default (Show More…)	Aug 9 2018, 12:10 AM
e985011460b6	3f7903954a82	631e9686aa39	Eric Joyner	ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to… (Show More…)	Aug 3 2018, 6:27 PM
631e9686aa39	82229f20ae07	e50d48099faa	Eric Joyner	ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one… (Show More…)	Aug 2 2018, 8:41 PM
e50d48099faa	ef4b7c63eec2	38440b49c96e	Eric Joyner	ixl(4): Fix module Makefile when PCI_IOV is enabled (Show More…)	Jul 26 2018, 9:02 PM
38440b49c96e	4b180ae7fc5e	65f112ce217a	Eric Joyner	ixl/ixlv(4): Preserve code removal done in r336313 (Show More…)	Jul 25 2018, 7:54 PM
65f112ce217a	a8cdc3a0c059	04c132219646	Eric Joyner	ixlv(4): Use same TX DMA seg sizes as the ones in ixl(4) (Show More…)	Jul 25 2018, 7:50 PM
04c132219646	55272f72ee20	0ecea993cb9d	Eric Joyner	ixlv(4): Remove old/dead code (Show More…)	Jul 25 2018, 5:58 PM
0ecea993cb9d	d67ff071f48e	b256bb5dc5eb	Eric Joyner	ixl/ixlv(4): Fix module Makefiles (Show More…)	Jul 25 2018, 4:15 PM
b256bb5dc5eb	154a5e76186c	9bc3517f2568	Eric Joyner	ixlv(4): Re-add driver to GENERIC and build files (Show More…)	Jul 25 2018, 4:08 PM
9bc3517f2568	8e55bfda4e0d	d0d1d8e522af	Eric Joyner	ixlv(4): Fixup bad merge (Show More…)	Jul 24 2018, 7:17 AM
d0d1d8e522af	7f28c9eaf38b	95b11fad1a3c	Eric Joyner	ixlv(4): Convert some M_DEVBUF malloc types to M_IXLV (Show More…)	Jul 24 2018, 6:48 AM
95b11fad1a3c	aed8a3f62e46	b0ce3c86f404	Eric Joyner	ixlv(4): Check if ASQ is alive before sending message to PF (Show More…)	Jul 24 2018, 6:47 AM
b0ce3c86f404	9fbf06b28a7c	c4a98adec2f5	Eric Joyner	ixlv(4): Remove unused states and variables from ixlv.h (Show More…)	Jul 24 2018, 6:42 AM
c4a98adec2f5	c2634ab4d862	d6e3ed0b4e1f	Eric Joyner	ixl(4): Update debug.filter_list to print out VF filters (Show More…)	Jul 24 2018, 6:41 AM
d6e3ed0b4e1f	d24747aee92a	4674695f1239	Eric Joyner	ixl(4): Remove comments and unused sysctl (Show More…)	Jul 24 2018, 6:40 AM
4674695f1239	e220b28e2266	1fe88e506b14	Eric Joyner	ixl(4): Add debug print statements to filter add/delete functions (Show More…)	Jul 24 2018, 6:40 AM
1fe88e506b14	946ed5d7a29d	e83f626f6c01	Eric Joyner	ixl(4): Remove unnecessary MPASS() (Show More…)	Jul 24 2018, 6:39 AM
e83f626f6c01	585c1c46c294	1b5818a22015	Eric Joyner	ixl(4): Set IXL_FILTER_USED when adding a MAC filter (Show More…)	Jul 24 2018, 6:38 AM
1b5818a22015	c664afdba61e	bb3d3ad819cd	Eric Joyner	ixl(4): Remove unused sysctl (Show More…)	Jul 24 2018, 6:38 AM
bb3d3ad819cd	5c3ea3e6a3bf	b34827b7f59a	Eric Joyner	ixl(4): Admin queue interrupt fixes (and VFLR handling) (Show More…)	Jul 24 2018, 6:36 AM
b34827b7f59a	100ea0a41f2f	2744db0331a4	Eric Joyner	ixl(4): Update ixl_handle_vflr() for iflib (Show More…)	Jul 24 2018, 6:34 AM
2744db0331a4	2b61bec16fcc	b47ffbc63558	Eric Joyner	ixl(4): Make VFs use LRXQTHRESH value of 1, like PF (Show More…)	Jul 24 2018, 6:32 AM
b47ffbc63558	bd20cb4c67f4	ed23d60452f9	Eric Joyner	ixl(4): Re-add VF filters after VF reset (Show More…)	Jul 24 2018, 6:31 AM
ed23d60452f9	f0c3a1ad5088	825e965956d1	Eric Joyner	ixl(4): Add new debug mask flag and shortcut functions (Show More…)	Jul 24 2018, 6:29 AM
825e965956d1	210f10892220	a114050003c4	Eric Joyner	ixl(4): Remove unused variables in struct ixl_pf (Show More…)	Jul 24 2018, 6:27 AM
a114050003c4	38fa2984b8a2	4805cf52c150	Eric Joyner	ixlv(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:48 AM
4805cf52c150	920b072883e3	0fbfd9d9d5e1	Eric Joyner	ixlv(4): Fixes to admin queue interrupt handling (Show More…)	Jul 24 2018, 5:46 AM
0fbfd9d9d5e1	0c7be8b115b8	979bdc591412	Eric Joyner	ixlv(4): Re-enable PCI busmaster after reset (Show More…)	Jul 24 2018, 5:45 AM
979bdc591412	c1af74a922b8	169dbf284314	Eric Joyner	ixlv(4): Add missing line break at end of message (Show More…)	Jul 24 2018, 5:44 AM
169dbf284314	e847469a5c3a	26ab07aa5a18	Eric Joyner	ixlv(4): Configure multicast promiscuous when there are more multicast filters… (Show More…)	Jul 24 2018, 5:43 AM
26ab07aa5a18	fa1788c88623	7f5ddb63ca74	Eric Joyner	ixlv(4): Try to handle critical AQ errors better (Show More…)	Jul 24 2018, 5:42 AM
7f5ddb63ca74	d40a37fb834a	db370069c7d7	Eric Joyner	ixlv(4): Attempt to fix VFLR recovery (Show More…)	Jul 24 2018, 5:40 AM
db370069c7d7	4fc0f55763a9	d5bf988a26fe	Eric Joyner	ixlv(4): Fix TX initialization (Show More…)	Jul 24 2018, 5:38 AM
d5bf988a26fe	4b83ee06768f	b2f3753d63a2	Eric Joyner	ixlv(4): Add VF reset debug sysctls (Show More…)	Jul 24 2018, 5:36 AM
b2f3753d63a2	5a5c31bde41c	a1ba0223bbd7	Eric Joyner	ixl(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:29 AM
a1ba0223bbd7	95aec368c7e7	1dfae512e261	Eric Joyner	ixlv(4): Set a driver state for the VF at the end of attach (Show More…)	Jul 24 2018, 5:09 AM
1dfae512e261	4a724a8134b3	6d0d37c66d4b	Eric Joyner	ixlv(4): Don't set IFLIB_ADMIN_ALWAYS_RUN flag (Show More…)	Jul 24 2018, 5:07 AM
6d0d37c66d4b	c140c925fdcc	2b6270b63879	Eric Joyner	ixl(4): Make ixl_if_vflr_handle() call ixl_handle_vflr() (Show More…)	Jul 24 2018, 5:06 AM
2b6270b63879	203f717da298	d72eebca18c4	Eric Joyner	ixl(4): Setup softirq to handle VFLR interrupt task (Show More…)	Jul 24 2018, 5:06 AM
d72eebca18c4	506fcec3dd5c	bac727df869f	Eric Joyner	ixl(4): Remove old comment (Show More…)	Jul 24 2018, 5:05 AM
bac727df869f	0b1f0e7c8283	cacd3704b659	Eric Joyner	ixlv(4): Add VF reset request debug sysctl (Show More…)	Jul 14 2018, 12:21 AM
cacd3704b659	a129c6ed0640	ecd37fcb408e	Eric Joyner	ixlv(4): Convert VC msg functions to return an error on failure, instead of void (Show More…)	Jul 14 2018, 12:08 AM
ecd37fcb408e	6b8e7647b445	e30289286ac1	Eric Joyner	ixlv(4): Remove unnecessary #include (Show More…)	Jul 13 2018, 11:37 PM
e30289286ac1	7f5b5e211315	0e99d29e70b9	Eric Joyner	ixl/ixlv(4): Add per-queue stats to VF (Show More…)	Jul 13 2018, 11:05 PM
0e99d29e70b9	17c2d8b49a44	eb82b21aad59	Eric Joyner	ixl/ixlv(4): Add VSI stats sysctls to VF driver (Show More…)	Jul 13 2018, 7:35 PM
eb82b21aad59	b9e537502a76	0a713981e4ba	Eric Joyner	ixlv(4): Enable checking for critical AQ errors during AQ processing (Show More…)	Jul 13 2018, 6:42 PM
0a713981e4ba	ee04eba1661f	ba097396cd10	Eric Joyner	ixlv: Add debug sysctl to print out VF filter lists (Show More…)	Jul 12 2018, 5:12 PM
ba097396cd10	d957712a7b0f	7bab16342f2e	Eric Joyner	ixl/ixlv: Support for the VF configuring promiscuous mode (Show More…)	Jul 11 2018, 10:21 PM
7bab16342f2e	63a3b260a168	e6b902e6294e	Eric Joyner	ixl/ixlv: Remove README and commented out code	Jul 9 2018, 7:25 PM
e6b902e6294e	f24d20a01096	66866e8f4827	Eric Joyner	ixlv: Start reworking VF sysctls, change more debug statements to use new… (Show More…)	Jul 7 2018, 12:20 AM
66866e8f4827	ecbb011c2f8a	fd8e47ee3688	Eric Joyner	ixlv: Add core_debug_mask & shared_debug_mask sysctls and tunables (Show More…)	Jul 5 2018, 11:48 PM
fd8e47ee3688	20d81c035881	d75d5b9aea1f	Eric Joyner	ixl/ixlv: Re-comment printf (Show More…)	Jul 3 2018, 12:52 AM
d75d5b9aea1f	e4868fa08cbe	fb4c61de9f1a	Eric Joyner	ixl/ixlv: VF can ping! (Show More…)	Jul 3 2018, 12:48 AM
fb4c61de9f1a	5e2139cce275	40a83dd85bf5	Eric Joyner	ixlv: Fix compile error and memory leak (Show More…)	Jun 29 2018, 9:49 PM
40a83dd85bf5	fbb12719f144	6634d8bd936e	Eric Joyner	ixl/ixlv: Make a large number of small changes (Show More…)	Jun 29 2018, 9:45 PM
6634d8bd936e	d97db1cc70f4	e876e95cdc89	Eric Joyner	ixlv(4): Remove a couple empty lines (Show More…)	Jun 27 2018, 8:19 PM
e876e95cdc89	40f257c1fd75	52c781d0fafb	Eric Joyner	ixl(4): Reset created VF after it is setup (Show More…)	Jun 26 2018, 6:03 PM
52c781d0fafb	225e7e45ddd0	373d9ae4dac1	Eric Joyner	ixl/ixlv(4): Move ixl_aq_max_speed_to_value back into PF-only files from… (Show More…)	Jun 26 2018, 6:03 PM
373d9ae4dac1	22e0ca68a67f	017b838ae888	Eric Joyner	ixlv(4): Update comments and formatting (Show More…)	Jun 26 2018, 6:02 PM
017b838ae888	d2eb7717b1aa	ada9c9f3f099	Eric Joyner	ixlv(4): Remove commented out code (Show More…)	Jun 26 2018, 6:02 PM
ada9c9f3f099	06e3750b6a1f	d413445ccea6	Eric Joyner	ixlv(4): Assert that VC mgr is setup when ixl_if_init() begins (Show More…)	Jun 26 2018, 6:02 PM
d413445ccea6	a123bcb34e36	27f43316b3d8	Eric Joyner	ixlv(4): Update more functions to use ixlv_sc as interface softc (Show More…)	Jun 26 2018, 6:01 PM
27f43316b3d8	105855965654	9711e7643b0d	Eric Joyner	ixlv(4): Call ixl_vc_init_mgr() on attach (Show More…)	Jun 26 2018, 5:59 PM
9711e7643b0d	2481dbbe13be	b8312d2477aa	Eric Joyner	ixlv(4): Fix panic on failed attach (Show More…)	Jun 26 2018, 5:57 PM
b8312d2477aa	082019cc47bb	7645148854ec	Eric Joyner	ixl/ixlv(4): Stop setting legacy intr field in iflib txrx function pointer… (Show More…)	Jun 26 2018, 4:01 PM
7645148854ec	1698a057e1d2	58141b0c013f	Eric Joyner	ixlv(4): Remove some of the calls to ixl_vc_mgr code (Show More…)	Jun 26 2018, 12:36 AM
58141b0c013f	e174b2de86db	16657b70a565	Eric Joyner	ixlv(4): Change version string and device ID list to match ixl(4)'s (Show More…)	Jun 22 2018, 11:29 PM
16657b70a565	409d28ccf41c	dae7bc66bb0e	Eric Joyner	ixl(4): Fix up error message by adding a newline (Show More…)	Jun 19 2018, 5:57 PM
dae7bc66bb0e	17f5878e0b4e	3db47ff091e7	Eric Joyner	ixl(4): Fix kernel panic (Show More…)	May 24 2018, 11:07 PM
3db47ff091e7	e7ee2e8dee78	637e4d139ef3	Eric Joyner	ixl(4): Fix VF queue disable during reinit (Show More…)	May 24 2018, 10:39 PM
637e4d139ef3	eecfec6823e6	e5e5df046dd2	Eric Joyner	ixl(4): Remove unused variables	May 23 2018, 6:41 PM
e5e5df046dd2	308f8389483c	0306b111c924	Eric Joyner	ixl(4): Fix improper queue mapping during PF LAN VSI context setup (Show More…)	May 22 2018, 9:33 PM
0306b111c924	0bacade0a708	b6a18ffcf6c9	Eric Joyner	ixl(4): Change malloc type to M_NOWAIT (Show More…)	Jul 24 2018, 5:23 PM
b6a18ffcf6c9	aa7dbb97ee9c	568e322b09f2	Eric Joyner	ixl(4): Get device_t from pf struct instead of iflib (Show More…)	Jul 24 2018, 5:22 PM
568e322b09f2	9e1281ae11b0	a092949b1dd0	Eric Joyner	ixl(4): Remove pci_iov_detach() call from driver detach (Show More…)	Jul 24 2018, 5:06 PM
a092949b1dd0	f8c6c42d1d89	b8ec882e0785	Eric Joyner	ixl(4): Implement SR-IOV handlers for iflib (Show More…)	Jul 24 2018, 5:04 PM
b8ec882e0785	1c74f4131769	f86ddfdf0936	Eric Joyner	Revert "iflib: Free RX queue TCP LRO memory on unload" (Show More…)	Sep 20 2018, 5:36 PM
f86ddfdf0936	5ad4e05148cf	dd693cdcd8d2	Eric Joyner	iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock… (Show More…)	Aug 28 2018, 11:40 PM
dd693cdcd8d2	d19a1e252443	fd09c02e27b8	Eric Joyner	iflib: Destroy state lock at end of iflib_device_deregister() (Show More…)	Aug 28 2018, 11:16 PM
fd09c02e27b8	ef3507c94bda	ffb9f67b86dd	Eric Joyner	iflib: Free RX queue TCP LRO memory on unload (Show More…)	Aug 13 2018, 11:50 PM
ffb9f67b86dd	f5413cedcc5b	3e6e27f831bf	Eric Joyner	iflib: Free remaining interrupt resources on failure in iflib_device_register() (Show More…)	Aug 13 2018, 11:47 PM
3e6e27f831bf	101fa097db4b	6d998b491679	Eric Joyner	iflib: Add STATE_LOCK() around flag setting in iflib_request_reset() (Show More…)	Aug 9 2018, 6:28 PM
6d998b491679	83869c0c452e	6cd8ab3d09ec	Eric Joyner	iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach (Show More…)	Aug 9 2018, 6:11 PM
6cd8ab3d09ec	6c4f0823c03a	a2639d089d2a	Eric Joyner	iflib: Add public iflib_request_reset() for drivers to use (Show More…)	Jul 24 2018, 5:00 AM
a2639d089d2a	5911d8940979	c207076da792	Eric Joyner	iflib: Check IFLIB_ADMIN_ALWAYS_RUN flag in IOV task (Show More…)	Jul 24 2018, 4:59 AM
c207076da792	ac17ffc37d3c	749a505ec4a2	Eric Joyner	iflib: style fixes (Show More…)	Jun 26 2018, 4:03 PM
749a505ec4a2	c94fa935c226	c496f0616121	Eric Joyner	iflib: Call pci_iov_detach() during iflib_device_deregister() (Show More…)	May 22 2018, 9:26 PM