ixlv(4): Update to use iflib; change name to iavf(4)
ClosedPublic
Actions

Authored by erj on Jul 24 2018, 6:37 PM.

Details

Reviewers

sbruno
shurd
kbowling
gallatin
jeffrey.e.pieper_intel.com

Group Reviewers

Intel Networking

Commits

rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9)

Summary

(Summary forthcoming)

A list of git commits that are contained in this revision can be found here: https://github.com/freebsd/freebsd/compare/master...intel-wired-ethernet:ixl-iflib-sriov

Also includes changes to the PF driver (ixl(4)).

Includes the contents of D16428 already.

Test Plan

(To be filled out)

At least run the VF driver with an ixl(4) host bare metal and using bhyve, and a Linux (RHEL?) host using KVM.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19703
Build 19267: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

ixl(4): Fix module Makefile when PCI_IOV is enabled

Harbormaster completed remote builds in B18360: Diff 45891.Jul 26 2018, 9:08 PM

In general, I looked around at ixlv.c, and it looks like there are many functions for the main pf which are identical, or nearly identical for the VF. Can we please work on collapsing them down to common code?

sys/dev/ixl/ixl_pf_main.c
2363	I just hate that there are 2 functions which do almost the same thing. Can't you just change the args to ixl_disable_rings() to take pf and qtag and do this in a single function?
sys/dev/ixl/ixl_txrx.c
529	Errant space.

ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
Remove a space

Harbormaster completed remote builds in B18537: Diff 46214.Aug 2 2018, 8:47 PM

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it

Harbormaster completed remote builds in B18564: Diff 46257.Aug 3 2018, 6:33 PM

Changes from D16428:

iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

ixl(4): Add tunable to enable VF loopback; enable by default
ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing

Harbormaster completed remote builds in B18682: Diff 46482.Aug 9 2018, 6:40 PM

ixl(4): Fix compile error when PCI_IOV isn't defined

Harbormaster completed remote builds in B18688: Diff 46490.Aug 9 2018, 10:24 PM

gallatin accepted this revision.Aug 10 2018, 3:41 PM

This revision is now accepted and ready to land.Aug 10 2018, 3:41 PM

Several outstanding issues:

System back trace while running netperf tcp_rr test with jumbo frames enabled:

Fatal trap 12: page fault while in kernel mode
cpuid = 0; apic id = 00
fault virtual address = 0x1af0000
fault code = supervisor read data, page not present
instruction pointer = 0x20:0xffffffff80bdeb4f
stack pointer = 0x28:0xfffffe0025eeccb0
frame pointer = 0x28:0xfffffe0025eeccc0
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 12 (swi4: clock (0))
[ thread pid 12 tid 100034 ]
Stopped at m_tag_delete_chain+0x1f: movq (%rsi),%rdi
db> bt
Tracing pid 12 tid 100034 td 0xfffff800032c4580
m_tag_delete_chain() at m_tag_delete_chain+0x1f/frame 0xfffffe0025eeccc0
uma_zfree_arg() at uma_zfree_arg+0x3e/frame 0xfffffe0025eecd20
m_freem() at m_freem+0x9a/frame 0xfffffe0025eecd40
vtnet_txq_eof() at vtnet_txq_eof+0x75/frame 0xfffffe0025eecd70
vtnet_txq_mq_start_locked() at vtnet_txq_mq_start_locked+0x65/frame 0xfffffe0025eecdd0
vtnet_txq_mq_start() at vtnet_txq_mq_start+0x68/frame 0xfffffe0025eece10
ether_output_frame() at ether_output_frame+0xaa/frame 0xfffffe0025eece40
ether_output() at ether_output+0x6b7/frame 0xfffffe0025eecee0
ip_output() at ip_output+0x13e6/frame 0xfffffe0025eed020
tcp_output() at tcp_output+0x1b0c/frame 0xfffffe0025eed1b0
tcp_timer_delack() at tcp_timer_delack+0xf4/frame 0xfffffe0025eed1f0
softclock_call_cc() at softclock_call_cc+0x12e/frame 0xfffffe0025eed2a0
softclock() at softclock+0x79/frame 0xfffffe0025eed2c0
ithread_loop() at ithread_loop+0x1a7/frame 0xfffffe0025eed330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025eed370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025eed370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

Fatal trap 9: general protection fault while in kernel mode
cpuid = 1; apic id = 01
instruction pointer = 0x20:0xffffffff82d70048
stack pointer = 0x28:0xfffffe0025ec5150
frame pointer = 0x28:0xfffffe0025ec5180
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 0 (if_io_tqg_1)
[ thread pid 0 tid 100026 ]
Stopped at ixl_isc_rxd_pkt_get+0xc8: cmpl ll+0x1b(%rax),%esi
db> bt
Tracing pid 0 tid 100026 td 0xfffff800032ad580
ixl_isc_rxd_pkt_get() at ixl_isc_rxd_pkt_get+0xc8/frame 0xfffffe0025ec5180
iflib_rxeof() at iflib_rxeof+0x136/frame 0xfffffe0025ec5260
_task_fn_rx() at _task_fn_rx+0x76/frame 0xfffffe0025ec52a0
gtaskqueue_run_locked() at gtaskqueue_run_locked+0x144/frame 0xfffffe0025ec5300
gtaskqueue_thread_loop() at gtaskqueue_thread_loop+0x98/frame 0xfffffe0025ec5330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025ec5370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025ec5370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

It is possible to work around the issue by increasing the value of the rx_budget counter to the current value of the number of queues (44):
sysctl dev.ixl.0.iflib.rx_budget=44

Unable to initialize over 63 VF's:

Aug 10 14:48:56 u1017 kernel: ixl3: 0x400000 bytes of rid 0x184 res 3 failed (0, 0xffffffffffffffff).

Memory leak reported when unloading if_ixlv with 64 VF’s spawned:

Aug 10 14:51:18 u1017 kernel: ixlv62: Using MSIX interrupts with 5 vectors
Aug 10 14:51:18 u1017 kernel: ixlv62: Ethernet address: e2:db:49:42:7a:85
Aug 10 14:51:18 u1017 kernel: ixlv62: netmap queues/slots: TX 4/1024, RX 4/1024
Aug 10 14:51:18 u1017 kernel: ixlv63: <Intel(R) Ethernet Virtual Function 700 Series (X722)> at device 0.79 on pci13
Aug 10 14:51:18 u1017 kernel: ixlv62: link state changed to UP
Aug 10 14:51:18 u1017 kernel: ixlv63: PF API 1.1 / VF API 1.1
Aug 10 14:51:18 u1017 kernel: ixlv63: VSIs 1, QPs 4, MSIX 5, RSS sizes: key 52 lut 64
Aug 10 14:51:18 u1017 kernel: ixlv63: using 1024 tx descriptors and 1024 rx descriptors
Aug 10 14:51:18 u1017 kernel: ixlv63: msix_init qsets capped at 4
Aug 10 14:51:18 u1017 kernel: ixlv63: pxm cpus: 36 queue msgs: 4 admincnt: 1
Aug 10 14:51:18 u1017 kernel: ixlv63: using 4 rx queues 4 tx queues
Aug 10 14:51:18 u1017 kernel: ixlv63: Using MSIX interrupts with 4 vectors
Aug 10 14:51:18 u1017 kernel: ixlv63: failed to allocate IRQ for rid 5, name rxq3.
Aug 10 14:51:18 u1017 kernel: ixlv63: _iflib_irq_alloc failed 12
Aug 10 14:51:18 u1017 kernel: ixlv63: Failed to allocate queue RX int vector 3, err: 12
Aug 10 14:51:18 u1017 kernel: ixlv63: IFDI_MSIX_INTR_ASSIGN failed 12
Aug 10 14:51:18 u1017 kernel: device_attach: ixlv63 attach returned 12
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked MSI vectors
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked memory resources

After kldunload:

Aug 10 15:00:18 u1017 kernel: ixlv62: detached
Aug 10 15:00:18 u1017 kernel: pci13: <network, ethernet> at device 0.78 (no driver attached)
Aug 10 15:00:18 u1017 kernel: Warning: memory type ixlv leaked memory on destroy (4 allocations, 8192 bytes leaked).

This revision now requires changes to proceed.Aug 10 2018, 4:20 PM

ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic

Harbormaster completed remote builds in B18703: Diff 46521.Aug 10 2018, 5:37 PM

ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
ixlv(4): Fix a memory leak when interrupt setup fails
ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
ixlv(4): Remove comments and commented out code
ixlv(4): Remove list of media types displayed in "ifconfig -m"

Harbormaster completed remote builds in B18780: Diff 46642.Aug 14 2018, 12:03 AM

ixl(4): Enhance Malicious Driver Detection messages with VF information
ixl(4): Print out additional event information when a LAN Overflow Event occurs
ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path

Harbormaster completed remote builds in B18879: Diff 46809.Aug 16 2018, 11:45 PM

gallatin added inline comments.Aug 17 2018, 7:34 PM

sys/dev/ixl/if_ixl.c
1205	Please consider limiting this to a few prints. Otherwise, I anticipate this spamming the console / messages log at some point for somebody.
sys/dev/ixl/ixl_pf_main.c
2463	Nice! This would have been helpful during bringup of the iflib driver, but better late than never :)
sys/dev/ixl/ixl_txrx.c
384	0 is a perfectly valid DMA address on non-x86, or on x86 when using IOMMUs

ixl(4): Fix RX MDD event display
ixl/ixlv(4): Add more MPASS statements to TX path

Harbormaster completed remote builds in B18994: Diff 47009.Aug 21 2018, 12:42 AM

ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message

Harbormaster completed remote builds in B19027: Diff 47074.Aug 22 2018, 12:48 AM

ixl/ixlv(4): Fix TXD credits update for DWB mode

Harbormaster completed remote builds in B19111: Diff 47190.Aug 23 2018, 5:56 PM

ixl(4): Fix memory leak when head writeback is disabled

Harbormaster completed remote builds in B19117: Diff 47209.Aug 23 2018, 9:22 PM

ixl/ixlv Missing semicolon in DWB fix

Harbormaster completed remote builds in B19214: Diff 47347.Aug 27 2018, 3:43 PM

iflib: Destroy state lock at end of iflib_device_deregister()
iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
ixl(4): Fix kernel panic during init() when Admin Queue is not alive

Harbormaster completed remote builds in B19307: Diff 47509.Aug 31 2018, 12:01 AM

ixlv(4): Swap MALLOC_DEFINE/DECLARE statements
ixlv(4): Remove commented out code
ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses
ixlv(4): Update some debug printf()'s to use newer debug functions
ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists

Harbormaster completed remote builds in B19398: Diff 47671.Sep 4 2018, 11:33 PM

ixlv(4): Disable queues before initialization.

Harbormaster completed remote builds in B19573: Diff 48012.Sep 13 2018, 6:00 PM

ixl(4): Configure promiscuous mode during driver init

Harbormaster completed remote builds in B19583: Diff 48025.Sep 13 2018, 11:00 PM

ixl(4): Fix compile error introduced by previous commit

Harbormaster completed remote builds in B19585: Diff 48027.Sep 13 2018, 11:10 PM

ixl(4): Fix filter handling when SR-IOV is enabled
Revert "iflib: Free RX queue TCP LRO memory on unload"

Harbormaster completed remote builds in B19703: Diff 48274.Sep 20 2018, 5:40 PM

ixlv(4): Update driver version to 2.0.0-k
ixlv(4): Remove dynamic ITR code, since it's unused
ixlv(4): Set max number of queues used in iflib based on number VF receives from PF
ixlv(4): Code cleanup
ixlv(4): Don't sleep for a response to a VC msg if driver is in detach
ixl(4): Clear VF qtag queue flags when VF is being reinitialized
ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for completion
ixlv(4): Modify debug prints, and stop printing out "Queue already enabled" warnings
ixl(4): Update version number to 2.1.0-k

Harbormaster completed remote builds in B19831: Diff 48493.Sep 27 2018, 12:56 AM

erj mentioned this in D15927: Update ixl(4) and ixlv(4) man pages.Oct 2 2018, 3:54 PM

Rebased onto latest master, and added:

ixl(4): Reconfigure MAC/VLAN filters after adding VEB during SR-IOV init

Harbormaster completed remote builds in B19934: Diff 48688.Oct 3 2018, 8:10 PM

Ugh, rebasing changes the commit SHAs :(

I guess it's the price you pay for the appearance of cleanliness...

krzysztof.galazka_intel.com mentioned this in D17404: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 4 2018, 12:32 PM

ixlv/iavf(4): Change "ixlv" driver name to "iavf"

Harbormaster completed remote builds in B19990: Diff 48761.Oct 4 2018, 10:29 PM

erj retitled this revision from ixlv(4): Update to use iflib to ixlv(4): Update to use iflib; change name to iavf(4).Oct 4 2018, 10:31 PM

iavf(4): Move modules/Makefile entry so that it's in alphabetical order
iavf(4): Update MODULE_* macros with new "iavf" name

Harbormaster completed remote builds in B20010: Diff 48795.Oct 5 2018, 6:52 PM

erj added a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 5 2018, 8:21 PM

erj added a child revision: D15927: Update ixl(4) and ixlv(4) man pages.

Can you rename the sys/dev/ixl dir to iavf as part of this? I'd really like to see this change done now in 12.0, it would be very awkward to try and MFC later.

Sorry the first part of my comment made no sense, ixl is the pf and will remain for 25/40g hw parts.

jeffrey.e.pieper_intel.com accepted this revision.Oct 11 2018, 8:14 PM

This revision is now accepted and ready to land.Oct 11 2018, 8:14 PM

sbruno accepted this revision.Oct 11 2018, 10:48 PM

Any last-minute assents or objections?

kbowling accepted this revision.Oct 12 2018, 5:55 AM

erj removed a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 12 2018, 5:28 PM

Closed by commit rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9) (authored by erj). · Explain WhyOct 12 2018, 10:41 PM

This revision was automatically updated to reflect the committed changes.

erj mentioned this in rS339634: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 23 2018, 4:37 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

GENERIC

2 lines

NOTES

2 lines

conf/

files.amd64

8 lines

dev/

ixl/

34 lines

214 lines

2807 lines

38 lines

23 lines

38 lines

12 lines

185 lines

548 lines

15 lines

2 lines

249 lines

148 lines

614 lines

modules/

Makefile

1 line

ixl/

Makefile

10 lines

ixlv/

Makefile

4 lines

net/

iflib.h

4 lines

iflib.c

124 lines

iflib_private.h

1 line

Commit	Tree	Parents	Author	Summary	Date
93b0b316d737	12c0ad3fc255	a25dbb0db587	Eric Joyner	Revert "iflib: Free RX queue TCP LRO memory on unload" (Show More…)	Sep 20 2018, 5:36 PM
a25dbb0db587	59d074be26f4	7ab983a6bcc0	Krzysztof Galazka	ixl(4): Fix filter handling when SR-IOV is enabled (Show More…)	Sep 20 2018, 3:38 PM
7ab983a6bcc0	22738000647e	c46a65b57ac6	Eric Joyner	ixl(4): Fix compile error introduced by previous commit (Show More…)	Sep 13 2018, 11:00 PM
c46a65b57ac6	b644aeb2cc85	f5ce5d41c516	Eric Joyner	ixl(4): Configure promiscuous mode during driver init (Show More…)	Sep 13 2018, 10:51 PM
f5ce5d41c516	b6486ac60f80	987be44c016d	Piotr Pietruszewski	ixlv(4): Disable queues before initialization. (Show More…)	Sep 13 2018, 5:51 PM
987be44c016d	61bc5c17b8e7	37e17d33df2e	Eric Joyner	ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists (Show More…)	Sep 4 2018, 11:23 PM
37e17d33df2e	3c3395df7eb9	e3349220cd23	Eric Joyner	ixlv(4): Update some debug printf()'s to use newer debug functions (Show More…)	Sep 4 2018, 11:23 PM
e3349220cd23	16137132b432	98cff4fdf8cf	Eric Joyner	ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses (Show More…)	Sep 4 2018, 11:20 PM
98cff4fdf8cf	3e2fe09e8eef	61499a40fcf6	Eric Joyner	ixlv(4): Remove commented out code (Show More…)	Sep 4 2018, 11:13 PM
61499a40fcf6	7685767af33a	5c9c4138a0fa	Eric Joyner	ixlv(4): Swap MALLOC_DEFINE/DECLARE statements (Show More…)	Sep 4 2018, 11:11 PM
5c9c4138a0fa	b07accbfb385	b994b7f2e75d	Eric Joyner	ixl(4): Fix kernel panic during init() when Admin Queue is not alive (Show More…)	Aug 30 2018, 11:52 PM
b994b7f2e75d	6b5325afd1e6	5b25f8205aa0	Krzysztof Galazka	ixl/ixlv Missing semicolon in DWB fix (Show More…)	Aug 27 2018, 11:21 AM
5b25f8205aa0	49099d9efb88	c9f3855d9c18	Eric Joyner	ixl(4): Fix memory leak when head writeback is disabled (Show More…)	Aug 23 2018, 9:15 PM
c9f3855d9c18	9235c211643a	581640006da3	Krzysztof Galazka	ixl/ixlv(4): Fix TXD credits update for DWB mode (Show More…)	Aug 23 2018, 8:37 AM
581640006da3	57331115e638	1446b6bbe860	Eric Joyner	ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config… (Show More…)	Aug 22 2018, 12:41 AM
1446b6bbe860	0b79cf8e9436	50e8195926d1	Eric Joyner	ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue… (Show More…)	Aug 21 2018, 10:36 PM
50e8195926d1	e1caddc59d94	a00d058c2db7	Eric Joyner	ixl/ixlv(4): Add more MPASS statements to TX path (Show More…)	Aug 21 2018, 12:34 AM
a00d058c2db7	f801997bd30e	b5187a5d86b4	Eric Joyner	ixl(4): Fix RX MDD event display (Show More…)	Aug 20 2018, 8:30 PM
b5187a5d86b4	93cfbdb34516	0be2e374b018	Eric Joyner	ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path (Show More…)	Aug 16 2018, 11:38 PM
0be2e374b018	21784735bb90	89c50c46387d	Eric Joyner	ixl(4): Print out additional event information when a LAN Overflow Event occurs (Show More…)	Aug 16 2018, 11:37 PM
89c50c46387d	528852326f4e	2212dc3231dd	Eric Joyner	ixl(4): Enhance Malicious Driver Detection messages with VF information (Show More…)	Aug 16 2018, 11:36 PM
2212dc3231dd	3db5bf549199	4894a85a5f98	Eric Joyner	ixlv(4): Remove list of media types displayed in "ifconfig -m" (Show More…)	Aug 13 2018, 11:45 PM
4894a85a5f98	f089c4ee1272	15ebf04aa594	Eric Joyner	ixlv(4): Remove comments and commented out code (Show More…)	Aug 13 2018, 11:43 PM
15ebf04aa594	73eb8adfcdf0	a11cc1e16a05	Eric Joyner	ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT (Show More…)	Aug 13 2018, 11:40 PM
a11cc1e16a05	9b97a9074c7c	631a63520c65	Eric Joyner	ixlv(4): Fix a memory leak when interrupt setup fails (Show More…)	Aug 13 2018, 11:03 PM
631a63520c65	7cfe05b4b375	26a8ba0c427a	Eric Joyner	ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV (Show More…)	Aug 13 2018, 10:10 PM
26a8ba0c427a	f673a870a2b4	15447d3ded80	Eric Joyner	ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic (Show More…)	Aug 10 2018, 5:27 PM
15447d3ded80	49ab6f49664c	b265e00486d6	Eric Joyner	ixl(4): Fix compile error when PCI_IOV isn't defined (Show More…)	Aug 9 2018, 10:17 PM
b265e00486d6	8ef09de861f7	a3c51d8efc96	Eric Joyner	ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing (Show More…)	Aug 9 2018, 6:23 PM
a3c51d8efc96	4a346abda13e	b11ee6e9431c	Eric Joyner	ixl(4): Add tunable to enable VF loopback; enable by default (Show More…)	Aug 9 2018, 12:10 AM
b11ee6e9431c	a85fe4f67c1a	07fb64edf542	Eric Joyner	ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to… (Show More…)	Aug 3 2018, 6:27 PM
07fb64edf542	6a003d54632f	f3f122eb4dd5	Eric Joyner	ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one… (Show More…)	Aug 2 2018, 8:41 PM
f3f122eb4dd5	45be9615826f	f9cd96b43317	Eric Joyner	ixl(4): Fix module Makefile when PCI_IOV is enabled (Show More…)	Jul 26 2018, 9:02 PM
f9cd96b43317	e91aab9935df	29e37b0b9022	Eric Joyner	ixl/ixlv(4): Preserve code removal done in r336313 (Show More…)	Jul 25 2018, 7:54 PM
29e37b0b9022	f1db769e7e21	88dccdb2a505	Eric Joyner	ixlv(4): Use same TX DMA seg sizes as the ones in ixl(4) (Show More…)	Jul 25 2018, 7:50 PM
88dccdb2a505	f6d0578d9e40	c0d8cdb172b1	Eric Joyner	ixlv(4): Remove old/dead code (Show More…)	Jul 25 2018, 5:58 PM
c0d8cdb172b1	1f516eda626b	59b6a8a194a8	Eric Joyner	ixl/ixlv(4): Fix module Makefiles (Show More…)	Jul 25 2018, 4:15 PM
59b6a8a194a8	ce1aad4ee1df	f5b771f9ffe8	Eric Joyner	ixlv(4): Re-add driver to GENERIC and build files (Show More…)	Jul 25 2018, 4:08 PM
f5b771f9ffe8	5aeffe4b16f2	e762be6e9f35	Eric Joyner	ixlv(4): Fixup bad merge (Show More…)	Jul 24 2018, 7:17 AM
e762be6e9f35	4ebd5e78a4df	236a5291f9dd	Eric Joyner	ixlv(4): Convert some M_DEVBUF malloc types to M_IXLV (Show More…)	Jul 24 2018, 6:48 AM
236a5291f9dd	7e007e043081	901a0c66d80c	Eric Joyner	ixlv(4): Check if ASQ is alive before sending message to PF (Show More…)	Jul 24 2018, 6:47 AM
901a0c66d80c	eb3947183a4c	2981b6480851	Eric Joyner	ixlv(4): Remove unused states and variables from ixlv.h (Show More…)	Jul 24 2018, 6:42 AM
2981b6480851	13c5764a8c06	43de2ab1ccc6	Eric Joyner	ixl(4): Update debug.filter_list to print out VF filters (Show More…)	Jul 24 2018, 6:41 AM
43de2ab1ccc6	208a17b63fbd	eec699f2d5cf	Eric Joyner	ixl(4): Remove comments and unused sysctl (Show More…)	Jul 24 2018, 6:40 AM
eec699f2d5cf	1ce85022027e	27a239f874b0	Eric Joyner	ixl(4): Add debug print statements to filter add/delete functions (Show More…)	Jul 24 2018, 6:40 AM
27a239f874b0	a175a2c5328e	f7097c434f76	Eric Joyner	ixl(4): Remove unnecessary MPASS() (Show More…)	Jul 24 2018, 6:39 AM
f7097c434f76	6ee6c85dc80b	6561850cb0db	Eric Joyner	ixl(4): Set IXL_FILTER_USED when adding a MAC filter (Show More…)	Jul 24 2018, 6:38 AM
6561850cb0db	2ffec0ab7b38	bf37e26c0078	Eric Joyner	ixl(4): Remove unused sysctl (Show More…)	Jul 24 2018, 6:38 AM
bf37e26c0078	a0c059e4be01	fa3e95ee8a3b	Eric Joyner	ixl(4): Admin queue interrupt fixes (and VFLR handling) (Show More…)	Jul 24 2018, 6:36 AM
fa3e95ee8a3b	be0189136fcc	b8d5aeb68d43	Eric Joyner	ixl(4): Update ixl_handle_vflr() for iflib (Show More…)	Jul 24 2018, 6:34 AM
b8d5aeb68d43	575134cd2170	5b5418193e18	Eric Joyner	ixl(4): Make VFs use LRXQTHRESH value of 1, like PF (Show More…)	Jul 24 2018, 6:32 AM
5b5418193e18	b728ec6c9b8e	88276eb59c58	Eric Joyner	ixl(4): Re-add VF filters after VF reset (Show More…)	Jul 24 2018, 6:31 AM
88276eb59c58	0e8e811a12d6	6a6eb5852040	Eric Joyner	ixl(4): Add new debug mask flag and shortcut functions (Show More…)	Jul 24 2018, 6:29 AM
6a6eb5852040	898ec20ce2d3	af1c06a05bef	Eric Joyner	ixl(4): Remove unused variables in struct ixl_pf (Show More…)	Jul 24 2018, 6:27 AM
af1c06a05bef	b7f80fb8c602	b31aeb59cf00	Eric Joyner	ixlv(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:48 AM
b31aeb59cf00	3063f7f076eb	c25dfca10ca5	Eric Joyner	ixlv(4): Fixes to admin queue interrupt handling (Show More…)	Jul 24 2018, 5:46 AM
c25dfca10ca5	e006bf996058	517cf5672454	Eric Joyner	ixlv(4): Re-enable PCI busmaster after reset (Show More…)	Jul 24 2018, 5:45 AM
517cf5672454	5d9addabff5d	dd232d39921b	Eric Joyner	ixlv(4): Add missing line break at end of message (Show More…)	Jul 24 2018, 5:44 AM
dd232d39921b	eaa877ccc3b4	a53c5410cd38	Eric Joyner	ixlv(4): Configure multicast promiscuous when there are more multicast filters… (Show More…)	Jul 24 2018, 5:43 AM
a53c5410cd38	3db4ec366e66	533ca4fc6e4d	Eric Joyner	ixlv(4): Try to handle critical AQ errors better (Show More…)	Jul 24 2018, 5:42 AM
533ca4fc6e4d	a3b6333d9c3f	32090c5f125b	Eric Joyner	ixlv(4): Attempt to fix VFLR recovery (Show More…)	Jul 24 2018, 5:40 AM
32090c5f125b	ea50afc1603b	a1b871af6b82	Eric Joyner	ixlv(4): Fix TX initialization (Show More…)	Jul 24 2018, 5:38 AM
a1b871af6b82	80d0a34ea64c	5209ebe5213b	Eric Joyner	ixlv(4): Add VF reset debug sysctls (Show More…)	Jul 24 2018, 5:36 AM
5209ebe5213b	26f4169918d0	4cde4931f479	Eric Joyner	ixl(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:29 AM
4cde4931f479	a844d8ef7ed5	ca37900cfb4c	Eric Joyner	ixlv(4): Set a driver state for the VF at the end of attach (Show More…)	Jul 24 2018, 5:09 AM
ca37900cfb4c	b897a830b46f	2c9acce5dd87	Eric Joyner	ixlv(4): Don't set IFLIB_ADMIN_ALWAYS_RUN flag (Show More…)	Jul 24 2018, 5:07 AM
2c9acce5dd87	b9a2775d239f	9753b5013dc4	Eric Joyner	ixl(4): Make ixl_if_vflr_handle() call ixl_handle_vflr() (Show More…)	Jul 24 2018, 5:06 AM
9753b5013dc4	13a0fb34b924	b1ab47cecf0f	Eric Joyner	ixl(4): Setup softirq to handle VFLR interrupt task (Show More…)	Jul 24 2018, 5:06 AM
b1ab47cecf0f	68d0e95018fa	7463b638ae30	Eric Joyner	ixl(4): Remove old comment (Show More…)	Jul 24 2018, 5:05 AM
7463b638ae30	faab17825eb1	25728f0314c2	Eric Joyner	ixlv(4): Add VF reset request debug sysctl (Show More…)	Jul 14 2018, 12:21 AM
25728f0314c2	f3868e0e5d1e	17c36a4c46ac	Eric Joyner	ixlv(4): Convert VC msg functions to return an error on failure, instead of void (Show More…)	Jul 14 2018, 12:08 AM
17c36a4c46ac	551966bbf3ff	8099b829601d	Eric Joyner	ixlv(4): Remove unnecessary #include (Show More…)	Jul 13 2018, 11:37 PM
8099b829601d	48fe7719d8d6	3cab53f57c9c	Eric Joyner	ixl/ixlv(4): Add per-queue stats to VF (Show More…)	Jul 13 2018, 11:05 PM
3cab53f57c9c	8af43a4ebf10	94df44e1bbd5	Eric Joyner	ixl/ixlv(4): Add VSI stats sysctls to VF driver (Show More…)	Jul 13 2018, 7:35 PM
94df44e1bbd5	2db0a022c7ad	8ba88fedb361	Eric Joyner	ixlv(4): Enable checking for critical AQ errors during AQ processing (Show More…)	Jul 13 2018, 6:42 PM
8ba88fedb361	7aaebde3d238	e470d6491ac1	Eric Joyner	ixlv: Add debug sysctl to print out VF filter lists (Show More…)	Jul 12 2018, 5:12 PM
e470d6491ac1	d4eb61458d88	48be5f8e2693	Eric Joyner	ixl/ixlv: Support for the VF configuring promiscuous mode (Show More…)	Jul 11 2018, 10:21 PM
48be5f8e2693	6e2525dda8f2	0e222ddfb1b4	Eric Joyner	ixl/ixlv: Remove README and commented out code	Jul 9 2018, 7:25 PM
0e222ddfb1b4	222f3b86bb8c	c6975b7a7714	Eric Joyner	ixlv: Start reworking VF sysctls, change more debug statements to use new… (Show More…)	Jul 7 2018, 12:20 AM
c6975b7a7714	e3a995d020a8	5632bebb4270	Eric Joyner	ixlv: Add core_debug_mask & shared_debug_mask sysctls and tunables (Show More…)	Jul 5 2018, 11:48 PM
5632bebb4270	27ada3194965	a36cbf565c42	Eric Joyner	ixl/ixlv: Re-comment printf (Show More…)	Jul 3 2018, 12:52 AM
a36cbf565c42	47c287d04b7a	79cc9bdcb393	Eric Joyner	ixl/ixlv: VF can ping! (Show More…)	Jul 3 2018, 12:48 AM
79cc9bdcb393	ce2b77dfab1a	69b31de42f25	Eric Joyner	ixlv: Fix compile error and memory leak (Show More…)	Jun 29 2018, 9:49 PM
69b31de42f25	4c437c896250	eb02cd855c01	Eric Joyner	ixl/ixlv: Make a large number of small changes (Show More…)	Jun 29 2018, 9:45 PM
eb02cd855c01	759e1ae2becd	e08fc630157e	Eric Joyner	ixlv(4): Remove a couple empty lines (Show More…)	Jun 27 2018, 8:19 PM
e08fc630157e	c98189546dc9	96555502ca15	Eric Joyner	ixl(4): Reset created VF after it is setup (Show More…)	Jun 26 2018, 6:03 PM
96555502ca15	707dff199d01	6d9e621de6ca	Eric Joyner	ixl/ixlv(4): Move ixl_aq_max_speed_to_value back into PF-only files from… (Show More…)	Jun 26 2018, 6:03 PM
6d9e621de6ca	a472450312c0	31f47f42bab3	Eric Joyner	ixlv(4): Update comments and formatting (Show More…)	Jun 26 2018, 6:02 PM
31f47f42bab3	bc922aa414fd	2acb5ba76dd5	Eric Joyner	ixlv(4): Remove commented out code (Show More…)	Jun 26 2018, 6:02 PM
2acb5ba76dd5	da9229c8ec0e	19f405f9c4ee	Eric Joyner	ixlv(4): Assert that VC mgr is setup when ixl_if_init() begins (Show More…)	Jun 26 2018, 6:02 PM
19f405f9c4ee	85dd0aba9fad	100d99da1fdc	Eric Joyner	ixlv(4): Update more functions to use ixlv_sc as interface softc (Show More…)	Jun 26 2018, 6:01 PM
100d99da1fdc	dbe751d95560	340aaee07a4c	Eric Joyner	ixlv(4): Call ixl_vc_init_mgr() on attach (Show More…)	Jun 26 2018, 5:59 PM
340aaee07a4c	fb5f4297ed07	642d5f2d31be	Eric Joyner	ixlv(4): Fix panic on failed attach (Show More…)	Jun 26 2018, 5:57 PM
642d5f2d31be	96fe3f3960b6	a18d9c2f2df5	Eric Joyner	ixl/ixlv(4): Stop setting legacy intr field in iflib txrx function pointer… (Show More…)	Jun 26 2018, 4:01 PM
a18d9c2f2df5	4547eaa2bc44	e263d8840c45	Eric Joyner	ixlv(4): Remove some of the calls to ixl_vc_mgr code (Show More…)	Jun 26 2018, 12:36 AM
e263d8840c45	68137c0d4b8d	896eb87f9eed	Eric Joyner	ixlv(4): Change version string and device ID list to match ixl(4)'s (Show More…)	Jun 22 2018, 11:29 PM
896eb87f9eed	56cd2591e9be	780e16fa7eff	Eric Joyner	ixl(4): Fix up error message by adding a newline (Show More…)	Jun 19 2018, 5:57 PM
780e16fa7eff	143c10e57ce8	70ea187e2e7a	Eric Joyner	ixl(4): Fix kernel panic (Show More…)	May 24 2018, 11:07 PM
70ea187e2e7a	bc695af00918	ce6f0b8c86d6	Eric Joyner	ixl(4): Fix VF queue disable during reinit (Show More…)	May 24 2018, 10:39 PM
ce6f0b8c86d6	d88a68cc6dcf	bc4c3a7f3864	Eric Joyner	ixl(4): Remove unused variables	May 23 2018, 6:41 PM
bc4c3a7f3864	0bafc77cf964	b65d861088cd	Eric Joyner	ixl(4): Fix improper queue mapping during PF LAN VSI context setup (Show More…)	May 22 2018, 9:33 PM
b65d861088cd	362a5af0ce0a	d1d90b81f4e0	Eric Joyner	ixl(4): Change malloc type to M_NOWAIT (Show More…)	Jul 24 2018, 5:23 PM
d1d90b81f4e0	e081a0a15657	ae1990dfe34d	Eric Joyner	ixl(4): Get device_t from pf struct instead of iflib (Show More…)	Jul 24 2018, 5:22 PM
ae1990dfe34d	77106b150d45	45bf84426495	Eric Joyner	ixl(4): Remove pci_iov_detach() call from driver detach (Show More…)	Jul 24 2018, 5:06 PM
45bf84426495	86533252f848	d730099d2d27	Eric Joyner	ixl(4): Implement SR-IOV handlers for iflib (Show More…)	Jul 24 2018, 5:04 PM
d730099d2d27	c667551e8c44	1f6dd93fb2bb	Eric Joyner	iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock… (Show More…)	Aug 28 2018, 11:40 PM
1f6dd93fb2bb	8390d8a224bd	99fa936a8d72	Eric Joyner	iflib: Destroy state lock at end of iflib_device_deregister() (Show More…)	Aug 28 2018, 11:16 PM
99fa936a8d72	5c9a49388326	48f4569f283e	Eric Joyner	iflib: Free RX queue TCP LRO memory on unload (Show More…)	Aug 13 2018, 11:50 PM
48f4569f283e	b8a535922b26	a9dda426fbf9	Eric Joyner	iflib: Free remaining interrupt resources on failure in iflib_device_register() (Show More…)	Aug 13 2018, 11:47 PM
a9dda426fbf9	440e4bb9d1a1	a13360a25edf	Eric Joyner	iflib: Add STATE_LOCK() around flag setting in iflib_request_reset() (Show More…)	Aug 9 2018, 6:28 PM
a13360a25edf	3506df4b45dd	33a6623f6808	Eric Joyner	iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach (Show More…)	Aug 9 2018, 6:11 PM
33a6623f6808	f03da3a229d7	337fec693714	Eric Joyner	iflib: Add public iflib_request_reset() for drivers to use (Show More…)	Jul 24 2018, 5:00 AM
337fec693714	ae16ae1feafa	852bd8ab636f	Eric Joyner	iflib: Check IFLIB_ADMIN_ALWAYS_RUN flag in IOV task (Show More…)	Jul 24 2018, 4:59 AM
852bd8ab636f	60dda6e28966	7b5d4bb93deb	Eric Joyner	iflib: style fixes (Show More…)	Jun 26 2018, 4:03 PM
7b5d4bb93deb	e60bb1605513	fb41804a910a	Eric Joyner	iflib: Call pci_iov_detach() during iflib_device_deregister() (Show More…)	May 22 2018, 9:26 PM