Page MenuHomeFreeBSD
Differential D16920

Add an iflib manpage to section 4
ClosedPublic
Actions

Authored by shurd on Aug 27 2018, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 15, 12:40 PM
Unknown Object (File)
Mon, Apr 13, 5:39 PM
Unknown Object (File)
Sun, Apr 12, 12:15 AM
Unknown Object (File)
Thu, Apr 9, 12:32 AM
Unknown Object (File)
Sun, Apr 5, 1:15 PM
Unknown Object (File)
Tue, Mar 31, 5:43 AM
Unknown Object (File)
Mon, Mar 30, 11:13 PM
Unknown Object (File)
Sun, Mar 29, 8:15 AM
View All Files
Subscribers
ae
bcr
imp

Details

Reviewers
mmacy
benno
sbruno
erj
gallatin
bcr
Group Reviewers
manpages
Commits
rS338834: Add iflib.4 manpage
Summary

Initial cut of an iflib(4) manpage. For now, just a place
to document tunable and statistic sysctls.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19213
Build 18828: arc lint + arc unit

Event Timeline

shurd created this revision.Aug 27 2018, 3:16 PM
Herald added subscribers: ae, imp. · View Herald TranscriptAug 27 2018, 3:16 PM
Harbormaster completed remote builds in B19212: Diff 47345.Aug 27 2018, 3:16 PM
shurd updated this revision to Diff 47346.Aug 27 2018, 3:16 PM

Remove iflib.c patch.

Harbormaster completed remote builds in B19213: Diff 47346.Aug 27 2018, 3:16 PM
erj added a comment.Aug 27 2018, 4:02 PM

I wish there was a previewer for these...

bcr added a subscriber: bcr.Aug 27 2018, 5:21 PM

Can you run textproc/igor for the line breaks in the man page and possibly other errors? mandoc -Tlint would also be great.

Thanks!

share/man/man4/iflib.4
16

There needs to be a line break after a sentence stop.

87

Another line break is needed here after the sentence stop.

89

Another line break here...

108

Line break is needed here after the sentence stop.

shurd updated this revision to Diff 47356.Aug 27 2018, 6:34 PM

Run through igor and mandoc -Tlint

I still get a style warning, presumably because the prefix ends with a
period.

mandoc: man4/iflib.4:27:18: STYLE: no blank before trailing delimiter: Va dev.X.Y.iflib.

Harbormaster completed remote builds in B19221: Diff 47356.Aug 27 2018, 6:34 PM
shurd marked 4 inline comments as done.Aug 27 2018, 6:34 PM
bcr accepted this revision.Aug 27 2018, 7:09 PM

I think that's fine in this case. Thanks for the updates.

This revision is now accepted and ready to land.Aug 27 2018, 7:09 PM
erj accepted this revision.Aug 28 2018, 9:19 PM
Closed by commit rS338834: Add iflib.4 manpage (authored by shurd). · Explain WhySep 20 2018, 6:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
1 line
2 lines
1 line
180 lines
man9/
1 line

Diff 47346

View Options

share/man/man4/Makefile

Loading...
View Options

share/man/man4/bnxt.4

Loading...
View Options

share/man/man4/em.4

Loading...
View Options

share/man/man4/iflib.4

Loading...
View Options

share/man/man9/iflib.9

Loading...