ixlv(4): Update to use iflib; change name to iavf(4)
ClosedPublic
Actions

Authored by erj on Jul 24 2018, 6:37 PM.

Details

Reviewers

sbruno
shurd
kbowling
gallatin
jeffrey.e.pieper_intel.com

Group Reviewers

Intel Networking

Commits

rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9)

Summary

(Summary forthcoming)

A list of git commits that are contained in this revision can be found here: https://github.com/freebsd/freebsd/compare/master...intel-wired-ethernet:ixl-iflib-sriov

Also includes changes to the PF driver (ixl(4)).

Includes the contents of D16428 already.

Test Plan

(To be filled out)

At least run the VF driver with an ixl(4) host bare metal and using bhyve, and a Linux (RHEL?) host using KVM.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18682
Build 18366: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

ixl(4): Fix module Makefile when PCI_IOV is enabled

Harbormaster completed remote builds in B18360: Diff 45891.Jul 26 2018, 9:08 PM

In general, I looked around at ixlv.c, and it looks like there are many functions for the main pf which are identical, or nearly identical for the VF. Can we please work on collapsing them down to common code?

sys/dev/ixl/ixl_pf_main.c
2362	I just hate that there are 2 functions which do almost the same thing. Can't you just change the args to ixl_disable_rings() to take pf and qtag and do this in a single function?
sys/dev/ixl/ixl_txrx.c
501	Errant space.

ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one function.
Remove a space

Harbormaster completed remote builds in B18537: Diff 46214.Aug 2 2018, 8:47 PM

@gallatin, I address your specific comments, but I would need to look through ixlvc.c some more to find more code that can be shared. There is almost certainly some in there that can be shared between the PF/VF drivers.

ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to configure it

Harbormaster completed remote builds in B18564: Diff 46257.Aug 3 2018, 6:33 PM

Changes from D16428:

iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach
iflib: Add STATE_LOCK() around flag setting in iflib_request_reset()

New changes for D16429:

ixl(4): Add tunable to enable VF loopback; enable by default
ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing

Harbormaster completed remote builds in B18682: Diff 46482.Aug 9 2018, 6:40 PM

ixl(4): Fix compile error when PCI_IOV isn't defined

Harbormaster completed remote builds in B18688: Diff 46490.Aug 9 2018, 10:24 PM

gallatin accepted this revision.Aug 10 2018, 3:41 PM

This revision is now accepted and ready to land.Aug 10 2018, 3:41 PM

Several outstanding issues:

System back trace while running netperf tcp_rr test with jumbo frames enabled:

Fatal trap 12: page fault while in kernel mode
cpuid = 0; apic id = 00
fault virtual address = 0x1af0000
fault code = supervisor read data, page not present
instruction pointer = 0x20:0xffffffff80bdeb4f
stack pointer = 0x28:0xfffffe0025eeccb0
frame pointer = 0x28:0xfffffe0025eeccc0
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 12 (swi4: clock (0))
[ thread pid 12 tid 100034 ]
Stopped at m_tag_delete_chain+0x1f: movq (%rsi),%rdi
db> bt
Tracing pid 12 tid 100034 td 0xfffff800032c4580
m_tag_delete_chain() at m_tag_delete_chain+0x1f/frame 0xfffffe0025eeccc0
uma_zfree_arg() at uma_zfree_arg+0x3e/frame 0xfffffe0025eecd20
m_freem() at m_freem+0x9a/frame 0xfffffe0025eecd40
vtnet_txq_eof() at vtnet_txq_eof+0x75/frame 0xfffffe0025eecd70
vtnet_txq_mq_start_locked() at vtnet_txq_mq_start_locked+0x65/frame 0xfffffe0025eecdd0
vtnet_txq_mq_start() at vtnet_txq_mq_start+0x68/frame 0xfffffe0025eece10
ether_output_frame() at ether_output_frame+0xaa/frame 0xfffffe0025eece40
ether_output() at ether_output+0x6b7/frame 0xfffffe0025eecee0
ip_output() at ip_output+0x13e6/frame 0xfffffe0025eed020
tcp_output() at tcp_output+0x1b0c/frame 0xfffffe0025eed1b0
tcp_timer_delack() at tcp_timer_delack+0xf4/frame 0xfffffe0025eed1f0
softclock_call_cc() at softclock_call_cc+0x12e/frame 0xfffffe0025eed2a0
softclock() at softclock+0x79/frame 0xfffffe0025eed2c0
ithread_loop() at ithread_loop+0x1a7/frame 0xfffffe0025eed330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025eed370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025eed370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

Fatal trap 9: general protection fault while in kernel mode
cpuid = 1; apic id = 01
instruction pointer = 0x20:0xffffffff82d70048
stack pointer = 0x28:0xfffffe0025ec5150
frame pointer = 0x28:0xfffffe0025ec5180
code segment = base 0x0, limit 0xfffff, type 0x1b

= DPL 0, pres 1, long 1, def32 0, gran 1

processor eflags = interrupt enabled, resume, IOPL = 0
current process = 0 (if_io_tqg_1)
[ thread pid 0 tid 100026 ]
Stopped at ixl_isc_rxd_pkt_get+0xc8: cmpl ll+0x1b(%rax),%esi
db> bt
Tracing pid 0 tid 100026 td 0xfffff800032ad580
ixl_isc_rxd_pkt_get() at ixl_isc_rxd_pkt_get+0xc8/frame 0xfffffe0025ec5180
iflib_rxeof() at iflib_rxeof+0x136/frame 0xfffffe0025ec5260
_task_fn_rx() at _task_fn_rx+0x76/frame 0xfffffe0025ec52a0
gtaskqueue_run_locked() at gtaskqueue_run_locked+0x144/frame 0xfffffe0025ec5300
gtaskqueue_thread_loop() at gtaskqueue_thread_loop+0x98/frame 0xfffffe0025ec5330
fork_exit() at fork_exit+0x83/frame 0xfffffe0025ec5370
fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe0025ec5370

trap 0, rip = 0, rsp = 0, rbp = 0 ---

db>

It is possible to work around the issue by increasing the value of the rx_budget counter to the current value of the number of queues (44):
sysctl dev.ixl.0.iflib.rx_budget=44

Unable to initialize over 63 VF's:

Aug 10 14:48:56 u1017 kernel: ixl3: 0x400000 bytes of rid 0x184 res 3 failed (0, 0xffffffffffffffff).

Memory leak reported when unloading if_ixlv with 64 VF’s spawned:

Aug 10 14:51:18 u1017 kernel: ixlv62: Using MSIX interrupts with 5 vectors
Aug 10 14:51:18 u1017 kernel: ixlv62: Ethernet address: e2:db:49:42:7a:85
Aug 10 14:51:18 u1017 kernel: ixlv62: netmap queues/slots: TX 4/1024, RX 4/1024
Aug 10 14:51:18 u1017 kernel: ixlv63: <Intel(R) Ethernet Virtual Function 700 Series (X722)> at device 0.79 on pci13
Aug 10 14:51:18 u1017 kernel: ixlv62: link state changed to UP
Aug 10 14:51:18 u1017 kernel: ixlv63: PF API 1.1 / VF API 1.1
Aug 10 14:51:18 u1017 kernel: ixlv63: VSIs 1, QPs 4, MSIX 5, RSS sizes: key 52 lut 64
Aug 10 14:51:18 u1017 kernel: ixlv63: using 1024 tx descriptors and 1024 rx descriptors
Aug 10 14:51:18 u1017 kernel: ixlv63: msix_init qsets capped at 4
Aug 10 14:51:18 u1017 kernel: ixlv63: pxm cpus: 36 queue msgs: 4 admincnt: 1
Aug 10 14:51:18 u1017 kernel: ixlv63: using 4 rx queues 4 tx queues
Aug 10 14:51:18 u1017 kernel: ixlv63: Using MSIX interrupts with 4 vectors
Aug 10 14:51:18 u1017 kernel: ixlv63: failed to allocate IRQ for rid 5, name rxq3.
Aug 10 14:51:18 u1017 kernel: ixlv63: _iflib_irq_alloc failed 12
Aug 10 14:51:18 u1017 kernel: ixlv63: Failed to allocate queue RX int vector 3, err: 12
Aug 10 14:51:18 u1017 kernel: ixlv63: IFDI_MSIX_INTR_ASSIGN failed 12
Aug 10 14:51:18 u1017 kernel: device_attach: ixlv63 attach returned 12
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked MSI vectors
Aug 10 14:51:18 u1017 kernel: pci0:132:0:79: Device leaked memory resources

After kldunload:

Aug 10 15:00:18 u1017 kernel: ixlv62: detached
Aug 10 15:00:18 u1017 kernel: pci13: <network, ethernet> at device 0.78 (no driver attached)
Aug 10 15:00:18 u1017 kernel: Warning: memory type ixlv leaked memory on destroy (4 allocations, 8192 bytes leaked).

This revision now requires changes to proceed.Aug 10 2018, 4:20 PM

ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic

Harbormaster completed remote builds in B18703: Diff 46521.Aug 10 2018, 5:37 PM

ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
ixlv(4): Fix a memory leak when interrupt setup fails
ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
ixlv(4): Remove comments and commented out code
ixlv(4): Remove list of media types displayed in "ifconfig -m"

Harbormaster completed remote builds in B18780: Diff 46642.Aug 14 2018, 12:03 AM

ixl(4): Enhance Malicious Driver Detection messages with VF information
ixl(4): Print out additional event information when a LAN Overflow Event occurs
ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path

Harbormaster completed remote builds in B18879: Diff 46809.Aug 16 2018, 11:45 PM

gallatin added inline comments.Aug 17 2018, 7:34 PM

sys/dev/ixl/if_ixl.c
1198	Please consider limiting this to a few prints. Otherwise, I anticipate this spamming the console / messages log at some point for somebody.
sys/dev/ixl/ixl_pf_main.c
2457	Nice! This would have been helpful during bringup of the iflib driver, but better late than never :)
sys/dev/ixl/ixl_txrx.c
366	0 is a perfectly valid DMA address on non-x86, or on x86 when using IOMMUs

ixl(4): Fix RX MDD event display
ixl/ixlv(4): Add more MPASS statements to TX path

Harbormaster completed remote builds in B18994: Diff 47009.Aug 21 2018, 12:42 AM

ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message

Harbormaster completed remote builds in B19027: Diff 47074.Aug 22 2018, 12:48 AM

ixl/ixlv(4): Fix TXD credits update for DWB mode

Harbormaster completed remote builds in B19111: Diff 47190.Aug 23 2018, 5:56 PM

ixl(4): Fix memory leak when head writeback is disabled

Harbormaster completed remote builds in B19117: Diff 47209.Aug 23 2018, 9:22 PM

ixl/ixlv Missing semicolon in DWB fix

Harbormaster completed remote builds in B19214: Diff 47347.Aug 27 2018, 3:43 PM

iflib: Destroy state lock at end of iflib_device_deregister()
iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
ixl(4): Fix kernel panic during init() when Admin Queue is not alive

Harbormaster completed remote builds in B19307: Diff 47509.Aug 31 2018, 12:01 AM

ixlv(4): Swap MALLOC_DEFINE/DECLARE statements
ixlv(4): Remove commented out code
ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses
ixlv(4): Update some debug printf()'s to use newer debug functions
ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists

Harbormaster completed remote builds in B19398: Diff 47671.Sep 4 2018, 11:33 PM

ixlv(4): Disable queues before initialization.

Harbormaster completed remote builds in B19573: Diff 48012.Sep 13 2018, 6:00 PM

ixl(4): Configure promiscuous mode during driver init

Harbormaster completed remote builds in B19583: Diff 48025.Sep 13 2018, 11:00 PM

ixl(4): Fix compile error introduced by previous commit

Harbormaster completed remote builds in B19585: Diff 48027.Sep 13 2018, 11:10 PM

ixl(4): Fix filter handling when SR-IOV is enabled
Revert "iflib: Free RX queue TCP LRO memory on unload"

Harbormaster completed remote builds in B19703: Diff 48274.Sep 20 2018, 5:40 PM

ixlv(4): Update driver version to 2.0.0-k
ixlv(4): Remove dynamic ITR code, since it's unused
ixlv(4): Set max number of queues used in iflib based on number VF receives from PF
ixlv(4): Code cleanup
ixlv(4): Don't sleep for a response to a VC msg if driver is in detach
ixl(4): Clear VF qtag queue flags when VF is being reinitialized
ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for completion
ixlv(4): Modify debug prints, and stop printing out "Queue already enabled" warnings
ixl(4): Update version number to 2.1.0-k

Harbormaster completed remote builds in B19831: Diff 48493.Sep 27 2018, 12:56 AM

erj mentioned this in D15927: Update ixl(4) and ixlv(4) man pages.Oct 2 2018, 3:54 PM

Rebased onto latest master, and added:

ixl(4): Reconfigure MAC/VLAN filters after adding VEB during SR-IOV init

Harbormaster completed remote builds in B19934: Diff 48688.Oct 3 2018, 8:10 PM

Ugh, rebasing changes the commit SHAs :(

I guess it's the price you pay for the appearance of cleanliness...

krzysztof.galazka_intel.com mentioned this in D17404: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 4 2018, 12:32 PM

ixlv/iavf(4): Change "ixlv" driver name to "iavf"

Harbormaster completed remote builds in B19990: Diff 48761.Oct 4 2018, 10:29 PM

erj retitled this revision from ixlv(4): Update to use iflib to ixlv(4): Update to use iflib; change name to iavf(4).Oct 4 2018, 10:31 PM

iavf(4): Move modules/Makefile entry so that it's in alphabetical order
iavf(4): Update MODULE_* macros with new "iavf" name

Harbormaster completed remote builds in B20010: Diff 48795.Oct 5 2018, 6:52 PM

erj added a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 5 2018, 8:21 PM

erj added a child revision: D15927: Update ixl(4) and ixlv(4) man pages.

Can you rename the sys/dev/ixl dir to iavf as part of this? I'd really like to see this change done now in 12.0, it would be very awkward to try and MFC later.

Sorry the first part of my comment made no sense, ixl is the pf and will remain for 25/40g hw parts.

jeffrey.e.pieper_intel.com accepted this revision.Oct 11 2018, 8:14 PM

This revision is now accepted and ready to land.Oct 11 2018, 8:14 PM

sbruno accepted this revision.Oct 11 2018, 10:48 PM

Any last-minute assents or objections?

kbowling accepted this revision.Oct 12 2018, 5:55 AM

erj removed a parent revision: D16428: iflib: Changes for ixlv(4) update.Oct 12 2018, 5:28 PM

Closed by commit rS339338: ixl/iavf(4): Change ixlv to iavf and update it to use iflib(9) (authored by erj). · Explain WhyOct 12 2018, 10:41 PM

This revision was automatically updated to reflect the committed changes.

erj mentioned this in rS339634: iflib: drain enqueued tasks before detaching from taskqgroup.Oct 23 2018, 4:37 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

GENERIC

2 lines

NOTES

2 lines

conf/

files.amd64

8 lines

dev/

ixl/

34 lines

165 lines

2701 lines

36 lines

23 lines

33 lines

12 lines

179 lines

323 lines

15 lines

2 lines

195 lines

136 lines

595 lines

modules/

Makefile

1 line

ixl/

Makefile

10 lines

ixlv/

Makefile

4 lines

net/

iflib.h

4 lines

iflib.c

71 lines

Commit	Tree	Parents	Author	Summary	Date
3e43985686b5	bed37fc5f111	bcc57a58d81b	Eric Joyner	ixl/ixlv(4): Fix dev.ixl/v.#.vsi.rxq#.bytes sysctl not incrementing (Show More…)	Aug 9 2018, 6:23 PM
bcc57a58d81b	001e6851e428	610e38e25414	Eric Joyner	ixl(4): Add tunable to enable VF loopback; enable by default (Show More…)	Aug 9 2018, 12:10 AM
610e38e25414	d013f310b0a6	19f4eb834725	Eric Joyner	ixl(4): Lie to the VF about configuring promiscuous mode if VF isn't allowed to… (Show More…)	Aug 3 2018, 6:27 PM
19f4eb834725	bee2fa45bdb2	65ceef68f2ae	Eric Joyner	ixl(4): Combine PF-only/VF-only ixl_disable_rings() in PF driver into one… (Show More…)	Aug 2 2018, 8:41 PM
65ceef68f2ae	0212ae400731	f58d6e7f3f04	Eric Joyner	ixl(4): Fix module Makefile when PCI_IOV is enabled (Show More…)	Jul 26 2018, 9:02 PM
f58d6e7f3f04	6c36de1527b1	2031a27104b1	Eric Joyner	ixl/ixlv(4): Preserve code removal done in r336313 (Show More…)	Jul 25 2018, 7:54 PM
2031a27104b1	4cab0f71d1be	6627f2b2f40c	Eric Joyner	ixlv(4): Use same TX DMA seg sizes as the ones in ixl(4) (Show More…)	Jul 25 2018, 7:50 PM
6627f2b2f40c	fc539b15c224	f290be8ea706	Eric Joyner	ixlv(4): Remove old/dead code (Show More…)	Jul 25 2018, 5:58 PM
f290be8ea706	5b75ad27fdd7	b6020034b104	Eric Joyner	ixl/ixlv(4): Fix module Makefiles (Show More…)	Jul 25 2018, 4:15 PM
b6020034b104	2432c1f8673a	38a156190421	Eric Joyner	ixlv(4): Re-add driver to GENERIC and build files (Show More…)	Jul 25 2018, 4:08 PM
38a156190421	97797ba6e434	5d3bb3fe626b	Eric Joyner	ixlv(4): Fixup bad merge (Show More…)	Jul 24 2018, 7:17 AM
5d3bb3fe626b	794f6d8c35a3	54003576ee21	Eric Joyner	ixlv(4): Convert some M_DEVBUF malloc types to M_IXLV (Show More…)	Jul 24 2018, 6:48 AM
54003576ee21	d69a3955353e	14db0f54c9ef	Eric Joyner	ixlv(4): Check if ASQ is alive before sending message to PF (Show More…)	Jul 24 2018, 6:47 AM
14db0f54c9ef	d8d9171cf316	7c1bbe09cd1b	Eric Joyner	ixlv(4): Remove unused states and variables from ixlv.h (Show More…)	Jul 24 2018, 6:42 AM
7c1bbe09cd1b	0982e550153c	c0b7fe2cc98e	Eric Joyner	ixl(4): Update debug.filter_list to print out VF filters (Show More…)	Jul 24 2018, 6:41 AM
c0b7fe2cc98e	77e2f5dd75d3	aeb7b492ec26	Eric Joyner	ixl(4): Remove comments and unused sysctl (Show More…)	Jul 24 2018, 6:40 AM
aeb7b492ec26	62bff72a7266	e6fa161e2eaa	Eric Joyner	ixl(4): Add debug print statements to filter add/delete functions (Show More…)	Jul 24 2018, 6:40 AM
e6fa161e2eaa	29d5aa770f31	5fb662963e1a	Eric Joyner	ixl(4): Remove unnecessary MPASS() (Show More…)	Jul 24 2018, 6:39 AM
5fb662963e1a	4751f447a1be	e382705aa1f0	Eric Joyner	ixl(4): Set IXL_FILTER_USED when adding a MAC filter (Show More…)	Jul 24 2018, 6:38 AM
e382705aa1f0	604cf2965024	62e1eaf25f2f	Eric Joyner	ixl(4): Remove unused sysctl (Show More…)	Jul 24 2018, 6:38 AM
62e1eaf25f2f	e69fec9425c2	39b35615a63c	Eric Joyner	ixl(4): Admin queue interrupt fixes (and VFLR handling) (Show More…)	Jul 24 2018, 6:36 AM
39b35615a63c	6509fae61709	6000967fd3a1	Eric Joyner	ixl(4): Update ixl_handle_vflr() for iflib (Show More…)	Jul 24 2018, 6:34 AM
6000967fd3a1	12a6dbf55801	919352463759	Eric Joyner	ixl(4): Make VFs use LRXQTHRESH value of 1, like PF (Show More…)	Jul 24 2018, 6:32 AM
919352463759	98410bdb407a	b4fd8f578ea2	Eric Joyner	ixl(4): Re-add VF filters after VF reset (Show More…)	Jul 24 2018, 6:31 AM
b4fd8f578ea2	472b1fef2032	1d60d99c8f1f	Eric Joyner	ixl(4): Add new debug mask flag and shortcut functions (Show More…)	Jul 24 2018, 6:29 AM
1d60d99c8f1f	17664e9678f6	7132d7c93523	Eric Joyner	ixl(4): Remove unused variables in struct ixl_pf (Show More…)	Jul 24 2018, 6:27 AM
7132d7c93523	f39af9bc135b	7fdc14ddce5d	Eric Joyner	ixlv(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:48 AM
7fdc14ddce5d	133778d85cb9	2cf9d961b51f	Eric Joyner	ixlv(4): Fixes to admin queue interrupt handling (Show More…)	Jul 24 2018, 5:46 AM
2cf9d961b51f	1c43d9da1f38	8f913e07676a	Eric Joyner	ixlv(4): Re-enable PCI busmaster after reset (Show More…)	Jul 24 2018, 5:45 AM
8f913e07676a	ec56bc9763b5	c99a7422d1ef	Eric Joyner	ixlv(4): Add missing line break at end of message (Show More…)	Jul 24 2018, 5:44 AM
c99a7422d1ef	f7f749c55946	d5ef57722fc1	Eric Joyner	ixlv(4): Configure multicast promiscuous when there are more multicast filters… (Show More…)	Jul 24 2018, 5:43 AM
d5ef57722fc1	e50a581d0cd5	b9e0c5bca771	Eric Joyner	ixlv(4): Try to handle critical AQ errors better (Show More…)	Jul 24 2018, 5:42 AM
b9e0c5bca771	c82510c669ff	67feb914df8b	Eric Joyner	ixlv(4): Attempt to fix VFLR recovery (Show More…)	Jul 24 2018, 5:40 AM
67feb914df8b	c5bc6e58ac54	254da6bd972e	Eric Joyner	ixlv(4): Fix TX initialization (Show More…)	Jul 24 2018, 5:38 AM
254da6bd972e	0b7d7907887e	5a8f6517715a	Eric Joyner	ixlv(4): Add VF reset debug sysctls (Show More…)	Jul 24 2018, 5:36 AM
5a8f6517715a	b16827b1261b	44d0de845301	Eric Joyner	ixl(4): Remove commented-out code (Show More…)	Jul 24 2018, 5:29 AM
44d0de845301	b622a2500fff	1a215d575b37	Eric Joyner	ixlv(4): Set a driver state for the VF at the end of attach (Show More…)	Jul 24 2018, 5:09 AM
1a215d575b37	b8a7a3f71a3f	7a4d7a1768dc	Eric Joyner	ixlv(4): Don't set IFLIB_ADMIN_ALWAYS_RUN flag (Show More…)	Jul 24 2018, 5:07 AM
7a4d7a1768dc	0f4416bf579d	73b313830e86	Eric Joyner	ixl(4): Make ixl_if_vflr_handle() call ixl_handle_vflr() (Show More…)	Jul 24 2018, 5:06 AM
73b313830e86	191c897a1739	ee0216c32a25	Eric Joyner	ixl(4): Setup softirq to handle VFLR interrupt task (Show More…)	Jul 24 2018, 5:06 AM
ee0216c32a25	e403fa8bdd5a	0f416c2f2883	Eric Joyner	ixl(4): Remove old comment (Show More…)	Jul 24 2018, 5:05 AM
0f416c2f2883	6e90fc6cf1ed	1e4c18d9352c	Eric Joyner	ixlv(4): Add VF reset request debug sysctl (Show More…)	Jul 14 2018, 12:21 AM
1e4c18d9352c	5cffb042fb94	dbc89406a775	Eric Joyner	ixlv(4): Convert VC msg functions to return an error on failure, instead of void (Show More…)	Jul 14 2018, 12:08 AM
dbc89406a775	78b461c3cb83	23abdfad7173	Eric Joyner	ixlv(4): Remove unnecessary #include (Show More…)	Jul 13 2018, 11:37 PM
23abdfad7173	dbec1f511f10	64ffe03c3ee9	Eric Joyner	ixl/ixlv(4): Add per-queue stats to VF (Show More…)	Jul 13 2018, 11:05 PM
64ffe03c3ee9	341e77f84665	b86690548955	Eric Joyner	ixl/ixlv(4): Add VSI stats sysctls to VF driver (Show More…)	Jul 13 2018, 7:35 PM
b86690548955	a05ab4ddcac3	27c6f7c58421	Eric Joyner	ixlv(4): Enable checking for critical AQ errors during AQ processing (Show More…)	Jul 13 2018, 6:42 PM
27c6f7c58421	290f5c6dba63	1e042e4dd0e3	Eric Joyner	ixlv: Add debug sysctl to print out VF filter lists (Show More…)	Jul 12 2018, 5:12 PM
1e042e4dd0e3	dcb6e16ebd2e	3ca3b9194156	Eric Joyner	ixl/ixlv: Support for the VF configuring promiscuous mode (Show More…)	Jul 11 2018, 10:21 PM
3ca3b9194156	a0139137e02b	1d36106bf36b	Eric Joyner	ixl/ixlv: Remove README and commented out code	Jul 9 2018, 7:25 PM
1d36106bf36b	2c28471a398a	6fb339c50c94	Eric Joyner	ixlv: Start reworking VF sysctls, change more debug statements to use new… (Show More…)	Jul 7 2018, 12:20 AM
6fb339c50c94	86e1de0a7293	ce30885e09ae	Eric Joyner	ixlv: Add core_debug_mask & shared_debug_mask sysctls and tunables (Show More…)	Jul 5 2018, 11:48 PM
ce30885e09ae	81a0d71f49d4	81ec19e7acba	Eric Joyner	ixl/ixlv: Re-comment printf (Show More…)	Jul 3 2018, 12:52 AM
81ec19e7acba	14a48e4d85b8	ad40f5d697b1	Eric Joyner	ixl/ixlv: VF can ping! (Show More…)	Jul 3 2018, 12:48 AM
ad40f5d697b1	e614437f2b4d	3d9e38fc2068	Eric Joyner	ixlv: Fix compile error and memory leak (Show More…)	Jun 29 2018, 9:49 PM
3d9e38fc2068	b54eb6ebb48d	4b6c34cf22ed	Eric Joyner	ixl/ixlv: Make a large number of small changes (Show More…)	Jun 29 2018, 9:45 PM
4b6c34cf22ed	cbb7c54c927c	3b3db2684f7b	Eric Joyner	ixlv(4): Remove a couple empty lines (Show More…)	Jun 27 2018, 8:19 PM
3b3db2684f7b	a3bc2c356dee	e7a1eabc32c9	Eric Joyner	ixl(4): Reset created VF after it is setup (Show More…)	Jun 26 2018, 6:03 PM
e7a1eabc32c9	10fc29baaf2c	fe2cfa15a324	Eric Joyner	ixl/ixlv(4): Move ixl_aq_max_speed_to_value back into PF-only files from… (Show More…)	Jun 26 2018, 6:03 PM
fe2cfa15a324	e6e745a8746f	a484c872550f	Eric Joyner	ixlv(4): Update comments and formatting (Show More…)	Jun 26 2018, 6:02 PM
a484c872550f	db65785b262f	339b2fe46eb9	Eric Joyner	ixlv(4): Remove commented out code (Show More…)	Jun 26 2018, 6:02 PM
339b2fe46eb9	546dfff2eb7b	62ce9b4ab285	Eric Joyner	ixlv(4): Assert that VC mgr is setup when ixl_if_init() begins (Show More…)	Jun 26 2018, 6:02 PM
62ce9b4ab285	6e0cdde95cb3	f132bbb61a9f	Eric Joyner	ixlv(4): Update more functions to use ixlv_sc as interface softc (Show More…)	Jun 26 2018, 6:01 PM
f132bbb61a9f	509e459f3299	4e989a5f30d7	Eric Joyner	ixlv(4): Call ixl_vc_init_mgr() on attach (Show More…)	Jun 26 2018, 5:59 PM
4e989a5f30d7	d69b942bd32f	53aa12539de7	Eric Joyner	ixlv(4): Fix panic on failed attach (Show More…)	Jun 26 2018, 5:57 PM
53aa12539de7	5edd7d04e1fa	de7738a5c0b3	Eric Joyner	ixl/ixlv(4): Stop setting legacy intr field in iflib txrx function pointer… (Show More…)	Jun 26 2018, 4:01 PM
de7738a5c0b3	33ee5d85eeb0	f7f0ca6b2db3	Eric Joyner	ixlv(4): Remove some of the calls to ixl_vc_mgr code (Show More…)	Jun 26 2018, 12:36 AM
f7f0ca6b2db3	ae3773da1418	b0b2e5784d7d	Eric Joyner	ixlv(4): Change version string and device ID list to match ixl(4)'s (Show More…)	Jun 22 2018, 11:29 PM
b0b2e5784d7d	f1c9f8cbc17b	5a6034ed0b78	Eric Joyner	ixl(4): Fix up error message by adding a newline (Show More…)	Jun 19 2018, 5:57 PM
5a6034ed0b78	47f3031d9bc7	993f615cf184	Eric Joyner	ixl(4): Fix kernel panic (Show More…)	May 24 2018, 11:07 PM
993f615cf184	9eba16f6bcf1	79fa2ba69ca0	Eric Joyner	ixl(4): Fix VF queue disable during reinit (Show More…)	May 24 2018, 10:39 PM
79fa2ba69ca0	91c63d880f58	f894f035e5ad	Eric Joyner	ixl(4): Remove unused variables	May 23 2018, 6:41 PM
f894f035e5ad	95cde96f0d20	3f0c139eb978	Eric Joyner	ixl(4): Fix improper queue mapping during PF LAN VSI context setup (Show More…)	May 22 2018, 9:33 PM
3f0c139eb978	19c36776703e	423531b3aaf7	Eric Joyner	ixl(4): Change malloc type to M_NOWAIT (Show More…)	Jul 24 2018, 5:23 PM
423531b3aaf7	a3206ae6bd36	1be7a98dbc99	Eric Joyner	ixl(4): Get device_t from pf struct instead of iflib (Show More…)	Jul 24 2018, 5:22 PM
1be7a98dbc99	0c115d86d007	0117cb54dad7	Eric Joyner	ixl(4): Remove pci_iov_detach() call from driver detach (Show More…)	Jul 24 2018, 5:06 PM
0117cb54dad7	c4c695480442	24360fb5a3e2	Eric Joyner	ixl(4): Implement SR-IOV handlers for iflib (Show More…)	Jul 24 2018, 5:04 PM
24360fb5a3e2	5d8d4c397641	7ca4a842b898	Eric Joyner	iflib: Add STATE_LOCK() around flag setting in iflib_request_reset() (Show More…)	Aug 9 2018, 6:28 PM
7ca4a842b898	0787db6d4feb	4689c8c2b36d	Eric Joyner	iflib: Prevent kernel panic on detach in _task_fn_admin by checking if in detach (Show More…)	Aug 9 2018, 6:11 PM
4689c8c2b36d	72b8c72e1721	68d6fb979281	Eric Joyner	iflib: Add public iflib_request_reset() for drivers to use (Show More…)	Jul 24 2018, 5:00 AM
68d6fb979281	b724ba44800f	2342b72f9dbd	Eric Joyner	iflib: Check IFLIB_ADMIN_ALWAYS_RUN flag in IOV task (Show More…)	Jul 24 2018, 4:59 AM
2342b72f9dbd	643d051c2229	50e8bfbc018b	Eric Joyner	iflib: style fixes (Show More…)	Jun 26 2018, 4:03 PM
50e8bfbc018b	3bee8007af32	a4d7516115c4	Eric Joyner	iflib: Call pci_iov_detach() during iflib_device_deregister() (Show More…)	May 22 2018, 9:26 PM