Page MenuHomeFreeBSD

acquire inp lock around ip6_pcbopt to fix IPV6_TCLASS panic
ClosedPublic

Authored by jason_eggnet.com on Jul 9 2018, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 17, 11:10 PM
Unknown Object (File)
Sun, Oct 12, 9:18 AM
Unknown Object (File)
Thu, Oct 9, 3:32 PM
Unknown Object (File)
Sun, Oct 5, 6:44 AM
Unknown Object (File)
Thu, Oct 2, 4:45 AM
Unknown Object (File)
Wed, Oct 1, 1:45 AM
Unknown Object (File)
Tue, Sep 30, 5:23 PM
Unknown Object (File)
Tue, Sep 30, 6:12 AM
Subscribers

Details

Summary

Hopefully simple fix to address panics relating to setting IPV6_TCLASS with setsockopt().

The premise of this fix is that it is ok to call malloc with M_NOWAIT while holding a lock on the in6p.

If it is not ok, then major surgery will be required, as ip6_setpktopt() will have to be fixed (as it also calls malloc with M_NOWAIT) which pulls in the ip6_pcbopts(), ip6_setpktopts(), ip6_setpktopt() call chain. The other call chain does have to be fixed but it can be done in a different review (and with relative ease) if this strategy works out.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17943
Build 17698: arc lint + arc unit