Page MenuHomeFreeBSD

acquire inp lock around ip6_pcbopt to fix IPV6_TCLASS panic
ClosedPublic

Authored by jason_eggnet.com on Jul 9 2018, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 5:07 PM
Unknown Object (File)
Fri, Mar 8, 4:54 AM
Unknown Object (File)
Mon, Mar 4, 4:52 PM
Unknown Object (File)
Feb 8 2024, 5:28 PM
Unknown Object (File)
Jan 17 2024, 5:36 PM
Unknown Object (File)
Jan 13 2024, 8:55 PM
Unknown Object (File)
Dec 26 2023, 7:16 AM
Unknown Object (File)
Dec 20 2023, 1:28 AM
Subscribers

Details

Summary

Hopefully simple fix to address panics relating to setting IPV6_TCLASS with setsockopt().

The premise of this fix is that it is ok to call malloc with M_NOWAIT while holding a lock on the in6p.

If it is not ok, then major surgery will be required, as ip6_setpktopt() will have to be fixed (as it also calls malloc with M_NOWAIT) which pulls in the ip6_pcbopts(), ip6_setpktopts(), ip6_setpktopt() call chain. The other call chain does have to be fixed but it can be done in a different review (and with relative ease) if this strategy works out.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17943
Build 17698: arc lint + arc unit